Re: [PATCH 09/10] fstests: tmpfs: expunges: testing

[Daniel Gomez <da.gomez@kernel.org>]

On 16/06/2025 22.36, Chuck Lever wrote:
> On 6/16/25 4:24 PM, Daniel Gomez wrote:
>>
>>
>> On 16/06/2025 16.31, Chuck Lever wrote:
>>> On 6/16/25 6:41 AM, Daniel Gomez wrote:
>>>>
>>>> On 15/06/2025 18.18, Chuck Lever wrote:
>>>>> On 6/15/25 5:58 AM, Daniel Gomez wrote:
>>> generic/561 is testing file de-dup, which tmpfs does not implement.
>>>
>>> generic/561 looks for the dupremove utility on the test system to
>>> know whether to run the test. That's a poor check, say, if the test
>>> system is used for testing other file systems, or dupremove is installed
>>> by default.
>>
>> We need to fix that in kdevops and then figure out if generic/561 applies or
>> not.
>>
>>>
>>> Could be that 3b9f5fc7d7d8 ("common: call _require_scratch_dedupe from
>>> _require_scratch_duperemove") fixes that so that 561 no longer needs
>>> to be explicitly expunged for NFS and tmpfs.
>>>
>>>
>>
>> The above logs are from an fstests deployed by kdevops which already has that
>> commit.
>>
>> git -C /data/fstests log --oneline -1
>> 2cc8c822 (HEAD -> master, origin/master, origin/HEAD) fstests: btrfs: testcase
>> for sysfs chunk_size attribute validation
>>
>> So, I added duperemove package to the VM and run the test again:
>>
>> [   14.841609] run fstests fstestsstart/000 at 2025-06-16 18:17:35
>> [   16.365091] run fstests generic/561 at 2025-06-16 18:17:36
>> [   17.141361] run fstests fstestsdone/000 at 2025-06-16 18:17:37
>>
>> cat /data/fstests-install/xfstests/results/debian13-tmpfs-default/6.16.0-rc2/
>> tmpfs_default/generic/561.notrun
>> Dedupe not supported by scratch filesystem type: tmpfs
>>
>> I think the correct path is to add duperemove as fstests workflow dependency to
>> properly skip the test for tmpfs.
> 
> That sounds correct to me.

Added duperemove package to fstests workflow:
ac918af2fb3b fstests: debian: add duperemove dependency

https://github.com/linux-kdevops/kdevops/commit/ac918af2fb3bbd33c81281073f46f84025cffa5a