From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A23D2ED155 for ; Thu, 26 Jun 2025 19:10:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750965008; cv=none; b=RNGyUlBVAD7cbT7OSDqIegMqhddEu8JCCEtAGTnNV9rWGN0dRnjuNqD839UflI9OaaaafR/dRaD6Ua4kXRxbEqn86Uz4uujytu13eDEjvkNZjw0gAwjLxo8NzPXfGBEzilJ139i7D7u6zq6ZICb5/igAKC0prLiJ6joAR0eQ7j4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750965008; c=relaxed/simple; bh=9EhLLW0qslVMEDgYTLH3/WTEsY3w63+mak35xYun4BU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kRTOkAqJYvFrBFWNFqPl24vT+EHRciK7fw865OilihXqPrHK9MzSn21WC9xYM/ynFALSTOpi0v/NJA+8LfpRpdd31KndhFy135SBch/Rf+1rGre1oCLOkHq+AopDNw7LWo6bhZiDt77hIRjtkw5xOaTBYPzuWHcGFLr9Jgj1w+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VL8Y68Hl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VL8Y68Hl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F3D9C4CEEB; Thu, 26 Jun 2025 19:10:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750965008; bh=9EhLLW0qslVMEDgYTLH3/WTEsY3w63+mak35xYun4BU=; h=Date:Reply-To:Subject:To:Cc:References:From:In-Reply-To:From; b=VL8Y68HlrjS1H9t3uJGYzuPCVMcnvGv33nyfShvgRZXQwNIafUW+K3i6i3egOB3BN 44LosNT7+FIS9e9RN4C9BOUEU6r7yKQ9VOSWUUxFYRy3gRG2q4OJ/wcmO2h0lxRJCu 647DcATrFJrIJelsn1iEjW+9GAM0atKfEpZinTNnEXX9yh9v8UET4rIHuRb6DNyWpC KgAoxxtPYE+hwz0VEajhilFsq6CXu4FxHgQS4i3/5ZFAFcu0cT9KLHGlMc+2DWxGXR R9/PXwvA/us7rTNAsa1xPQ58u3q5PxwEStPL1KOLkECFjD71V7PTl8x7ajCFxNIr5Z d75ZgGI3YWuPw== Message-ID: <9655630e-5331-47f9-951d-8a48ef53a372@kernel.org> Date: Thu, 26 Jun 2025 21:10:05 +0200 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Daniel Gomez Subject: Re: [PATCH 09/10] fstests: tmpfs: expunges: testing To: Chuck Lever , Luis Chamberlain Cc: kdevops@lists.linux.dev, Daniel Gomez References: <20250615-ci-workflow-v1-0-53b267cd2f0a@samsung.com> <20250615-ci-workflow-v1-9-53b267cd2f0a@samsung.com> <09ef783c-32c5-4558-8c73-8311b6742f29@oracle.com> <46577bbc-69c9-463c-ab1b-8acde1ec40a2@oracle.com> Content-Language: en-US From: Daniel Gomez Organization: kernel.org In-Reply-To: <46577bbc-69c9-463c-ab1b-8acde1ec40a2@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/06/2025 22.36, Chuck Lever wrote: > On 6/16/25 4:24 PM, Daniel Gomez wrote: >> >> >> On 16/06/2025 16.31, Chuck Lever wrote: >>> On 6/16/25 6:41 AM, Daniel Gomez wrote: >>>> >>>> On 15/06/2025 18.18, Chuck Lever wrote: >>>>> On 6/15/25 5:58 AM, Daniel Gomez wrote: >>> generic/561 is testing file de-dup, which tmpfs does not implement. >>> >>> generic/561 looks for the dupremove utility on the test system to >>> know whether to run the test. That's a poor check, say, if the test >>> system is used for testing other file systems, or dupremove is installed >>> by default. >> >> We need to fix that in kdevops and then figure out if generic/561 applies or >> not. >> >>> >>> Could be that 3b9f5fc7d7d8 ("common: call _require_scratch_dedupe from >>> _require_scratch_duperemove") fixes that so that 561 no longer needs >>> to be explicitly expunged for NFS and tmpfs. >>> >>> >> >> The above logs are from an fstests deployed by kdevops which already has that >> commit. >> >> git -C /data/fstests log --oneline -1 >> 2cc8c822 (HEAD -> master, origin/master, origin/HEAD) fstests: btrfs: testcase >> for sysfs chunk_size attribute validation >> >> So, I added duperemove package to the VM and run the test again: >> >> [ 14.841609] run fstests fstestsstart/000 at 2025-06-16 18:17:35 >> [ 16.365091] run fstests generic/561 at 2025-06-16 18:17:36 >> [ 17.141361] run fstests fstestsdone/000 at 2025-06-16 18:17:37 >> >> cat /data/fstests-install/xfstests/results/debian13-tmpfs-default/6.16.0-rc2/ >> tmpfs_default/generic/561.notrun >> Dedupe not supported by scratch filesystem type: tmpfs >> >> I think the correct path is to add duperemove as fstests workflow dependency to >> properly skip the test for tmpfs. > > That sounds correct to me. Added duperemove package to fstests workflow: ac918af2fb3b fstests: debian: add duperemove dependency https://github.com/linux-kdevops/kdevops/commit/ac918af2fb3bbd33c81281073f46f84025cffa5a