public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: Daniel Gomez <da.gomez@kernel.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>,
	Scott Mayhew <smayhew@redhat.com>,
	Jeff Layton <jlayton@kernel.org>,
	kdevops@lists.linux.dev, Daniel Gomez <da.gomez@samsung.com>
Subject: Re: [PATCH 0/2] Align guest dependencies with their corresponding workflows
Date: Fri, 25 Jul 2025 09:33:52 +0200	[thread overview]
Message-ID: <9f1938e6-ffaf-46ca-ad52-aa54d9b31840@kernel.org> (raw)
In-Reply-To: <aIKOG1pH4axgLHGD@bombadil.infradead.org>



On 24/07/2025 21.48, Luis Chamberlain wrote:
> On Thu, Jul 24, 2025 at 08:34:14PM +0200, Daniel Gomez wrote:
>> Several guest services (krb5, kdc, smbd, iscsi, nfsd) are missing from
>> various host workflow template files, creating kconfig configuration
>> inconsistencies. This occurs when workflows either lack implementation
>> support for these services or have no functional dependency on them.
>> This patch series ensures kconfig options accurately reflect the
>> services actually available in each workflow template.
>>
>> Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
> 
> Looks good, just stylistic, I think its easier to just have
> 
> Generated-by:
> Signed-off-by:
> 
> Instead of:
> 
> Generated-by:
> 
> Signed-off-by:
> 
> No point in the extra new line.

For that, I think it's better to update CLAUDE.md to be consistent. This is what
it generated:

    docs: update commit message format for Claude AI

    Clarify the standard format for commits generated by Claude AI to ensure
    consistent tagging across the project. The format specifies that the
    Generated-by tag should precede the Signed-off-by tag with no blank lines
    between them.

    Generated-by: Claude AI
    Signed-off-by: Daniel Gomez <da.gomez@samsung.com>

diff --git a/CLAUDE.md b/CLAUDE.md
index 8bee7c0..4018f52 100644
--- a/CLAUDE.md
+++ b/CLAUDE.md
@@ -206,10 +206,16 @@ any spell fixes unless asked explicitly to do that.
 We want to use the Signed-off-by tag which embodies the application of the
 Developer Certificate or Origin.

-## Use Generated-by: Claude AI
+## Commit Message Format

-Use this tag for code generated by Claude code AI. Put this before the
-Signed-off-by tag.
+For all commits generated by Claude AI, use the following format:
+
+```
+Generated-by: Claude AI
+Signed-off-by: <author>
+```
+
+The `Generated-by:` tag should always precede the `Signed-off-by:` tag with no blank lines between them.

 ## Prompt Examples


> 
> Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>

Thanks!

> 
>   Luis

  reply	other threads:[~2025-07-25  7:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-24 18:34 [PATCH 0/2] Align guest dependencies with their corresponding workflows Daniel Gomez
2025-07-24 18:34 ` [PATCH 1/2] kconfig: add workflow dependencies for SMBD and KRB5 services Daniel Gomez
2025-07-24 18:34 ` [PATCH 2/2] kconfig: add workflow dependencies for NFSD and iSCSI services Daniel Gomez
2025-07-24 19:44 ` [PATCH 0/2] Align guest dependencies with their corresponding workflows Chuck Lever
2025-07-24 19:48 ` Luis Chamberlain
2025-07-25  7:33   ` Daniel Gomez [this message]
2025-07-25  7:39     ` Luis Chamberlain
2025-07-25  8:09       ` Daniel Gomez
2025-07-25  8:15         ` Luis Chamberlain
2025-07-25 13:45           ` Daniel Gomez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f1938e6-ffaf-46ca-ad52-aa54d9b31840@kernel.org \
    --to=da.gomez@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=da.gomez@samsung.com \
    --cc=jlayton@kernel.org \
    --cc=kdevops@lists.linux.dev \
    --cc=mcgrof@kernel.org \
    --cc=smayhew@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox