From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBCAD149DFF for ; Sat, 29 Mar 2025 22:43:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743288187; cv=none; b=ZM6GdJf9+EH3+pU7ArKuw6Ipo1+1KFxH6VL+LOjotg5bhokBbI5uvHEbwz9Gbp/rXX4FLS7tpoqiwB6uliO4jlhHiksntIETOKcV4uf9nJ2O+s3by6YnaC704ZUiK66SCm1R5GCzsmihGuEZmgzcCIZbP+2j3Mxd2EgHcdQbkes= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743288187; c=relaxed/simple; bh=CIL/bN46mZ4RdsdwcgFq3DW59NKdXFP3Z3c7ET4+nTw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K2EHVjbXou1MRqWHDvNx/WobmnLdm/wHDoIA7PrxslXOANvDCPxCU9bZbh8QiHqOA12fPasc75onhfme5VGbnmkA3dSxDLLupUKJvumSoXibw5udQoPMXrWGzwBBNxh9KxsiX+/WamqyVoPcvQrb+gXDvqXXMR6fFmt6eIDI48E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ePnsrraD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ePnsrraD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E240C4CEE2; Sat, 29 Mar 2025 22:43:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743288187; bh=CIL/bN46mZ4RdsdwcgFq3DW59NKdXFP3Z3c7ET4+nTw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ePnsrraDzl1uwjl0uyCtbyGTzVecIbdOZ2rHe57LDMkvAw6Meg314+uDkd7q/Umdt cNvMzTbIaVCdNvgy/at6KPa7t3GPmWyOJyoMuZdv1zPWb2F8ELs4txb+i3fFGUMFQx BhYf4WrEe/wDKBjq5hDrI9z/609LHK4Ti/RthFtB4kOPjCIypuqeY/RebLoxmBQvU5 oifPsvs+glVNtVLZ7vSrEeFl1/LGkHt/jx2WlPwVLT73ig8zngC2fu2Q/5YW3eVQ9N yAA0zcRPTDH/C+VYSWm2P/PHJ07lWmjpe2Ar/frasVm/RcM4wG7FDAe8bhRMFU5aWm J8sVGtkN4lMWQ== Date: Sat, 29 Mar 2025 15:43:05 -0700 From: Luis Chamberlain To: Daniel Gomez Cc: kdevops@lists.linux.dev Subject: Re: [PATCH 5/6] guestfs: add ansible group permisison check on libvirt system uri Message-ID: References: <20250323115009.269172-1-mcgrof@kernel.org> <20250323115009.269172-6-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Mar 29, 2025 at 02:55:27PM -0700, Luis Chamberlain wrote: > On Tue, Mar 25, 2025 at 03:53:09PM +0100, Daniel Gomez wrote: > > Shall we ensure that the pool folder is created with group write permissions? > > Yes. > > That's a needed fix in this series. I'll replace the verify check for system session with just these two tasks way above: - name: Create storage pool path directory if using libvirt session URI file: path: "{{ libvirt_storage_pool_path }}" state: directory mode: "0775" when: libvirt_use_session_uri | default(false) | bool tags: - vars - name: Create storage pool path directory and set group if using libvirt system URI file: path: "{{ libvirt_storage_pool_path }}" state: directory owner: root group: "{{ libvirt_qemu_group }}" mode: "0775" when: not libvirt_use_session_uri | default(false) | bool tags: - vars