Re: [PATCH 6/6] gen_nodes: ensure kdevops prefix has no dashes

[Scott Mayhew <smayhew@redhat.com>]

On Sat, 29 Mar 2025, Luis Chamberlain wrote:

> Folks trying to use kdevops and testing with fstests will quickly
> find out a surprise that their config is not being parsed correctly
> until later.
> 
> Fix this by preventing bringup if the prefix has a dash.
> 
> We use the dash to help parallelize testing filesystem profiles and
> so the host prefix goes before the filesystem name and test profile.

Where does that happen?  All of my kdevops setups use multiple dashes in
the host prefix (e.g. "kdevops-nfs-fstests-rhel-10-nightly"), so this
breaks my setup, and I'd imagine it breaks Chuck's too.

-Scott
> 
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>  playbooks/roles/gen_nodes/tasks/main.yml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/playbooks/roles/gen_nodes/tasks/main.yml b/playbooks/roles/gen_nodes/tasks/main.yml
> index d541dcbf1f54..8c6a1f705ee2 100644
> --- a/playbooks/roles/gen_nodes/tasks/main.yml
> +++ b/playbooks/roles/gen_nodes/tasks/main.yml
> @@ -18,6 +18,11 @@
>    command: "id -g -n"
>    register: my_group
>  
> +- name: Fail if kdevops_host_prefix contains a dash
> +  fail:
> +    msg: "Invalid kdevops_host_prefix '{{ kdevops_host_prefix }}'. The prefix cannot contain a dash ('-')."
> +  when: kdevops_host_prefix is search("-")
> +
>  - name: Create guestfs directory
>    ansible.builtin.file:
>      path: "{{ guestfs_path }}"
> -- 
> 2.47.2
> 
>