From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72E3A1DF270 for ; Mon, 31 Mar 2025 17:35:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743442550; cv=none; b=o9t9zC4f621MgkA8vZ3jdHo8Ic4U/ycKmaKizwLB0iTa4qe+XfTXNKdLjpcmfaQ0duHmqJNiFZOhxSL0O3josWYHZKQrpUINWpe5HU4YrLyEbI4MiNVv8I/vk7MogGM6e5ONA1Jc5sIMkEPIhW8cJfHOV3hYwEa0NzYkvpy1KIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743442550; c=relaxed/simple; bh=0ABJjgMWtqrDPmvssx+TWjGagpt+Ed+j3JrpEmfT9Og=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=QUIbdFSbZ5fID08RAzZzKTIwhuPLmDhS/ZQ4ABgoSZIYuyuFA+WBSULITi7XfpOCIM/Wkk9JbBDdVRH2gjHt9VcK4rkCKcX5h+KwTg2P7C+k8ssMxz7s2Jgj7DYfbgXdQpJXSI/pUNJ3/MBqsiSxGXNa7dPmXHGsbxVop1Hy9TY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gEt+FjIt; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gEt+FjIt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743442547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VSHOq3w6kj2NvH6dSAumjQkrXsL+RtW84Pkko9YQow0=; b=gEt+FjItOPBr+CK5Svhf6HI9lTyWdTvLGrem/WnwVzbyehYBZpXqQ8aXNoOwui+u8dMVXT VULfB+b5U2hJ8BR8GcsW5ebuOsfeJFK/ngPZCb69IMDuqF4J/ia3Nd2NqTuo1H+1PmtzOs cHebPlpyEINRzyl/a7umBB2y37vqm8g= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-373-KUAnlFl9OmGEXgoxf--iSQ-1; Mon, 31 Mar 2025 13:35:44 -0400 X-MC-Unique: KUAnlFl9OmGEXgoxf--iSQ-1 X-Mimecast-MFC-AGG-ID: KUAnlFl9OmGEXgoxf--iSQ_1743442543 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1D70F19560AB; Mon, 31 Mar 2025 17:35:43 +0000 (UTC) Received: from aion.redhat.com (unknown [10.22.88.143]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CAF241828AAA; Mon, 31 Mar 2025 17:35:42 +0000 (UTC) Received: by aion.redhat.com (Postfix, from userid 1000) id 2F03233D6FF; Mon, 31 Mar 2025 13:35:41 -0400 (EDT) Date: Mon, 31 Mar 2025 13:35:41 -0400 From: Scott Mayhew To: Luis Chamberlain Cc: kdevops@lists.linux.dev Subject: Re: [PATCH 6/6] gen_nodes: ensure kdevops prefix has no dashes Message-ID: References: <20250329230141.3718282-1-mcgrof@kernel.org> <20250329230141.3718282-7-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20250329230141.3718282-7-mcgrof@kernel.org> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xkH1MUbk_ATwN2JJPt9ckKVZYki-50Ghd_SSNPvtkeA_1743442543 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, 29 Mar 2025, Luis Chamberlain wrote: > Folks trying to use kdevops and testing with fstests will quickly > find out a surprise that their config is not being parsed correctly > until later. > > Fix this by preventing bringup if the prefix has a dash. > > We use the dash to help parallelize testing filesystem profiles and > so the host prefix goes before the filesystem name and test profile. Where does that happen? All of my kdevops setups use multiple dashes in the host prefix (e.g. "kdevops-nfs-fstests-rhel-10-nightly"), so this breaks my setup, and I'd imagine it breaks Chuck's too. -Scott > > Signed-off-by: Luis Chamberlain > --- > playbooks/roles/gen_nodes/tasks/main.yml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/playbooks/roles/gen_nodes/tasks/main.yml b/playbooks/roles/gen_nodes/tasks/main.yml > index d541dcbf1f54..8c6a1f705ee2 100644 > --- a/playbooks/roles/gen_nodes/tasks/main.yml > +++ b/playbooks/roles/gen_nodes/tasks/main.yml > @@ -18,6 +18,11 @@ > command: "id -g -n" > register: my_group > > +- name: Fail if kdevops_host_prefix contains a dash > + fail: > + msg: "Invalid kdevops_host_prefix '{{ kdevops_host_prefix }}'. The prefix cannot contain a dash ('-')." > + when: kdevops_host_prefix is search("-") > + > - name: Create guestfs directory > ansible.builtin.file: > path: "{{ guestfs_path }}" > -- > 2.47.2 > >