public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Chuck Lever <cel@kernel.org>, kdevops@lists.linux.dev
Subject: Re: [PATCH RFC 3/6] kdevops: Fix raw "include:" directives
Date: Mon, 4 Mar 2024 16:40:01 -0500	[thread overview]
Message-ID: <ZeY_sUchuI-63RaM@manet.1015granger.net> (raw)
In-Reply-To: <ZeY1gFYGm02Xj1-7@bombadil.infradead.org>

On Mon, Mar 04, 2024 at 12:56:32PM -0800, Luis Chamberlain wrote:
> On Sun, Mar 03, 2024 at 01:07:40PM -0500, Chuck Lever wrote:
> > From: Chuck Lever <chuck.lever@oracle.com>
> > 
> > The version of Ansible in Fedora 39 has deprecated the use
> > "include:":
> > 
> > ERROR! [DEPRECATED]: ansible.builtin.include has been removed. Use include_tasks or import_tasks instead. This feature was removed from ansible-core in a release after 2023-05-16. Please update your playbooks.
> > make: *** [workflows/gitr/Makefile:45: gitr] Error 1
> > 
> > Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> 
> Thanks for doing all this, would we now do this:
> 
> diff --git a/ansible.cfg b/ansible.cfg
> index 78bc1ab2ef7d..4889be0a28ae 100644
> --- a/ansible.cfg
> +++ b/ansible.cfg
> @@ -1,4 +1,3 @@
>  [defaults]
>  display_skipped_hosts = no
>  retries = 2000
> -deprecation_warnings=False
> 
> Or do we still have a lot to go?

Well in this case, I was the one who added the deprecated "include:"
usage a few months ago! Let me apply your patch here and see what I
get.

-- 
Chuck Lever

  reply	other threads:[~2024-03-04 21:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-03 18:07 [PATCH RFC 1/6] devconfig: Install 'perf' on target hosts Chuck Lever
2024-03-03 18:07 ` [PATCH RFC 2/6] libvirt_user: Run Fedora-specific libvirt_user set up on Fedora systems Chuck Lever
2024-03-04 21:27   ` Luis Chamberlain
2024-03-04 21:46     ` Chuck Lever
2024-03-03 18:07 ` [PATCH RFC 3/6] kdevops: Fix raw "include:" directives Chuck Lever
2024-03-04 20:56   ` Luis Chamberlain
2024-03-04 21:40     ` Chuck Lever [this message]
2024-03-03 18:07 ` [PATCH RFC 4/6] fstests: Make /media/scratch larger Chuck Lever
2024-03-03 18:07 ` [PATCH RFC 5/6] gitr: Change the default mode of root directories under test Chuck Lever
2024-03-03 18:07 ` [PATCH RFC 6/6] devconfig: Assign a DNS domain name to target hosts Chuck Lever
2024-03-04 20:55   ` Luis Chamberlain
2024-03-04 21:38     ` Chuck Lever
2024-03-05 14:54       ` Chuck Lever III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZeY_sUchuI-63RaM@manet.1015granger.net \
    --to=chuck.lever@oracle.com \
    --cc=cel@kernel.org \
    --cc=kdevops@lists.linux.dev \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox