[PATCH RFC 1/6] devconfig: Install 'perf' on target hosts

[PATCH RFC 1/6] devconfig: Install 'perf' on target hosts

[Chuck Lever]

From: Chuck Lever <chuck.lever@oracle.com>

'perf' is a package kernel developers sometimes want to have on
systems where they need to troubleshoot.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 .../devconfig/tasks/install-deps/debian/main.yml   |    1 +
 .../devconfig/tasks/install-deps/redhat/main.yml   |    1 +
 .../devconfig/tasks/install-deps/suse/main.yml     |    1 +
 3 files changed, 3 insertions(+)

diff --git a/playbooks/roles/devconfig/tasks/install-deps/debian/main.yml b/playbooks/roles/devconfig/tasks/install-deps/debian/main.yml
index 6a55c264d047..62e68429a764 100644
--- a/playbooks/roles/devconfig/tasks/install-deps/debian/main.yml
+++ b/playbooks/roles/devconfig/tasks/install-deps/debian/main.yml
@@ -60,6 +60,7 @@
       - snmpd
       - snmp
       - trace-cmd
+      - perf
     state: present
     update_cache: yes
   tags: [ 'kdevops', 'deps' ]
diff --git a/playbooks/roles/devconfig/tasks/install-deps/redhat/main.yml b/playbooks/roles/devconfig/tasks/install-deps/redhat/main.yml
index 45650e177e10..d629b1becc1d 100644
--- a/playbooks/roles/devconfig/tasks/install-deps/redhat/main.yml
+++ b/playbooks/roles/devconfig/tasks/install-deps/redhat/main.yml
@@ -111,6 +111,7 @@
       - openssh-server
       - net-snmp
       - trace-cmd
+      - perf
 
 - name: Install btrfs-progs
   become: yes
diff --git a/playbooks/roles/devconfig/tasks/install-deps/suse/main.yml b/playbooks/roles/devconfig/tasks/install-deps/suse/main.yml
index 070b96875495..5c7233709463 100644
--- a/playbooks/roles/devconfig/tasks/install-deps/suse/main.yml
+++ b/playbooks/roles/devconfig/tasks/install-deps/suse/main.yml
@@ -359,6 +359,7 @@
       - bc
       - vim-data
       - trace-cmd
+      - perf
     state: present
   when:
     - not is_sle12sp3|bool

[PATCH RFC 2/6] libvirt_user: Run Fedora-specific libvirt_user set up on Fedora systems

[Chuck Lever]

From: Chuck Lever <chuck.lever@oracle.com>

To run kdevops as a regular users, typically you set the
LIBVIRT_CONFIGURE Kconfig option. This is supposed to enable your
user account to run libvirt without needing root permission.

On my Fedora 39 system, however, this was not working. Virtual
networking would not start automatically, and when I tried to bring
it up manually, it threw errors.

I discovered that there is a libvirt_user set-up role for Fedora
that was not getting run. The set-up role for Red Hat excludes an
important step.

Add logic to invoke the Fedora action instead of the Red Hat action
on Fedora systems. As an additional clean up, replace "import_tasks"
with "include_tasks" because that seems to be more reliable for
Ansible install-deps actions.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 .../roles/libvirt_user/tasks/enable-user/main.yml  |   26 +++++++++++++++-----
 1 file changed, 19 insertions(+), 7 deletions(-)

diff --git a/playbooks/roles/libvirt_user/tasks/enable-user/main.yml b/playbooks/roles/libvirt_user/tasks/enable-user/main.yml
index d2d9b1446051..04f8e31f71a9 100644
--- a/playbooks/roles/libvirt_user/tasks/enable-user/main.yml
+++ b/playbooks/roles/libvirt_user/tasks/enable-user/main.yml
@@ -1,8 +1,20 @@
 ---
-- name: Distribution specific setup
-  import_tasks: debian/main.yml
-  when: ansible_facts['os_family']|lower == 'debian'
-- import_tasks: suse/main.yml
-  when: ansible_facts['os_family']|lower == 'suse'
-- import_tasks: redhat/main.yml
-  when: ansible_facts['os_family']|lower == 'redhat'
+- name: Debian-specific set up
+  ansible.builtin.include_tasks: install-deps/debian/main.yml
+  when: ansible_os_family == 'Debian'
+
+- name: SuSE-specific set up
+  ansible.builtin.include_tasks: install-deps/suse/main.yml
+  when: ansible_os_family == 'Suse'
+
+- name: Red Hat-specific set up
+  ansible.builtin.include_tasks: install-deps/redhat/main.yml
+  when:
+    - ansible_os_family == 'RedHat'
+    - ansible_facts['distribution'] != "Fedora"
+
+- name: Fedora-specific set up
+  ansible.builtin.include_tasks: install-deps/fedora/main.yml
+  when:
+    - ansible_os_family == 'RedHat'
+    - ansible_facts['distribution'] == "Fedora"

Re: [PATCH RFC 2/6] libvirt_user: Run Fedora-specific libvirt_user set up on Fedora systems

[Luis Chamberlain]

On Sun, Mar 03, 2024 at 01:07:34PM -0500, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
> 
> To run kdevops as a regular users, typically you set the
> LIBVIRT_CONFIGURE Kconfig option. This is supposed to enable your
> user account to run libvirt without needing root permission.
> 
> On my Fedora 39 system, however, this was not working. Virtual
> networking would not start automatically, and when I tried to bring
> it up manually, it threw errors.

I seem to suffer similar issues on debian, but in particular, I get:

error: Failed to start domain 'g2'
error: Cannot get interface MTU on 'virbr0': No such device

Did you get something similar?

  Luis

Re: [PATCH RFC 2/6] libvirt_user: Run Fedora-specific libvirt_user set up on Fedora systems

[Chuck Lever]

On Mon, Mar 04, 2024 at 01:27:00PM -0800, Luis Chamberlain wrote:
> On Sun, Mar 03, 2024 at 01:07:34PM -0500, Chuck Lever wrote:
> > From: Chuck Lever <chuck.lever@oracle.com>
> > 
> > To run kdevops as a regular users, typically you set the
> > LIBVIRT_CONFIGURE Kconfig option. This is supposed to enable your
> > user account to run libvirt without needing root permission.
> > 
> > On my Fedora 39 system, however, this was not working. Virtual
> > networking would not start automatically, and when I tried to bring
> > it up manually, it threw errors.
> 
> I seem to suffer similar issues on debian, but in particular, I get:
> 
> error: Failed to start domain 'g2'
> error: Cannot get interface MTU on 'virbr0': No such device
> 
> Did you get something similar?

Similar, though not exactly the same as that.

-- 
Chuck Lever

[PATCH RFC 3/6] kdevops: Fix raw "include:" directives

[Chuck Lever]

From: Chuck Lever <chuck.lever@oracle.com>

The version of Ansible in Fedora 39 has deprecated the use
"include:":

ERROR! [DEPRECATED]: ansible.builtin.include has been removed. Use include_tasks or import_tasks instead. This feature was removed from ansible-core in a release after 2023-05-16. Please update your playbooks.
make: *** [workflows/gitr/Makefile:45: gitr] Error 1

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 playbooks/roles/create_nfs_mount/tasks/main.yml |    3 ++-
 playbooks/roles/gitr/tasks/main.yml             |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/playbooks/roles/create_nfs_mount/tasks/main.yml b/playbooks/roles/create_nfs_mount/tasks/main.yml
index 1ce7f4f6f38b..66bb61f46c57 100644
--- a/playbooks/roles/create_nfs_mount/tasks/main.yml
+++ b/playbooks/roles/create_nfs_mount/tasks/main.yml
@@ -30,7 +30,8 @@
 #  args:
 #    executable: /bin/bash
 
-- include: tasks/install-deps/main.yml
+- name: Install dependencies
+  ansible.builtin.include_tasks: install-deps/main.yml
 
 - name: Ensure {{ nfs_mounted_on }} is mounted
   become: yes
diff --git a/playbooks/roles/gitr/tasks/main.yml b/playbooks/roles/gitr/tasks/main.yml
index a28e4fb59f51..cd9a78a409a9 100644
--- a/playbooks/roles/gitr/tasks/main.yml
+++ b/playbooks/roles/gitr/tasks/main.yml
@@ -89,7 +89,8 @@
   when:
     - gitr_fstype == "nfs"
 
-- include: tasks/install-deps/main.yml
+- name: Install dependencies
+  ansible.builtin.include_tasks: tasks/install-deps/main.yml
 
 - name: Remove old git dir
   tags: [ 'gitr' ]

Re: [PATCH RFC 3/6] kdevops: Fix raw "include:" directives

[Luis Chamberlain]

On Sun, Mar 03, 2024 at 01:07:40PM -0500, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
> 
> The version of Ansible in Fedora 39 has deprecated the use
> "include:":
> 
> ERROR! [DEPRECATED]: ansible.builtin.include has been removed. Use include_tasks or import_tasks instead. This feature was removed from ansible-core in a release after 2023-05-16. Please update your playbooks.
> make: *** [workflows/gitr/Makefile:45: gitr] Error 1
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

Thanks for doing all this, would we now do this:

diff --git a/ansible.cfg b/ansible.cfg
index 78bc1ab2ef7d..4889be0a28ae 100644
--- a/ansible.cfg
+++ b/ansible.cfg
@@ -1,4 +1,3 @@
 [defaults]
 display_skipped_hosts = no
 retries = 2000
-deprecation_warnings=False

Or do we still have a lot to go?

  Luis

Re: [PATCH RFC 3/6] kdevops: Fix raw "include:" directives

[Chuck Lever]

On Mon, Mar 04, 2024 at 12:56:32PM -0800, Luis Chamberlain wrote:
> On Sun, Mar 03, 2024 at 01:07:40PM -0500, Chuck Lever wrote:
> > From: Chuck Lever <chuck.lever@oracle.com>
> > 
> > The version of Ansible in Fedora 39 has deprecated the use
> > "include:":
> > 
> > ERROR! [DEPRECATED]: ansible.builtin.include has been removed. Use include_tasks or import_tasks instead. This feature was removed from ansible-core in a release after 2023-05-16. Please update your playbooks.
> > make: *** [workflows/gitr/Makefile:45: gitr] Error 1
> > 
> > Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> 
> Thanks for doing all this, would we now do this:
> 
> diff --git a/ansible.cfg b/ansible.cfg
> index 78bc1ab2ef7d..4889be0a28ae 100644
> --- a/ansible.cfg
> +++ b/ansible.cfg
> @@ -1,4 +1,3 @@
>  [defaults]
>  display_skipped_hosts = no
>  retries = 2000
> -deprecation_warnings=False
> 
> Or do we still have a lot to go?

Well in this case, I was the one who added the deprecated "include:"
usage a few months ago! Let me apply your patch here and see what I
get.

-- 
Chuck Lever

[PATCH RFC 4/6] fstests: Make /media/scratch larger

[Chuck Lever]

From: Chuck Lever <chuck.lever@oracle.com>

When testing older kernels with NFS, I notice that when the scratch
device fills up, generic/496 livelocks. Increase it's capacity to
avoid waiting forever.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 playbooks/roles/fstests/tasks/main.yml |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/playbooks/roles/fstests/tasks/main.yml b/playbooks/roles/fstests/tasks/main.yml
index ebcfbad7c710..3f210a53b022 100644
--- a/playbooks/roles/fstests/tasks/main.yml
+++ b/playbooks/roles/fstests/tasks/main.yml
@@ -648,7 +648,7 @@
     export_volname: "{{ volname_prefix }}-s"
     export_options: "{{ nfsd_export_options }}"
     export_fstype: "{{ nfsd_export_fstype }}"
-    export_size: 20g
+    export_size: 30g
   when:
     - fstests_fstyp == "nfs"
     - fstests_nfs_use_kdevops_nfsd|bool

[PATCH RFC 5/6] gitr: Change the default mode of root directories under test

[Chuck Lever]

From: Chuck Lever <chuck.lever@oracle.com>

The default value of data_user is "vagrant". We should replace
that some day, but that looks a bit hairy to tackle.

When testing in a guestfs environment, the "vagrant" user ID is
not defined on target hosts, resulting in immediate test failures
(at least for the gitr workflow).

Address this by creating test file systems so they are owned by root,
and change the default mode of the root directory to 1777. This
enables any user to create files and directories on the test
file system.

Add a playbook parameter so that playbook consumers can set a
specific mode if they require it.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 playbooks/roles/create_partition/README.md         |    1 +
 playbooks/roles/create_partition/defaults/main.yml |    1 +
 playbooks/roles/create_partition/tasks/main.yml    |    1 +
 playbooks/roles/create_tmpfs/README.md             |    1 +
 playbooks/roles/create_tmpfs/defaults/main.yml     |    1 +
 playbooks/roles/create_tmpfs/tasks/main.yml        |    1 +
 playbooks/roles/gitr/tasks/main.yml                |    6 ------
 playbooks/roles/nfsd_add_export/README.md          |    1 +
 playbooks/roles/nfsd_add_export/defaults/main.yml  |    1 +
 playbooks/roles/nfsd_add_export/tasks/main.yml     |    1 +
 10 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/playbooks/roles/create_partition/README.md b/playbooks/roles/create_partition/README.md
index 0971f09834fd..32409030dd4d 100644
--- a/playbooks/roles/create_partition/README.md
+++ b/playbooks/roles/create_partition/README.md
@@ -31,6 +31,7 @@ Role Variables
   * disk_setup_path: the path to mount the filesystem
   * disk_setup_user: the user to assign the directory path to
   * disk_setup_group: the group to assign the directory path to
+  * disk_setup_mode: the mode of the root directory of the new filesystem
 
 Dependencies
 ------------
diff --git a/playbooks/roles/create_partition/defaults/main.yml b/playbooks/roles/create_partition/defaults/main.yml
index 2336425c2b1a..35c8c24e1dcb 100644
--- a/playbooks/roles/create_partition/defaults/main.yml
+++ b/playbooks/roles/create_partition/defaults/main.yml
@@ -10,3 +10,4 @@ disk_setup_fs_opts: "-L {{ disk_setup_label }}"
 disk_setup_path: "/data"
 disk_setup_user: "root"
 disk_setup_group: "root"
+disk_setup_mode: "u=rwx,g=rwx,o=rwxt"
diff --git a/playbooks/roles/create_partition/tasks/main.yml b/playbooks/roles/create_partition/tasks/main.yml
index 0a95a4c4c159..a3d36a599e9f 100644
--- a/playbooks/roles/create_partition/tasks/main.yml
+++ b/playbooks/roles/create_partition/tasks/main.yml
@@ -159,4 +159,5 @@
     path: "{{ disk_setup_path }}"
     owner: "{{ disk_setup_user }}"
     group: "{{ disk_setup_group }}"
+    mode: "{{ disk_setup_mode }}"
   tags: [ 'partition' ]
diff --git a/playbooks/roles/create_tmpfs/README.md b/playbooks/roles/create_tmpfs/README.md
index fe8736229788..dfc9dda39fa8 100644
--- a/playbooks/roles/create_tmpfs/README.md
+++ b/playbooks/roles/create_tmpfs/README.md
@@ -18,6 +18,7 @@ Role Variables
   * tmpfs_mounted_on: the directory on which to mount the new file system
   * tmpfs_user: the user to assign the directory path to
   * tmpfs_group: the group to assign the directory path to
+  * tmpfs_mode: the mode of the root directory of the new file system
 
 Dependencies
 ------------
diff --git a/playbooks/roles/create_tmpfs/defaults/main.yml b/playbooks/roles/create_tmpfs/defaults/main.yml
index cb04cf4ac154..f10731ec7b51 100644
--- a/playbooks/roles/create_tmpfs/defaults/main.yml
+++ b/playbooks/roles/create_tmpfs/defaults/main.yml
@@ -4,3 +4,4 @@ tmpfs_mount_options: "defaults"
 tmpfs_mounted_on: "/data"
 tmpfs_user: "root"
 tmpfs_group: "root"
+tmpfs_mode: "u=rwx,g=rwx,o=rwxt"
diff --git a/playbooks/roles/create_tmpfs/tasks/main.yml b/playbooks/roles/create_tmpfs/tasks/main.yml
index cf96d0b1304d..3008e42603c5 100644
--- a/playbooks/roles/create_tmpfs/tasks/main.yml
+++ b/playbooks/roles/create_tmpfs/tasks/main.yml
@@ -52,3 +52,4 @@
     path: "{{ tmpfs_mounted_on }}"
     owner: "{{ tmpfs_user }}"
     group: "{{ tmpfs_group }}"
+    mode: "{{ tmpfs_mode }}"
diff --git a/playbooks/roles/gitr/tasks/main.yml b/playbooks/roles/gitr/tasks/main.yml
index cd9a78a409a9..35c7ce1923d9 100644
--- a/playbooks/roles/gitr/tasks/main.yml
+++ b/playbooks/roles/gitr/tasks/main.yml
@@ -45,8 +45,6 @@
     disk_setup_fs_opts: "-L {{ gitr_label }}"
     disk_setup_path: "{{ gitr_mnt }}"
     disk_setup_mount_opts: "{{ gitr_mount_opts }}"
-    disk_setup_user: "{{ data_user }}"
-    disk_setup_group: "{{ data_group }}"
   when:
     - not gitr_uses_no_devices|bool
 
@@ -57,8 +55,6 @@
   vars:
     tmpfs_mnt_options: "{{ gitr_mount_opts }}"
     tmpfs_mounted_on: "{{ gitr_mnt }}"
-    tmpfs_user: "{{ data_user }}"
-    tmpfs_group: "{{ data_group }}"
   when:
     - gitr_fstype == "tmpfs"
 
@@ -71,8 +67,6 @@
     export_options: "{{ nfsd_export_options }}"
     export_fstype: "{{ nfsd_export_fstype }}"
     export_size: 5g
-    export_user: "{{ data_user }}"
-    export_group: "{{ data_group }}"
   when:
     - gitr_nfs_use_kdevops_nfsd|bool
     - gitr_fstype == "nfs"
diff --git a/playbooks/roles/nfsd_add_export/README.md b/playbooks/roles/nfsd_add_export/README.md
index 8e9e21e02e82..d89308359a0c 100644
--- a/playbooks/roles/nfsd_add_export/README.md
+++ b/playbooks/roles/nfsd_add_export/README.md
@@ -24,6 +24,7 @@ Role Variables
   * export_size: the maximum size of the new export
   * export_user: the owner of the new export
   * export_group: the owner group of the new export
+  * export_mode: the mode bits for the new export's root directory
 
 Dependencies
 ------------
diff --git a/playbooks/roles/nfsd_add_export/defaults/main.yml b/playbooks/roles/nfsd_add_export/defaults/main.yml
index 442a000e3739..d4cea833f36d 100644
--- a/playbooks/roles/nfsd_add_export/defaults/main.yml
+++ b/playbooks/roles/nfsd_add_export/defaults/main.yml
@@ -2,3 +2,4 @@
 ---
 export_user: "root"
 export_group: "root"
+export_mode: "u=rwx,g=rwx,o=rwxt"
diff --git a/playbooks/roles/nfsd_add_export/tasks/main.yml b/playbooks/roles/nfsd_add_export/tasks/main.yml
index ec456dda622a..0743586723b2 100644
--- a/playbooks/roles/nfsd_add_export/tasks/main.yml
+++ b/playbooks/roles/nfsd_add_export/tasks/main.yml
@@ -60,6 +60,7 @@
     path: "{{ nfsd_export_path }}/{{ export_volname }}"
     owner: "{{ export_user }}"
     group: "{{ export_group }}"
+    mode: "{{ export_mode }}"
 
 - name: Test whether SELinux is enabled
   command: /usr/sbin/selinuxenabled

[PATCH RFC 6/6] devconfig: Assign a DNS domain name to target hosts

[Chuck Lever]

From: Chuck Lever <chuck.lever@oracle.com>

NFSv4 ID mapping grabs the default NFSv4 ID mapping domain, by
default, from the host's DNS domain name.

Note that this does not alter the target host's hostname entry in
/etc/hosts, which is what some distributions expect.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 playbooks/roles/devconfig/defaults/main.yml  |    2 ++
 playbooks/roles/devconfig/templates/hostname |    2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/playbooks/roles/devconfig/defaults/main.yml b/playbooks/roles/devconfig/defaults/main.yml
index 92552dfd87a7..c5b309c8574f 100644
--- a/playbooks/roles/devconfig/defaults/main.yml
+++ b/playbooks/roles/devconfig/defaults/main.yml
@@ -29,6 +29,8 @@ devconfig_repos_addon_list:
 suse_register_system: False
 suse_registration_code: 0
 
+devconfig_dns_domain: "kdevops.org"
+
 devconfig_enable_console: False
 devconfig_enable_kotd: False
 devconfig_has_kotd_repo: False
diff --git a/playbooks/roles/devconfig/templates/hostname b/playbooks/roles/devconfig/templates/hostname
index c999126cc00e..c9496abe6cb7 100644
--- a/playbooks/roles/devconfig/templates/hostname
+++ b/playbooks/roles/devconfig/templates/hostname
@@ -1 +1 @@
-{{ ansible_host }}
+{{ ansible_host }}.{{ devconfig_dns_domain }}

Re: [PATCH RFC 6/6] devconfig: Assign a DNS domain name to target hosts

[Luis Chamberlain]

On Sun, Mar 03, 2024 at 01:07:59PM -0500, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
> 
> NFSv4 ID mapping grabs the default NFSv4 ID mapping domain, by
> default, from the host's DNS domain name.
> 
> Note that this does not alter the target host's hostname entry in
> /etc/hosts, which is what some distributions expect.
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>  playbooks/roles/devconfig/defaults/main.yml  |    2 ++
>  playbooks/roles/devconfig/templates/hostname |    2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/playbooks/roles/devconfig/defaults/main.yml b/playbooks/roles/devconfig/defaults/main.yml
> index 92552dfd87a7..c5b309c8574f 100644
> --- a/playbooks/roles/devconfig/defaults/main.yml
> +++ b/playbooks/roles/devconfig/defaults/main.yml
> @@ -29,6 +29,8 @@ devconfig_repos_addon_list:
>  suse_register_system: False
>  suse_registration_code: 0
>  
> +devconfig_dns_domain: "kdevops.org"

FWIW I just purchased this in case we need to do something with it later.
But typically wouldn't a "local" be a better default for domain name?

  Luis

Re: [PATCH RFC 6/6] devconfig: Assign a DNS domain name to target hosts

[Chuck Lever]

On Mon, Mar 04, 2024 at 12:55:08PM -0800, Luis Chamberlain wrote:
> On Sun, Mar 03, 2024 at 01:07:59PM -0500, Chuck Lever wrote:
> > From: Chuck Lever <chuck.lever@oracle.com>
> > 
> > NFSv4 ID mapping grabs the default NFSv4 ID mapping domain, by
> > default, from the host's DNS domain name.
> > 
> > Note that this does not alter the target host's hostname entry in
> > /etc/hosts, which is what some distributions expect.
> > 
> > Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> > ---
> >  playbooks/roles/devconfig/defaults/main.yml  |    2 ++
> >  playbooks/roles/devconfig/templates/hostname |    2 +-
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/playbooks/roles/devconfig/defaults/main.yml b/playbooks/roles/devconfig/defaults/main.yml
> > index 92552dfd87a7..c5b309c8574f 100644
> > --- a/playbooks/roles/devconfig/defaults/main.yml
> > +++ b/playbooks/roles/devconfig/defaults/main.yml
> > @@ -29,6 +29,8 @@ devconfig_repos_addon_list:
> >  suse_register_system: False
> >  suse_registration_code: 0
> >  
> > +devconfig_dns_domain: "kdevops.org"
> 
> FWIW I just purchased this in case we need to do something with it later.
> But typically wouldn't a "local" be a better default for domain name?

Actually I went looking for something like that, but didn't find it.

https://en.wikipedia.org/wiki/.local

I can give "kdevops.local" a try.


-- 
Chuck Lever

Re: [PATCH RFC 6/6] devconfig: Assign a DNS domain name to target hosts

[Chuck Lever III]

> On Mar 4, 2024, at 4:38 PM, Chuck Lever <chuck.lever@oracle.com> wrote:
> 
> On Mon, Mar 04, 2024 at 12:55:08PM -0800, Luis Chamberlain wrote:
>> On Sun, Mar 03, 2024 at 01:07:59PM -0500, Chuck Lever wrote:
>>> From: Chuck Lever <chuck.lever@oracle.com>
>>> 
>>> NFSv4 ID mapping grabs the default NFSv4 ID mapping domain, by
>>> default, from the host's DNS domain name.
>>> 
>>> Note that this does not alter the target host's hostname entry in
>>> /etc/hosts, which is what some distributions expect.
>>> 
>>> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
>>> ---
>>> playbooks/roles/devconfig/defaults/main.yml  |    2 ++
>>> playbooks/roles/devconfig/templates/hostname |    2 +-
>>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>> 
>>> diff --git a/playbooks/roles/devconfig/defaults/main.yml b/playbooks/roles/devconfig/defaults/main.yml
>>> index 92552dfd87a7..c5b309c8574f 100644
>>> --- a/playbooks/roles/devconfig/defaults/main.yml
>>> +++ b/playbooks/roles/devconfig/defaults/main.yml
>>> @@ -29,6 +29,8 @@ devconfig_repos_addon_list:
>>> suse_register_system: False
>>> suse_registration_code: 0
>>> 
>>> +devconfig_dns_domain: "kdevops.org"
>> 
>> FWIW I just purchased this in case we need to do something with it later.
>> But typically wouldn't a "local" be a better default for domain name?
> 
> Actually I went looking for something like that, but didn't find it.
> 
> https://en.wikipedia.org/wiki/.local
> 
> I can give "kdevops.local" a try.

This seems fine:

[vagrant@cel-nfsd ~]$ hostnamectl
     Static hostname: cel-nfsd.kdevops.local
           Icon name: computer-vm
             Chassis: vm 🖴
          Machine ID: 16aa3bfaabf04eeca8f7987ff01fbaf6
             Boot ID: 3d9cff0911b84651bc79edd2c5be5b71
      Virtualization: kvm
    Operating System: Fedora Linux 38 (Cloud Edition)           CPE OS Name: cpe:/o:fedoraproject:fedora:38
      OS Support End: Tue 2024-05-14
OS Support Remaining: 2month 1w 1d
              Kernel: Linux 6.8.0-rc7-next-20240304
        Architecture: x86-64
     Hardware Vendor: QEMU
      Hardware Model: Standard PC _Q35 + ICH9, 2009_
    Firmware Version: 1.16.2-1.fc38
       Firmware Date: Tue 2014-04-01
[vagrant@cel-nfsd ~]$ sudo nfsidmap -d
kdevops.local
[vagrant@cel-nfsd ~]$

Only question is if .local will be a problem for Kerberos.
I can't think of a reason it would be.


--
Chuck Lever