Re: [PATCH v2 4/4] libvirt: Support aarch64 guests

[Luis Chamberlain <mcgrof@kernel.org>]

On Wed, Mar 06, 2024 at 10:03:36AM -0500, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
> 
> I've added aarch64 support only under guestfs, since I figure
> Vagrant support in kdevops is not long for this world.
> 
> - Add a .j2.xml file for building aarch64 nodes
> - Remove some hard dependencies on the q35 guest definition
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>  kconfigs/Kconfig.libvirt                           |    8 +
>  .../roles/gen_nodes/templates/guestfs_virt.j2.xml  |  215 ++++++++++++++++++++
>  scripts/gen-nodes.Makefile                         |    5 
>  workflows/linux/Kconfig                            |    3 
>  4 files changed, 228 insertions(+), 3 deletions(-)
>  create mode 100644 playbooks/roles/gen_nodes/templates/guestfs_virt.j2.xml
> 
> diff --git a/kconfigs/Kconfig.libvirt b/kconfigs/Kconfig.libvirt
> index fa39120450fd..6d51a1c26604 100644
> --- a/kconfigs/Kconfig.libvirt
> +++ b/kconfigs/Kconfig.libvirt
> @@ -466,7 +466,8 @@ endif # HAVE_LIBVIRT_PCIE_PASSTHROUGH
>  
>  choice
>  	prompt "Machine type to use"
> -	default LIBVIRT_MACHINE_TYPE_Q35
> +	default LIBVIRT_MACHINE_TYPE_Q35 if TARGET_ARCH_X86_64
> +	default LIBVIRT_MACHINE_TYPE_VIRT if TARGET_ARCH_ARM64

Picking q35 when one selected TARGET_ARCH_ARM64 would likely fail at
bringup, likewise picking LIBVIRT_MACHINE_TYPE_VIRT when one selected
TARGET_ARCH_X86_64 would fail. So how about just hiding that complexity
and only presenting q35 as an option if TARGET_ARCH_X86_64 is enabled?

So LIBVIRT_MACHINE_TYPE_Q35 should then depend on TARGET_ARCH_X86_64 and
   LIBVIRT_MACHINE_TYPE_VIRT depend on TARGET_ARCH_ARM64 ?

The above can be kept as is, we'd just make q35 not appear as an option
if one selected TARGET_ARCH_ARM64 and if one selected TARGET_ARCH_ARM64
one would not see q35 in the drop down menu as well.

Other than that:

Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>

  Luis