From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A12E918032 for ; Wed, 6 Mar 2024 21:05:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709759136; cv=none; b=rhjMK9gKuLxolh+6EBJSynOSugCODAJR8Oj9TEPDEu2NeMqZCPl73iV27KZYVUi7M/Sr8MVVTJtfKt8mvvNgVrBD22upq5JSLjtKdGsA8XbUU+Gan9X2lToVrEcfHg0wwmVdT99EdL5t0ZaxbVyvYVtKw7unE9/5/n1UR0Spv4A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709759136; c=relaxed/simple; bh=rPOOCSkN3JoGZSCz0kSp9tl9/noqMhb3aX5RUinNEq4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VG/80SQwmLH2MAcgZuRj9w65+31tQ7ROCk+L3KXc2IeIq+7Vv5vvbEoz/0TROllQfmlT8GZ+z/5y9P7f2/QHNIWCO5fTEsU+Sx8/eTfeAtOiVGVTre16RvjthXhHR3W6P8XvkHHZQL0X3GO647aagMgKlaaQh18AcGFAuSmHF+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Hm4HoiJe; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Hm4HoiJe" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YS0t8ZGCHNlTxMWBEUAZiXhiMQLxC2UbyibBOxOyBfg=; b=Hm4HoiJeIp7Y+BTE9XnZiQgK4g OqdwQRVPTL1C29W7CBTOJSZFNBNRSvtIPJf88Bn4jcsGGH0pXGgHWjMglMTN+eDGcY/+f8NOUNBw3 Zl7RC+xtvpL0OwWZXUDjxl5cReTcC2oFYwSMgNE9Ml1pNxQHR1SQvqMjtr3t83UgLx9F3yOAZmAZc lSiaAuzDlCBfXrwXxtisr3dByzt6/Wxp3Od7CxiSfGfYk6p9usw3bPBAWKWtW1bGmHm+M5ILbdjc8 YD/Q+qyaz91gnZPw4GDhoaeo9H/PF6LHasXkvVJhZIhqk+DVlXQugMTV9cheWVfYixrfck+FXDwxs YpJwCOSw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhySE-00000001tIN-0jgu; Wed, 06 Mar 2024 21:05:34 +0000 Date: Wed, 6 Mar 2024 13:05:34 -0800 From: Luis Chamberlain To: Chuck Lever Cc: kdevops@lists.linux.dev Subject: Re: [PATCH v2 4/4] libvirt: Support aarch64 guests Message-ID: References: <170973650456.2228654.13442531099247236840.stgit@renoir.1015granger.net> <170973741651.2228654.5921199926034055133.stgit@renoir.1015granger.net> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <170973741651.2228654.5921199926034055133.stgit@renoir.1015granger.net> Sender: Luis Chamberlain On Wed, Mar 06, 2024 at 10:03:36AM -0500, Chuck Lever wrote: > From: Chuck Lever > > I've added aarch64 support only under guestfs, since I figure > Vagrant support in kdevops is not long for this world. > > - Add a .j2.xml file for building aarch64 nodes > - Remove some hard dependencies on the q35 guest definition > > Signed-off-by: Chuck Lever > --- > kconfigs/Kconfig.libvirt | 8 + > .../roles/gen_nodes/templates/guestfs_virt.j2.xml | 215 ++++++++++++++++++++ > scripts/gen-nodes.Makefile | 5 > workflows/linux/Kconfig | 3 > 4 files changed, 228 insertions(+), 3 deletions(-) > create mode 100644 playbooks/roles/gen_nodes/templates/guestfs_virt.j2.xml > > diff --git a/kconfigs/Kconfig.libvirt b/kconfigs/Kconfig.libvirt > index fa39120450fd..6d51a1c26604 100644 > --- a/kconfigs/Kconfig.libvirt > +++ b/kconfigs/Kconfig.libvirt > @@ -466,7 +466,8 @@ endif # HAVE_LIBVIRT_PCIE_PASSTHROUGH > > choice > prompt "Machine type to use" > - default LIBVIRT_MACHINE_TYPE_Q35 > + default LIBVIRT_MACHINE_TYPE_Q35 if TARGET_ARCH_X86_64 > + default LIBVIRT_MACHINE_TYPE_VIRT if TARGET_ARCH_ARM64 Picking q35 when one selected TARGET_ARCH_ARM64 would likely fail at bringup, likewise picking LIBVIRT_MACHINE_TYPE_VIRT when one selected TARGET_ARCH_X86_64 would fail. So how about just hiding that complexity and only presenting q35 as an option if TARGET_ARCH_X86_64 is enabled? So LIBVIRT_MACHINE_TYPE_Q35 should then depend on TARGET_ARCH_X86_64 and LIBVIRT_MACHINE_TYPE_VIRT depend on TARGET_ARCH_ARM64 ? The above can be kept as is, we'd just make q35 not appear as an option if one selected TARGET_ARCH_ARM64 and if one selected TARGET_ARCH_ARM64 one would not see q35 in the drop down menu as well. Other than that: Reviewed-by: Luis Chamberlain Luis