From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9579484E0B for ; Tue, 16 Apr 2024 21:56:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713304596; cv=none; b=FFho0jpRE+VyTbsRtCLR1ytl48hfLEzkTeQoa4DwtQYA4c1jWkIDnDUIvEGdyq6xutEu7c8sATHc0mmCZbioniqZQtonDdziOeW4IFR2KN0GphdHgduch/yBE9eItESmY5j8sAroEBFloA62DE2qBsFI6LDcfTDjcOwQb12eJlQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713304596; c=relaxed/simple; bh=fFw0ttJg8mI+ejWZ6LJ/saQClPdXJgSdsLtimY9QKEk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=rYBgNKKoiYQ7GWdIUs2lZHznf9obBnHVSwnmHbKFzbiqhKEZ+t5CClO3aSQVuYx6HOZ5ym0DxAJSFhF9xXbPtyhfdKTpq6p5d/ij67Shws0xUKA2T+StvhDcb+fmA4CObrEW6cm3Y2Vc7l2KKxFXlee+BRPsozkpwwfYRxdz0TM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PC8dkZM7; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PC8dkZM7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713304593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O1ar+5EoKX8U199zyVSHlVIu0Ukl4XG+q3ZYF8fUxF8=; b=PC8dkZM77N4QCOs1OeHGLzmeC3KX2b7PnixtbQF7mALYYkwhtoXW8gtiegu8xL8Rczm+FL Xz+ZQnfZXKo9uTE7/g9+SOW/fxfcQxeR1dUFDiaEDn4C5UVV7+goYqxc2o+028JqDxl6z5 f7W2RfZVnty/L9CtewWkvxWAHf/IQq0= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-2JGovYDQO4-KN5BIcnoUDQ-1; Tue, 16 Apr 2024 17:56:29 -0400 X-MC-Unique: 2JGovYDQO4-KN5BIcnoUDQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 04CC91C03152; Tue, 16 Apr 2024 21:56:29 +0000 (UTC) Received: from aion.redhat.com (unknown [10.22.8.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC9AC2031269; Tue, 16 Apr 2024 21:56:28 +0000 (UTC) Received: by aion.redhat.com (Postfix, from userid 1000) id 9A08714890B; Tue, 16 Apr 2024 17:56:28 -0400 (EDT) Date: Tue, 16 Apr 2024 17:56:28 -0400 From: Scott Mayhew To: Luis Chamberlain Cc: kdevops@lists.linux.dev Subject: Re: [PATCH 5/6] fstests: add an option for testing on CIFS Message-ID: References: <20240412205000.2329837-1-smayhew@redhat.com> <20240412205000.2329837-6-smayhew@redhat.com> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, 12 Apr 2024, Luis Chamberlain wrote: > On Fri, Apr 12, 2024 at 04:49:59PM -0400, Scott Mayhew wrote: > > Signed-off-by: Scott Mayhew > > --- > > diff --git a/workflows/fstests/Kconfig b/workflows/fstests/Kconfig > > index c797b24..e6664bf 100644 > > --- a/workflows/fstests/Kconfig > > +++ b/workflows/fstests/Kconfig > > diff --git a/workflows/fstests/cifs/Kconfig b/workflows/fstests/cifs/Kconfig > > new file mode 100644 > > index 0000000..b88d1fe > > --- /dev/null > > +++ b/workflows/fstests/cifs/Kconfig > > @@ -0,0 +1,75 @@ > > +config FSTESTS_SMB_SERVER_HOST > > + string "Test Server hostname" > > + default "" > > + depends on !FSTESTS_USE_KDEVOPS_SMBD > > + help > > + The SMB server hostname or address to test against. Note that > > + the clients will expect that an appropriate hierarchy is already > > + created for them to mount and use. > > + FIXME: document how to make that. > > + > > +# Distributions actively maintaining btrfs support should select this and then > > btrfs / CIFS > > > +if FSTESTS_CIFS_MANUAL_COVERAGE > > + > > +config FSTESTS_CIFS_SECTION_SMB3 > > + bool "Enable testing section: smb3" > > + default y > > + help > > + Enabling this will test SMB3. > > + > > +config FSTESTS_CIFS_SECTION_SMB3_SEAL > > + bool "Enable testing section: smb3_seal" > > + default n > > + help > > + Enabling this will test SMB3 with encryption. > > + > > +config FSTESTS_CIFS_SECTION_SMB3_SIGN > > + bool "Enable testing section: smb3_sign" > > + default n > > + help > > + Enabling this will test SMB3 with signing. > > + > > +endif # FSTESTS_CIFS_MANUAL_COVERAGE > > + > > +if !FSTESTS_CIFS_MANUAL_COVERAGE > > + > > +config FSTESTS_CIFS_SECTION_SMB3 > > + bool > > + default y > > I think you're just missing here the defaults for: > > * SMB3_SEAL > * SMB3_SIGN > > Otherwise looks good. Thanks, I've fixed both items. I'll wait for Chuck to push his nfstest stuff and rebase on top of that to make sure there are no conflicts. -Scott > > Reviewed-by: Luis Chamberlain > > Luis >