From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0C7A38FA6 for ; Tue, 16 Apr 2024 21:54:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713304485; cv=none; b=HrJfsDpxY0QR+4n+A3g0S7BHFE8I70dDv9OlxoPyhKSjaRx3wF+Cl0szGbLuLf3HNZsBm4Vgxmw2FJUfL6mZjXi2j1Iq46G/KcN3MgcI+uMCBznlh9TWe9O/oLwzsar5ewmfKXMjvPjSGmSWGWjCaemB+6N/kDdrPWokIIGXWA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713304485; c=relaxed/simple; bh=1biWy2K0kYIH4DO1VrLVaYGm9Fe1YnIYj/9iNWeqJyM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=JRdELS9N4x9NJ9z4QDdNN6uXXXSmISRPwTaBACSVaJ/uCRmaENdl1gl0PPkoExNLCSLhCrURAbwrSK4/vJZq7bPg6iDw/eh2G4adfdBszEWphfhWf4s6ybd7tbCz2hDVmFfU8usSG+KxV5hOxA9ZPYIkGtski48GqsAIj8zMrCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NGDhQMbg; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NGDhQMbg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713304482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DSUoP08nWbcg4hYC8pUB7H/42A3rwsGg7Y3HJZstkow=; b=NGDhQMbgKBhet11087L1k4l/pKwt6Awdwr1Rnv86q4KohIOdXZhCgLNkFJVAcOzceZ95iM irDFJOw98dcCN+Sq0bHl9gM9zayv+5R4uY+/naSWmXqPOxslRds5f1T/flRybb0jQ47hT9 EfefDOX0GvZPw071Y0ZsmoEe4L3Zxi4= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-290-lDh2EN54N7uRSBwTqdCSAQ-1; Tue, 16 Apr 2024 17:54:39 -0400 X-MC-Unique: lDh2EN54N7uRSBwTqdCSAQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 26AC41C03152; Tue, 16 Apr 2024 21:54:39 +0000 (UTC) Received: from aion.redhat.com (unknown [10.22.8.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0D6271121306; Tue, 16 Apr 2024 21:54:39 +0000 (UTC) Received: by aion.redhat.com (Postfix, from userid 1000) id BB327148909; Tue, 16 Apr 2024 17:54:38 -0400 (EDT) Date: Tue, 16 Apr 2024 17:54:38 -0400 From: Scott Mayhew To: Chuck Lever III Cc: "kdevops@lists.linux.dev" Subject: Re: [PATCH 0/6] Add an option for running fstests on CIFS Message-ID: References: <20240412205000.2329837-1-smayhew@redhat.com> <8F09548D-3B9F-47D2-883D-0071F0698821@oracle.com> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <8F09548D-3B9F-47D2-883D-0071F0698821@oracle.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, 12 Apr 2024, Chuck Lever III wrote: >=20 >=20 > > On Apr 12, 2024, at 4:49=E2=80=AFPM, Scott Mayhew = wrote: > >=20 > > These patches add the ability to run fstests on CIFS. The playbooks ar= e > > very similar to their NFS counterparts. The smbd playbook sets up a > > Samba server, but could be expanded to set up ksmbd in the future. The > > following options are available: plain SMB3, SMB3 with signing, and > > SMB3 with encryption. >=20 > You could also add SMB direct using siw, but maybe Samba doesn't > support that. I looked at it today, and it doesn't look like Samba supports SMB Direct yet. -Scott >=20 >=20 > > The expunge files are based on the tests that were consistently failing > > on 6.8.4-200.fc39.x86_64, plus some tests that just take way too long > > (generic/476, generic/650). > >=20 > > -Scott > >=20 > > Scott Mayhew (6): > > oscheck.sh: add some special cases for cifs > > gendisks.sh: add special case for cifs > > bringup: add a playbook to bring up an SMB server > > playbooks: add a playbook to create smb shares > > fstests: add an option for testing on CIFS > > fstests: add expunges for cifs > >=20 > > Makefile | 1 + > > kconfigs/Kconfig.bringup.goals | 1 + > > kconfigs/Kconfig.smbd | 72 ++++++++++++ > > playbooks/roles/fstests/defaults/main.yml | 6 + > > .../tasks/install-deps/debian/main.yml | 1 + > > .../tasks/install-deps/redhat/main.yml | 1 + > > .../fstests/tasks/install-deps/suse/main.yml | 11 ++ > > playbooks/roles/fstests/tasks/main.yml | 39 +++++++ > > .../roles/fstests/templates/cifs/cifs.config | 33 ++++++ > > playbooks/roles/gen_hosts/defaults/main.yml | 1 + > > .../roles/gen_hosts/templates/fstests.j2 | 6 + > > playbooks/roles/gen_nodes/defaults/main.yml | 1 + > > playbooks/roles/gen_nodes/tasks/main.yml | 19 ++++ > > playbooks/roles/smbd/defaults/main.yml | 5 + > > .../smbd/tasks/install-deps/debian/main.yml | 31 ++++++ > > .../roles/smbd/tasks/install-deps/main.yml | 12 ++ > > .../smbd/tasks/install-deps/redhat/main.yml | 33 ++++++ > > .../smbd/tasks/install-deps/suse/main.yml | 29 +++++ > > playbooks/roles/smbd/tasks/main.yml | 95 ++++++++++++++++ > > playbooks/roles/smbd/templates/smb.conf.j2 | 11 ++ > > playbooks/roles/smbd/vars/Debian.yml | 10 ++ > > playbooks/roles/smbd/vars/RedHat.yml | 12 ++ > > playbooks/roles/smbd/vars/Suse.yml | 10 ++ > > playbooks/roles/smbd_add_share/README.md | 57 ++++++++++ > > .../roles/smbd_add_share/defaults/main.yml | 5 + > > playbooks/roles/smbd_add_share/tasks/main.yml | 103 ++++++++++++++++++ > > .../roles/smbd_add_share/templates/share.j2 | 7 ++ > > playbooks/smbd.yml | 4 + > > scripts/smbd.Makefile | 20 ++++ > > workflows/fstests/Kconfig | 20 +++- > > workflows/fstests/Makefile | 4 + > > workflows/fstests/cifs/Kconfig | 75 +++++++++++++ > > workflows/fstests/cifs/Makefile | 17 +++ > > .../expunges/any/cifs/unassigned/all.txt | 60 ++++++++++ > > .../any/cifs/unassigned/cifs_smb3_sign.txt | 2 + > > workflows/fstests/scripts/gendisks.sh | 2 +- > > workflows/fstests/scripts/oscheck.sh | 8 +- > > 37 files changed, 818 insertions(+), 6 deletions(-) > > create mode 100644 kconfigs/Kconfig.smbd > > create mode 100644 playbooks/roles/fstests/templates/cifs/cifs.config > > create mode 100644 playbooks/roles/smbd/defaults/main.yml > > create mode 100644 playbooks/roles/smbd/tasks/install-deps/debian/main.= yml > > create mode 100644 playbooks/roles/smbd/tasks/install-deps/main.yml > > create mode 100644 playbooks/roles/smbd/tasks/install-deps/redhat/main.= yml > > create mode 100644 playbooks/roles/smbd/tasks/install-deps/suse/main.ym= l > > create mode 100644 playbooks/roles/smbd/tasks/main.yml > > create mode 100644 playbooks/roles/smbd/templates/smb.conf.j2 > > create mode 100644 playbooks/roles/smbd/vars/Debian.yml > > create mode 100644 playbooks/roles/smbd/vars/RedHat.yml > > create mode 100644 playbooks/roles/smbd/vars/Suse.yml > > create mode 100644 playbooks/roles/smbd_add_share/README.md > > create mode 100644 playbooks/roles/smbd_add_share/defaults/main.yml > > create mode 100644 playbooks/roles/smbd_add_share/tasks/main.yml > > create mode 100644 playbooks/roles/smbd_add_share/templates/share.j2 > > create mode 100644 playbooks/smbd.yml > > create mode 100644 scripts/smbd.Makefile > > create mode 100644 workflows/fstests/cifs/Kconfig > > create mode 100644 workflows/fstests/cifs/Makefile > > create mode 100644 workflows/fstests/expunges/any/cifs/unassigned/all.t= xt > > create mode 100644 workflows/fstests/expunges/any/cifs/unassigned/cifs_= smb3_sign.txt > >=20 > > --=20 > > 2.44.0 > >=20 > >=20 >=20 > -- > Chuck Lever >=20 >=20