From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D06442B9AF for ; Wed, 17 Apr 2024 04:48:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713329301; cv=none; b=qWmyirWOrdIu6+zPOqirTsRRbKXljUNXV7N8Fh6QL7Dl8ExpaQkaiaJtjQojm1ZknppRA3ke1ijMtngRSQchj6ZPynDcLRLXFHcyfVlEAP5JUOr5LGX5A4Gc107Qb01bj9hwNZBfJvfe1EUB4GORB6S7+dZmaJi0C+WDLj8feKA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713329301; c=relaxed/simple; bh=ZmqDOYxWcizF0cFiG7LzuTUl1GFxnYfdOg88Q+tnYTw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XgAbuvtiqXnC3XE1rrAwqWOR6SazX0NxcY178+ipvMOZPb7mMrMtWl9wL/ZnnhK+Ncdtg47EMwZ7EMGpXbZi6bWheZVv8sZNXO5UDFLP/GB79C2z49dJyqtu9684lfeoHm0yRPyJHs9/llwMoEpwvz1XdpxaFMwX2ZxKEpn4raY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com; spf=pass smtp.mailfrom=fromorbit.com; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b=WvgM3FYN; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="WvgM3FYN" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1e834159f40so620505ad.2 for ; Tue, 16 Apr 2024 21:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1713329299; x=1713934099; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qzYslW1aC2ppMxc5o9XjwDFjTbA8y3cpFfmsZYKNfQg=; b=WvgM3FYNz4mhP3ongidH8Q7+gIfJ7c2pqCI7iEhILTjkxApz1TDlU2Xrn78xNt6nm3 Gw8Q+IgmK7dE9TCkIQEh0ojOWBEfH1XiZ+4YZgzsQ26ubzqLeJAQq8u8tlQBXqCKzRjA 9hdLvEXkMWgqkEVywPwC/h5D6c7gaHTS05Nx4yrrxmJqdh1gsR8QdlyYQqS59muhDy4n syKW/aWrQJb2yDF5YYx7Na0M/WE3+NNBQ3Si1CDVvrBL4VMcPOs/FmUFnikZGLpkWv98 TOY1HtlAAOo0G9siS2Hn+IJ3vY0aVE/cW1gECKATSRbFOejVrSL+nEUTjazD6wYy7BQr 2JVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713329299; x=1713934099; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qzYslW1aC2ppMxc5o9XjwDFjTbA8y3cpFfmsZYKNfQg=; b=MSV4B0cbSTqPvexn1Ffv7b/bLQ1R7AoNmPg8eKqN+vS32YgNQOmiWwSWWY97EzO52r n79mwj6a+5pY/dJPe4tjbPR0kEqwiDcApaiaF90HIm1ndcj819pRHE7eQ361hk2+OYx7 SBl+kYLWebizVzkxWkl75ibPRn5yngfTpVsapw3Fi0Pua1J6sy+qlBzHLzNvTicnxPVN C26us+j1Y5l6fVFv65/TX8O2jh+/HTiL+tTg8gtMI55YZVvZt6VEQPBtSqzzz4AibLyx O0e1GE+LMLsNxhSFpOji0vtgPFkD2DX/MAZ7uw2Blr133PvRdaMI9pA1NUuBiKN2alr8 cGew== X-Gm-Message-State: AOJu0Yz+tK1T50/0vn6K7y5Asm8W0IOCTaNxffhOyWhGkBpOS/LA84RV UbDOhLNF6nW4vhbBF6+oJRdT7/4F/2oS/r/5M6XQNAbaiwnC4NpPTc3FSUWvfU0= X-Google-Smtp-Source: AGHT+IGP3L6ZnkSdK0N2R99RlDrClJFU7WmERLwKk72JVWuOMF3IA4iL2MKCvC8xBVNG3QoQw2vI/A== X-Received: by 2002:a17:903:41c7:b0:1e3:e137:d3af with SMTP id u7-20020a17090341c700b001e3e137d3afmr17134532ple.9.1713329298949; Tue, 16 Apr 2024 21:48:18 -0700 (PDT) Received: from dread.disaster.area (pa49-181-56-237.pa.nsw.optusnet.com.au. [49.181.56.237]) by smtp.gmail.com with ESMTPSA id d5-20020a170902c18500b001e503c555afsm10660421pld.97.2024.04.16.21.48.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 21:48:18 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1rwxDU-000nAR-0J; Wed, 17 Apr 2024 14:48:16 +1000 Date: Wed, 17 Apr 2024 14:48:16 +1000 From: Dave Chinner To: Luis Chamberlain Cc: kdevops@lists.linux.dev, linux-xfs@vger.kernel.org Subject: Re: [PATCH kdevops] xfs: add xfs/242 as failing on xfs_reflink_2k Message-ID: References: <20240416235108.3391394-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240416235108.3391394-1-mcgrof@kernel.org> On Tue, Apr 16, 2024 at 04:51:08PM -0700, Luis Chamberlain wrote: > This test is rather simple, and somehow we managed to capture a > non-crash failure. The test was added to fstests via fstests commit > 0c95fadc35c8e450 ("expand 252 with more corner case tests") which > essentially does this: > > + $XFS_IO_PROG $xfs_io_opt -f -c "truncate $block_size" \ > + -c "pwrite 0 $block_size" $sync_cmd \ > + -c "$zero_cmd 128 128" \ > + -c "$map_cmd -v" $testfile | $filter_cmd > > The map_cmd in this case is: 'bmap -p'. So the test does: > > a) truncates data to the block size > b) sync > c) zero-fills the the blocksize > > The xfs_io bmap displays the block mapping for the current open file. > Since our failed delta is: > > -0: [0..7]: data > +0: [0..7]: unwritten That's most likely a _filter_bmap() issue, not a kernel code bug. i.e. 'bmap -vp' output looks like: EXT: FILE-OFFSET BLOCK-RANGE AG AG-OFFSET TOTAL FLAGS 0: [0..231]: 2076367680..2076367911 18 (6251328..6251559) 232 000000 and _filter_bmap has two separate regex matches against different fields that both trigger "unwritten" output. The first check is against field 5 which is actually the AG-OFFSET in this output, not field 7 which is the FLAGS field. Hence if the ag offset matches '/0[01][01][01][01]/' the filter will emit 'unwritten' regardless of what the flags say it actually is. -Dave. -- Dave Chinner david@fromorbit.com