Re: [PATCH 5/6] fstests: add an option for testing on CIFS

[Luis Chamberlain <mcgrof@kernel.org>]

On Fri, Apr 12, 2024 at 04:49:59PM -0400, Scott Mayhew wrote:
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
> ---
> diff --git a/workflows/fstests/Kconfig b/workflows/fstests/Kconfig
> index c797b24..e6664bf 100644
> --- a/workflows/fstests/Kconfig
> +++ b/workflows/fstests/Kconfig
> diff --git a/workflows/fstests/cifs/Kconfig b/workflows/fstests/cifs/Kconfig
> new file mode 100644
> index 0000000..b88d1fe
> --- /dev/null
> +++ b/workflows/fstests/cifs/Kconfig
> @@ -0,0 +1,75 @@
> +config FSTESTS_SMB_SERVER_HOST
> +	string "Test Server hostname"
> +	default ""
> +	depends on !FSTESTS_USE_KDEVOPS_SMBD
> +	help
> +	  The SMB server hostname or address to test against. Note that
> +	  the clients will expect that an appropriate hierarchy is already
> +	  created for them to mount and use.
> +	  FIXME: document how to make that.
> +
> +# Distributions actively maintaining btrfs support should select this and then

                                        btrfs / CIFS

> +if FSTESTS_CIFS_MANUAL_COVERAGE
> +
> +config FSTESTS_CIFS_SECTION_SMB3
> +	bool "Enable testing section: smb3"
> +	default y
> +	help
> +	  Enabling this will test SMB3.
> +
> +config FSTESTS_CIFS_SECTION_SMB3_SEAL
> +	bool "Enable testing section: smb3_seal"
> +	default n
> +	help
> +	  Enabling this will test SMB3 with encryption.
> +
> +config FSTESTS_CIFS_SECTION_SMB3_SIGN
> +	bool "Enable testing section: smb3_sign"
> +	default n
> +	help
> +	  Enabling this will test SMB3 with signing.
> +
> +endif # FSTESTS_CIFS_MANUAL_COVERAGE
> +
> +if !FSTESTS_CIFS_MANUAL_COVERAGE
> +
> +config FSTESTS_CIFS_SECTION_SMB3
> +	bool
> +	default y

I think you're just missing here the defaults for:

  * SMB3_SEAL
  * SMB3_SIGN

Otherwise looks good.

Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>

  Luis