From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9B8E10FD for ; Mon, 22 Apr 2024 01:11:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713748278; cv=none; b=jUnOHW2z18kCjQolXr2upZtpX8aiuG4KQq3O+MDXFh3R04qXE9av0HvB6nWTuZX8vQ9MNgNwkZTAagL8PNxC5utwCGB4L6YivhM2mcpldO+we5csEdAoXvrUnqHSRQqQy2sPGzCXHjGCzI6SNvpVlYoLTvlM9JiVO7noDWHBUkM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713748278; c=relaxed/simple; bh=NTk+8Ulucq+JQ5oLymY8PykefHYj+VG27c3uSJLGjdU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=ISuTNaMD2oUVLjzZibPGhw7ANO90FBc3GavJti8VLNKOPBh9cw0YxxlhKPL31uRbLe/uPsEGgTwZaeXRCTa+l4LOFS7Dp+op6cFP8P4W8aZiyAVftFFxs/ZEIojTSFkLmvuPNJ70XFETGkyJd7IPmll5S8jkiUNd/c3GsOeQux4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=E/U5D2Xs; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="E/U5D2Xs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713748275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k0ilzZcV8/lhYIhnX7FmBBKeugE/GvpZnMDLgK9Fg3s=; b=E/U5D2XswNyVFyiRH90xldTQt3HyrXebDF+dUP2+pIUg9SdISZ++8BGYi1oZubPZbazBpV k12GkXGHGNSJfooHsja+roMmmTlvOxQq/eZFmbAEOcfgEemieEzvMoHbR6dD2zsiQ1140V K2UaHWTlMVnUrMjLzwQaRLxfmpWRTjQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-152-8frWEDSLN6Ssa-HIVxS4zQ-1; Sun, 21 Apr 2024 21:11:14 -0400 X-MC-Unique: 8frWEDSLN6Ssa-HIVxS4zQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2BFF51005D7C; Mon, 22 Apr 2024 01:11:14 +0000 (UTC) Received: from aion.redhat.com (unknown [10.22.16.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1F78549102; Mon, 22 Apr 2024 01:11:14 +0000 (UTC) Received: by aion.redhat.com (Postfix, from userid 1000) id CDCF61492B9; Sun, 21 Apr 2024 21:11:13 -0400 (EDT) Date: Sun, 21 Apr 2024 21:11:13 -0400 From: Scott Mayhew To: cel@kernel.org Cc: kdevops@lists.linux.dev, Chuck Lever Subject: Re: [PATCH] fstests: Make the use of "--badname" conditional Message-ID: References: <20240421205017.390717-1-cel@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240421205017.390717-1-cel@kernel.org> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, 21 Apr 2024, cel@kernel.org wrote: > From: Chuck Lever > > RHEL 8 does not implement "useradd --badname". Use the --badname > option conditionally, based on OS family. > > Reported-by: Scott Mayhew > Fixes: 08f095cf74f1 ("fstests: Enable creation of group "123456-fsgqa" on SuSE") > Signed-off-by: Chuck Lever Thanks, that fixes the issue on RHEL8 for me. Acked-by: Scott Mayhew -Scott > --- > playbooks/roles/fstests/defaults/main.yml | 1 + > playbooks/roles/fstests/tasks/install-deps/suse/main.yml | 4 ++++ > playbooks/roles/fstests/tasks/main.yml | 2 +- > 3 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/playbooks/roles/fstests/defaults/main.yml b/playbooks/roles/fstests/defaults/main.yml > index 72100e934c39..302341420b58 100644 > --- a/playbooks/roles/fstests/defaults/main.yml > +++ b/playbooks/roles/fstests/defaults/main.yml > @@ -12,6 +12,7 @@ infer_uid_and_group: False > oscheck_extra_args: "" > limit_tests: "" > dynamic_limit_tests: > +badname_arg: "" > > fstests_start_after: False > fstests_start_after_test: "" > diff --git a/playbooks/roles/fstests/tasks/install-deps/suse/main.yml b/playbooks/roles/fstests/tasks/install-deps/suse/main.yml > index 4520451dffbd..c4df15b9d677 100644 > --- a/playbooks/roles/fstests/tasks/install-deps/suse/main.yml > +++ b/playbooks/roles/fstests/tasks/install-deps/suse/main.yml > @@ -247,3 +247,7 @@ > when: > - repos_present|bool > - fstests_fstyp == "cifs" > + > +- name: Set the "--badname" arg > + ansible.builtin.set_fact: > + badname_arg: "--badname" > diff --git a/playbooks/roles/fstests/tasks/main.yml b/playbooks/roles/fstests/tasks/main.yml > index 6a78ff0938de..68f94fe8ed3e 100644 > --- a/playbooks/roles/fstests/tasks/main.yml > +++ b/playbooks/roles/fstests/tasks/main.yml > @@ -882,7 +882,7 @@ > become: yes > become_flags: 'su - -c' > become_method: sudo > - ansible.builtin.command: "useradd --badname -d /home/{{ item }} -U {{ item }}" > + ansible.builtin.command: "useradd {{ badname_arg }} -d /home/{{ item }} -U {{ item }}" > with_items: > - 123456-fsgqa > - fsgqa > > base-commit: 1599e4587893efc07569f97adf7430935b6cf31c > -- > 2.44.0 > >