Re: [PATCH 1/2] nfstest: add git-core to the list of install dependencies

[Scott Mayhew <smayhew@redhat.com>]

On Wed, 24 Apr 2024, Chuck Lever wrote:

> On Wed, Apr 24, 2024 at 05:15:10PM -0400, Scott Mayhew wrote:
> > Currently git-core won't be installed if you're running nfstest as a
> > dedicated workflow.
> 
> I don't think it's the "dedicated workflow" that's the problem,
> because I use that all the time. I think I have the "Install
> kernel developer tools" option set or something like that, and
> that pulls in git, trace-cmd, and other stuff.

Ah, maybe that's it.  I have some workflows running where I'm not
building the kernel, so I'm not installing the kernel developer tools.
I'm just installing the latest RHEL8/RHEL9 nightlies and running tests,
and those are where I'm seeing the problem.

I'll tweak the commit message.

-Scott
> 
> But, OK... this is a real dependency for nfstest, so:
> 
> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
> 
> 
> > Signed-off-by: Scott Mayhew <smayhew@redhat.com>
> > ---
> >  playbooks/roles/nfstest/vars/Debian.yml | 1 +
> >  playbooks/roles/nfstest/vars/RedHat.yml | 1 +
> >  playbooks/roles/nfstest/vars/Suse.yml   | 1 +
> >  3 files changed, 3 insertions(+)
> > 
> > diff --git a/playbooks/roles/nfstest/vars/Debian.yml b/playbooks/roles/nfstest/vars/Debian.yml
> > index cb4cfe5..05d87a2 100644
> > --- a/playbooks/roles/nfstest/vars/Debian.yml
> > +++ b/playbooks/roles/nfstest/vars/Debian.yml
> > @@ -3,3 +3,4 @@ nfstest_packages:
> >    - nfs-common
> >    - python-is-python3
> >    - tcpdump
> > +  - git-core
> > diff --git a/playbooks/roles/nfstest/vars/RedHat.yml b/playbooks/roles/nfstest/vars/RedHat.yml
> > index d8c65fb..a14c20e 100644
> > --- a/playbooks/roles/nfstest/vars/RedHat.yml
> > +++ b/playbooks/roles/nfstest/vars/RedHat.yml
> > @@ -3,3 +3,4 @@ nfstest_packages:
> >    - nfs-utils
> >    - python-unversioned-command
> >    - tcpdump
> > +  - git-core
> > diff --git a/playbooks/roles/nfstest/vars/Suse.yml b/playbooks/roles/nfstest/vars/Suse.yml
> > index 35fcc8e..76adc4d 100644
> > --- a/playbooks/roles/nfstest/vars/Suse.yml
> > +++ b/playbooks/roles/nfstest/vars/Suse.yml
> > @@ -2,3 +2,4 @@
> >  nfstest_packages:
> >    - nfs-utils
> >    - tcpdump
> > +  - git-core
> > -- 
> > 2.44.0
> > 
> > 
> 
> -- 
> Chuck Lever
>