From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE6C1157474 for ; Wed, 24 Apr 2024 21:51:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713995464; cv=none; b=RhATPhCAB6gli1vyUc6LLwOwWM+WXIFHwDBwU/dZGffh2w4Vm9nUGA1NGCZmL0Lb9/7D7exP4lXNUEAG2KZyETRdzp/v9Ml9ZkDrSLR7BQ0MnAzCNBRVRRV0CfrGxZklGwvY42UFLGp6yKm07n7RNvMAk+0ofBJi/Jb+hADt0Ec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713995464; c=relaxed/simple; bh=GftetTLjSI+yQNQb1AoVfF7iRjhDzBZuVfi3vsMHQTY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=T5V1gEMrDsUWTIdiJCKl9W6X48WYfJsG5uQdR9HtAE5P9wWN1OidfBiVAKSfGc2QZNiWOUUxd3y2HakIZYRuabOFvZE24UIT9CsOp9yQHh8qmmMlVQcSXzAGqHerzSv3wGzj73wPjGRpW3pxLA5/H+U/Qa8r8KnnOwF4c98ufbo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JCZ08JVm; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JCZ08JVm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713995460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=suusDWcDG6vQZtYXcPo5CvjoicXbOlI4Ix7jmUDhhiY=; b=JCZ08JVmnZmDF8hKbZt3MYqtc2Ted7USvIGxF7Jkv+nrf3j81B4GkXprOCvLh/GX5tfT/E QP1bsAHM/bWYID9lpoxDEi5caLveMm2A7onYvVpWC6fCALy+ivDgpbubtgIbsu0Kkhrrah sKbQ98kt1Y45rgbNi0Y2dYTv6lfNdy4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-4kS__K7wNkCUSDq3Ya04ig-1; Wed, 24 Apr 2024 17:50:59 -0400 X-MC-Unique: 4kS__K7wNkCUSDq3Ya04ig-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 275081005D5C; Wed, 24 Apr 2024 21:50:59 +0000 (UTC) Received: from aion.redhat.com (unknown [10.22.16.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 16D2C40C6CC0; Wed, 24 Apr 2024 21:50:59 +0000 (UTC) Received: by aion.redhat.com (Postfix, from userid 1000) id A5148149843; Wed, 24 Apr 2024 17:50:58 -0400 (EDT) Date: Wed, 24 Apr 2024 17:50:58 -0400 From: Scott Mayhew To: Chuck Lever Cc: kdevops@lists.linux.dev Subject: Re: [PATCH 1/2] nfstest: add git-core to the list of install dependencies Message-ID: References: <20240424211511.2619637-1-smayhew@redhat.com> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, 24 Apr 2024, Chuck Lever wrote: > On Wed, Apr 24, 2024 at 05:15:10PM -0400, Scott Mayhew wrote: > > Currently git-core won't be installed if you're running nfstest as a > > dedicated workflow. > > I don't think it's the "dedicated workflow" that's the problem, > because I use that all the time. I think I have the "Install > kernel developer tools" option set or something like that, and > that pulls in git, trace-cmd, and other stuff. Ah, maybe that's it. I have some workflows running where I'm not building the kernel, so I'm not installing the kernel developer tools. I'm just installing the latest RHEL8/RHEL9 nightlies and running tests, and those are where I'm seeing the problem. I'll tweak the commit message. -Scott > > But, OK... this is a real dependency for nfstest, so: > > Reviewed-by: Chuck Lever > > > > Signed-off-by: Scott Mayhew > > --- > > playbooks/roles/nfstest/vars/Debian.yml | 1 + > > playbooks/roles/nfstest/vars/RedHat.yml | 1 + > > playbooks/roles/nfstest/vars/Suse.yml | 1 + > > 3 files changed, 3 insertions(+) > > > > diff --git a/playbooks/roles/nfstest/vars/Debian.yml b/playbooks/roles/nfstest/vars/Debian.yml > > index cb4cfe5..05d87a2 100644 > > --- a/playbooks/roles/nfstest/vars/Debian.yml > > +++ b/playbooks/roles/nfstest/vars/Debian.yml > > @@ -3,3 +3,4 @@ nfstest_packages: > > - nfs-common > > - python-is-python3 > > - tcpdump > > + - git-core > > diff --git a/playbooks/roles/nfstest/vars/RedHat.yml b/playbooks/roles/nfstest/vars/RedHat.yml > > index d8c65fb..a14c20e 100644 > > --- a/playbooks/roles/nfstest/vars/RedHat.yml > > +++ b/playbooks/roles/nfstest/vars/RedHat.yml > > @@ -3,3 +3,4 @@ nfstest_packages: > > - nfs-utils > > - python-unversioned-command > > - tcpdump > > + - git-core > > diff --git a/playbooks/roles/nfstest/vars/Suse.yml b/playbooks/roles/nfstest/vars/Suse.yml > > index 35fcc8e..76adc4d 100644 > > --- a/playbooks/roles/nfstest/vars/Suse.yml > > +++ b/playbooks/roles/nfstest/vars/Suse.yml > > @@ -2,3 +2,4 @@ > > nfstest_packages: > > - nfs-utils > > - tcpdump > > + - git-core > > -- > > 2.44.0 > > > > > > -- > Chuck Lever >