Re: [RFC PATCH 1/3] linux-mirror: Add Fedora-specific tasks

[Chuck Lever <chuck.lever@oracle.com>]

On Wed, May 01, 2024 at 10:03:33AM -0400, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
> 
> To get mirroring to work on Fedora, I had to install the git-daemon
> package, because on Fedora, git-daemon is not included in the
> git-core package.
> 
> Also, Fedora's default firewall configuration does not permit git
> traffic.
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>  .../tasks/install-deps/fedora/main.yml        | 24 +++++++++++++++++++

If it turns out that RHEL/CentOS needs this treatment as well, we
can rename this install-deps/redhat/main.yml, and change the
"when:" clause below.

I don't have a RHEL/CentOS control node on hand to test that.


>  playbooks/roles/linux-mirror/tasks/main.yml   |  5 ++++
>  2 files changed, 29 insertions(+)
>  create mode 100644 playbooks/roles/linux-mirror/tasks/install-deps/fedora/main.yml
> 
> diff --git a/playbooks/roles/linux-mirror/tasks/install-deps/fedora/main.yml b/playbooks/roles/linux-mirror/tasks/install-deps/fedora/main.yml
> new file mode 100644
> index 000000000000..2a93256a3d6e
> --- /dev/null
> +++ b/playbooks/roles/linux-mirror/tasks/install-deps/fedora/main.yml
> @@ -0,0 +1,24 @@
> +---
> +- name: Install Fedora-specific dependencies
> +  become: true
> +  become_flags: 'su - -c'
> +  become_method: ansible.builtin.sudo
> +  ansible.builtin.package:
> +    name:
> +      - git-daemon
> +    state: present
> +  when:
> +    - install_linux_mirror|bool
> +
> +- name: Open the firewall on control node for git traffic
> +  become: true
> +  become_flags: 'su - -c'
> +  become_method: ansible.builtin.sudo
> +  ansible.posix.firewalld:
> +    zone: libvirt
> +    port: 9418/tcp
> +    permanent: true
> +    immediate: true
> +    state: enabled
> +  when:
> +    - install_linux_mirror|bool
> diff --git a/playbooks/roles/linux-mirror/tasks/main.yml b/playbooks/roles/linux-mirror/tasks/main.yml
> index 461e131c93fd..a8f673c6d4ee 100644
> --- a/playbooks/roles/linux-mirror/tasks/main.yml
> +++ b/playbooks/roles/linux-mirror/tasks/main.yml
> @@ -10,6 +10,11 @@
>        skip: true
>    tags: vars
>  
> +- name: Install dependencies for the linux-mirror role
> +  ansible.builtin.include_tasks: install-deps/fedora/main.yml
> +  when:
> +    - ansible_distribution == 'Fedora'
> +
>  - name: Set up the mirrors.yaml based on preferences configured
>    tags: [ 'mirror' ]
>    template:
> 
> base-commit: d97440f49b5b5ecb65383a1874014391ca795899
> -- 
> 2.44.0
> 

-- 
Chuck Lever