Re: [PATCH] gitr: Make gitr work on RHEL/CentOS

[Scott Mayhew <smayhew@redhat.com>]

On Fri, 16 Aug 2024, Chuck Lever wrote:

> On Thu, Aug 15, 2024 at 05:59:41PM -0400, Scott Mayhew wrote:
> > RHEL and CentOS do not ship cvsps or perl-TAP-Harness-Archive.  For the
> > former, we'll have to build it from git.  For the latter, we can install
> > it from CPAN, but we'll also have to install the perl-App-cpanminus
> > package to do so.
> > 
> > Also add two other dependencies.  First is 'make', which is currently
> > only installed if you have KDEVOPS_TRY_INSTALL_KDEV_TOOLS enabled in
> > your config.
> 
> That's a little surprising. I guess Ansible's "make" module does not
> install the base make utility?

AFAIK ansible modules just run the commands.  It's up to the user to
make sure the software that provide those commands is already installed
on the target systems.
> 
> 
> > Second is 'tar' which is not installed in the RHEL
> > virt-builder images by default ('tar' isn't part of the @core dnf
> > package group).
> 
> Another option might be to disable the CVS-related tests by not
> installing CVS on the target nodes. The git test suite should pick
> up that omission and then not run those tests.

You're saying that only the CVS-related tests are using tar?  Sounds
weird, but I can try it if you want.  Personally I'd rather have the
same set of tests running on my RHEL targets that are running on my
Fedora targets.

<snip/>

BTW, I think this will probably break the test on Oracle Linux.
> > +  when:
> > +    - ansible_distribution == "RedHat" or
> > +      ansible_distribution == "CentOS"

I think 'when: ansible_distribution != "Fedora"' will work better.

-Scott