From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9AC316B3BD for ; Mon, 19 Aug 2024 12:53:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724072014; cv=none; b=ke0h/5AIuB5iOYi7/yKzVs+au6zHEqEsdtwnShdSbvqyiBzVCcbAaJvxCnwZT4gWlxvt7P/yj3iyEovXvYZZ0J4hcVEUiwcxhZqGTPMgc3SONYI6fD1rMUVx0qVsDdbnrYEYXn5fjwt5M/rAHc+IqYyzNIYrfDJtUyyEeg5I3CQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724072014; c=relaxed/simple; bh=DbXU5/GDKr/oIj5pmF6TavcXxH5KnRz2PwetknOmyrM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=hhhswAvhx0OGomeQdXRvSyQu4vN3qorgyVFajDqzvkD0rw8JwIA5JtZ2kz+LQvXzYDbCXK3tLc8jaFyOIaNXjKZnw6zcioeSfWS0AQsSME15saAsoZE3U5dc4PXSliEF/4BeBF5VlJDoOMLKs7HluIxT8nK988rOdh4wccTkHDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=evXWDYf9; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="evXWDYf9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724072011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XK6GsW3WesnEy69HIkc4+e5lbgDah+e2br4GhozZZ4w=; b=evXWDYf9a250pvGKIlLuMUJIMdTN+A7DBOJ9gekykz+YMgbLkCnQ/a6QSHmbVa6WirX1hN QMKsIS25CIlSq/FpTJ+ApRu6f+JcjRq4yyNzx2mgGJ2dSV1Bhgh1iwUrniv/vnTqp8oHYy Twx03GsIKUjwVOXj6KhL+945OpatXkE= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-552-6eWR9r_1Oum6b-Bzf8yLJg-1; Mon, 19 Aug 2024 08:53:28 -0400 X-MC-Unique: 6eWR9r_1Oum6b-Bzf8yLJg-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 314761956064; Mon, 19 Aug 2024 12:53:27 +0000 (UTC) Received: from aion.redhat.com (unknown [10.22.64.17]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D360A19560A3; Mon, 19 Aug 2024 12:53:26 +0000 (UTC) Received: by aion.redhat.com (Postfix, from userid 1000) id 11E191D8CB8; Mon, 19 Aug 2024 08:53:25 -0400 (EDT) Date: Mon, 19 Aug 2024 08:53:25 -0400 From: Scott Mayhew To: Chuck Lever Cc: kdevops@lists.linux.dev Subject: Re: [PATCH] gitr: Make gitr work on RHEL/CentOS Message-ID: References: <20240815215941.602080-1-smayhew@redhat.com> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, 16 Aug 2024, Chuck Lever wrote: > On Thu, Aug 15, 2024 at 05:59:41PM -0400, Scott Mayhew wrote: > > RHEL and CentOS do not ship cvsps or perl-TAP-Harness-Archive. For the > > former, we'll have to build it from git. For the latter, we can install > > it from CPAN, but we'll also have to install the perl-App-cpanminus > > package to do so. > > > > Also add two other dependencies. First is 'make', which is currently > > only installed if you have KDEVOPS_TRY_INSTALL_KDEV_TOOLS enabled in > > your config. > > That's a little surprising. I guess Ansible's "make" module does not > install the base make utility? AFAIK ansible modules just run the commands. It's up to the user to make sure the software that provide those commands is already installed on the target systems. > > > > Second is 'tar' which is not installed in the RHEL > > virt-builder images by default ('tar' isn't part of the @core dnf > > package group). > > Another option might be to disable the CVS-related tests by not > installing CVS on the target nodes. The git test suite should pick > up that omission and then not run those tests. You're saying that only the CVS-related tests are using tar? Sounds weird, but I can try it if you want. Personally I'd rather have the same set of tests running on my RHEL targets that are running on my Fedora targets. BTW, I think this will probably break the test on Oracle Linux. > > + when: > > + - ansible_distribution == "RedHat" or > > + ansible_distribution == "CentOS" I think 'when: ansible_distribution != "Fedora"' will work better. -Scott