From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7139216C69C for ; Mon, 19 Aug 2024 14:07:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724076438; cv=none; b=GDrcTr7uChuK4xwZO6nTchGRkAzCDBCu9tBrIQrcc6fq2dLoXpohCOcriGUzvxI9pnKZC+f+33T/vFpMmiZFSaIuthoCBd8bcma+3C/ueP0/u8Xn6WpDBN4Pc7R8seeazYYjqq+8AZpMo8I1NegUKDvGJ9SVQj9lgDO50X/jWbw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724076438; c=relaxed/simple; bh=tkvMhY5cSoQfI9w6J3LVzImPH2r/hp/V0j0LqH3HTr0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=CUs3m6tGfgVaIlnoq0VxW4nWNWD6KY83kXeWpt79EQLI6W/j+e4DZRLKFOfNMmItgOWrws5of9rTI0i0mTaeEEyKeugehaXHUmw0zGc1E+mrdEQlBx2gafs3TJKpEJmk4xNUP0HhCcNVyCcY27xQ5qB6WA4z/PyxyZ1VKT5ZonA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DknUy/h1; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DknUy/h1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724076435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vZtMhI0cuj+IuHCtrYha7JP+G/tSMoMKCL3/riEvMTo=; b=DknUy/h13e1wlziDuQcnDrCMy6WYhRU8X62Bt4CbuO5hsP7JoIK0OLj5MXMSySd5oGzmAJ U9VP8ajABdfvPMpAWbRLgAEHJ5zLzEmCKHTyoPS90xFXErWJXtFq9lpBHaVMvdPwETE+3p eBtTiCMAO3d+woDfE08ZW6E2GX0bzmw= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-88--m4Mi5-AO3y11XZ0hQNZSw-1; Mon, 19 Aug 2024 10:07:14 -0400 X-MC-Unique: -m4Mi5-AO3y11XZ0hQNZSw-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AF3111955D4C; Mon, 19 Aug 2024 14:07:12 +0000 (UTC) Received: from aion.redhat.com (unknown [10.22.64.17]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6E9241977404; Mon, 19 Aug 2024 14:07:12 +0000 (UTC) Received: by aion.redhat.com (Postfix, from userid 1000) id 8B27D1D8CC4; Mon, 19 Aug 2024 10:07:10 -0400 (EDT) Date: Mon, 19 Aug 2024 10:07:10 -0400 From: Scott Mayhew To: Chuck Lever III Cc: "kdevops@lists.linux.dev" Subject: Re: [PATCH] gitr: Make gitr work on RHEL/CentOS Message-ID: References: <20240815215941.602080-1-smayhew@redhat.com> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, 19 Aug 2024, Chuck Lever III wrote: >=20 >=20 > > On Aug 19, 2024, at 8:53=E2=80=AFAM, Scott Mayhew = wrote: > >=20 > > On Fri, 16 Aug 2024, Chuck Lever wrote: > >=20 > >> On Thu, Aug 15, 2024 at 05:59:41PM -0400, Scott Mayhew wrote: > >>> RHEL and CentOS do not ship cvsps or perl-TAP-Harness-Archive. For t= he > >>> former, we'll have to build it from git. For the latter, we can inst= all > >>> it from CPAN, but we'll also have to install the perl-App-cpanminus > >>> package to do so. > >>>=20 > >>> Also add two other dependencies. First is 'make', which is currently > >>> only installed if you have KDEVOPS_TRY_INSTALL_KDEV_TOOLS enabled in > >>> your config. > >>=20 > >> That's a little surprising. I guess Ansible's "make" module does not > >> install the base make utility? > >=20 > > AFAIK ansible modules just run the commands. It's up to the user to > > make sure the software that provide those commands is already installed > > on the target systems. >=20 > My Buildbot configurations do not have INSTALL_KDEV_TOOLS enabled, > but they seem to have no problem running the gitr workflow. I'm > thinking there might be some other reason why "make" is not > available -- ie, my quibble is with the patch description, not > with adding the dependency. Ok, let me double-check the Fedora images to see where they're getting 'make' from. >=20 >=20 > >>> Second is 'tar' which is not installed in the RHEL > >>> virt-builder images by default ('tar' isn't part of the @core dnf > >>> package group). > >>=20 > >> Another option might be to disable the CVS-related tests by not > >> installing CVS on the target nodes. The git test suite should pick > >> up that omission and then not run those tests. > >=20 > > You're saying that only the CVS-related tests are using tar? Sounds > > weird, but I can try it if you want. Personally I'd rather have the > > same set of tests running on my RHEL targets that are running on my > > Fedora targets. >=20 > That's sensible -- let's keep them the same. Sounds good. >=20 >=20 > > > >=20 > > BTW, I think this will probably break the test on Oracle Linux. > >>> + when: > >>> + - ansible_distribution =3D=3D "RedHat" or > >>> + ansible_distribution =3D=3D "CentOS" > >=20 > > I think 'when: ansible_distribution !=3D "Fedora"' will work better. >=20 > No argument from me. I probably copied that from somewhere else. Those new 'when' clauses were added by my patch and I was just pointing out my mistake. -Scott >=20 >=20 > -- > Chuck Lever >=20 >=20