Re: [PATCH] gitr: Make gitr work on RHEL/CentOS

[Scott Mayhew <smayhew@redhat.com>]

On Mon, 19 Aug 2024, Scott Mayhew wrote:

> On Mon, 19 Aug 2024, Chuck Lever III wrote:
> 
> > 
> > 
> > > On Aug 19, 2024, at 8:53 AM, Scott Mayhew <smayhew@redhat.com> wrote:
> > > 
> > > On Fri, 16 Aug 2024, Chuck Lever wrote:
> > > 
> > >> On Thu, Aug 15, 2024 at 05:59:41PM -0400, Scott Mayhew wrote:
> > >>> RHEL and CentOS do not ship cvsps or perl-TAP-Harness-Archive.  For the
> > >>> former, we'll have to build it from git.  For the latter, we can install
> > >>> it from CPAN, but we'll also have to install the perl-App-cpanminus
> > >>> package to do so.
> > >>> 
> > >>> Also add two other dependencies.  First is 'make', which is currently
> > >>> only installed if you have KDEVOPS_TRY_INSTALL_KDEV_TOOLS enabled in
> > >>> your config.
> > >> 
> > >> That's a little surprising. I guess Ansible's "make" module does not
> > >> install the base make utility?
> > > 
> > > AFAIK ansible modules just run the commands.  It's up to the user to
> > > make sure the software that provide those commands is already installed
> > > on the target systems.
> > 
> > My Buildbot configurations do not have INSTALL_KDEV_TOOLS enabled,
> > but they seem to have no problem running the gitr workflow. I'm
> > thinking there might be some other reason why "make" is not
> > available -- ie, my quibble is with the patch description, not
> > with adding the dependency.
> 
> Ok, let me double-check the Fedora images to see where they're getting
> 'make' from.

It looks like the real culprit is that the "Install btrfs-progs" play in
playbooks/roles/devconfig/tasks/install-deps/redhat/main.yml doesn't
really do what it claims.  It's actually installing the entire set of
packages from the "Build install package list" play right before it.
That's how we're magically getting both the make and tar packages on
Fedora... make included in that list explicitly, and tar is getting
pulled in as a dependency of libtool.

> > 
> > 
> > >>> Second is 'tar' which is not installed in the RHEL
> > >>> virt-builder images by default ('tar' isn't part of the @core dnf
> > >>> package group).
> > >> 
> > >> Another option might be to disable the CVS-related tests by not
> > >> installing CVS on the target nodes. The git test suite should pick
> > >> up that omission and then not run those tests.
> > > 
> > > You're saying that only the CVS-related tests are using tar?  Sounds
> > > weird, but I can try it if you want.  Personally I'd rather have the
> > > same set of tests running on my RHEL targets that are running on my
> > > Fedora targets.
> > 
> > That's sensible -- let's keep them the same.
> 
> Sounds good.
> > 
> > 
> > > <snip/>
> > > 
> > > BTW, I think this will probably break the test on Oracle Linux.
> > >>> +  when:
> > >>> +    - ansible_distribution == "RedHat" or
> > >>> +      ansible_distribution == "CentOS"
> > > 
> > > I think 'when: ansible_distribution != "Fedora"' will work better.
> > 
> > No argument from me. I probably copied that from somewhere else.
> 
> Those new 'when' clauses were added by my patch and I was just pointing
> out my mistake.
> 
> -Scott
> > 
> > 
> > --
> > Chuck Lever
> > 
> >