From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF7231E1324 for ; Wed, 4 Sep 2024 18:07:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725473263; cv=none; b=PdwlUWhisKSwg1JsBm7CgqRi6jGD67SZme1L5cqTTqJ9IqJg2bGG5hH6R+d325jcDbgFYQOsRhFwieR6V2jVt/ASu65od2ywCLZoDQrY6KlBIBDrJgh+Imwa3TCUccWWKxgVJT1Srcn6fULmzl00VZrayldh2PlN9mCtc0offGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725473263; c=relaxed/simple; bh=SffWRc49sHi/nOsCFI1IbSkXckiD1XO4gZHiaJznhVQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=NwZe4hD0afP4VGpgHfpNHKDxK7TJQ3myVix8GIHGmDMt/AoG5yKNC7G7xPOffHhw0s+j/GeeFE+J47Sfw4+I0gUK5zyNQzvfGWKLqp2ta4G+cCYWFk7z6X9KxrDe6k4CflZzyuupxSvWsTMiN461QHgFutAs4xs6XawmnaGEJ0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=jUUEnoRL; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jUUEnoRL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725473260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3TXQM2CQce+HGDz1TYv3+De1RiCkpOgIem1COcvN0OI=; b=jUUEnoRLGvqXHO5WERHsZwxf4PYZOgTwTxnotHHJ02ezunhV8Rz6TUnxpl0sNj5/xBk2xo ToLDJ7YdCUmbwuCXw5nImrJcYKf2A9V9xLTpxyFle2hgWTXfkQKZCjf5SGTXZPAqj6wcQs YCjHQpSLP+IyHo6nv2+aVFSaw2+el+Q= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-490-GA8yfYO5O_-FpL_tD0fwBw-1; Wed, 04 Sep 2024 14:07:37 -0400 X-MC-Unique: GA8yfYO5O_-FpL_tD0fwBw-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 85F481955F40; Wed, 4 Sep 2024 18:07:36 +0000 (UTC) Received: from aion.redhat.com (unknown [10.22.9.161]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9F45C1955F44; Wed, 4 Sep 2024 18:07:35 +0000 (UTC) Received: by aion.redhat.com (Postfix, from userid 1000) id 8DC1E1F14B0; Wed, 4 Sep 2024 14:07:33 -0400 (EDT) Date: Wed, 4 Sep 2024 14:07:33 -0400 From: Scott Mayhew To: Chuck Lever Cc: kdevops@lists.linux.dev Subject: Re: [PATCH 2/2] gitr: Make gitr work on RHEL/CentOS Message-ID: References: <20240903144847.355326-1-smayhew@redhat.com> <20240903144847.355326-2-smayhew@redhat.com> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, 04 Sep 2024, Chuck Lever wrote: > On Tue, Sep 03, 2024 at 10:48:47AM -0400, Scott Mayhew wrote: > > RHEL and CentOS do not ship cvsps or perl-TAP-Harness-Archive. For the > > former, we'll have to build it from git. For the latter, we can install > > it from CPAN, but we'll also have to install the perl-App-cpanminus > > package to do so. > > > > Also add 'make' and 'tar' to the dependencies list. These were > > previously getting installed inadvertently by the "Install btrfs-progs" > > task in playbooks/roles/devconfig/tasks/install-deps/redhat/main.yml, > > which was installing more than just btrfs-progs. > > > > Signed-off-by: Scott Mayhew > > --- > > playbooks/roles/gitr/defaults/main.yml | 3 ++ > > playbooks/roles/gitr/tasks/main.yml | 62 ++++++++++++++++++++++++++ > > playbooks/roles/gitr/vars/RedHat.yml | 7 ++- > > 3 files changed, 70 insertions(+), 2 deletions(-) > > > > diff --git a/playbooks/roles/gitr/defaults/main.yml b/playbooks/roles/gitr/defaults/main.yml > > index bcfbaef..ff737ca 100644 > > --- a/playbooks/roles/gitr/defaults/main.yml > > +++ b/playbooks/roles/gitr/defaults/main.yml > > @@ -18,3 +18,6 @@ gitr_thread_single: false > > gitr_thread_fast: false > > gitr_thread_stress: false > > gitr_thread_custom: false > > + > > +cvsps_git: https://github.com/andreyvit/cvsps.git > > +cvsps_data: "{{ data_path }}/cvsps" > > diff --git a/playbooks/roles/gitr/tasks/main.yml b/playbooks/roles/gitr/tasks/main.yml > > index 330350c..2eafeaa 100644 > > --- a/playbooks/roles/gitr/tasks/main.yml > > +++ b/playbooks/roles/gitr/tasks/main.yml > > @@ -11,6 +11,11 @@ > > failed_when: false > > tags: vars > > > > +- name: Set up the /data mount point > > + tags: ['data_partition'] > > + ansible.builtin.include_role: > > + name: create_data_partition > > + > > - name: Set the name of the test group > > tags: vars > > ansible.builtin.set_fact: > > @@ -42,6 +47,20 @@ > > paths: > > - 'vars' > > > > +- name: Update gitr depencies for RHEL/Centos > > + tags: gitr > > + ansible.builtin.set_fact: > > + gitr_packages: "{{ gitr_packages + ['perl-App-cpanminus'] }}" > > + when: > > + - ansible_distribution != "Fedora" > > + > > +- name: Update gitr dependencies for Fedora > > + tags: gitr > > + ansible.builtin.set_fact: > > + gitr_packages: "{{ gitr_packages + ['cvsps', 'perl-TAP-Harness-Archive'] }}" > > + when: > > + - ansible_distribution == "Fedora" > > + > > - name: Install dependencies for gitr > > tags: gitr > > become: true > > @@ -51,6 +70,49 @@ > > name: "{{ gitr_packages }}" > > state: present > > > > +- name: Install CPAN modules for gitr > > + tags: gitr > > + become: true > > + become_flags: 'su - -c' > > + become_method: ansible.builtin.sudo > > + community.general.cpanm: > > + name: "{{ item }}" > > + with_items: "{{ gitr_cpan_modules }}" > > + when: > > + - ansible_distribution != "Fedora" > > + > > +- name: git clone cvsps > > + tags: gitr > > + ansible.builtin.git: > > + repo: "{{ cvsps_git }}" > > + dest: "{{ cvsps_data }}" > > + update: true > > + retries: 3 > > + delay: 5 > > + register: result > > + until: not result.failed > > + when: > > + - ansible_distribution != "Fedora" > > + > > +- name: Build cvsps > > + tags: gitr > > + community.general.make: > > + chdir: "{{ cvsps_data }}" > > + jobs: "{{ ansible_processor_nproc }}" > > + when: > > + - ansible_distribution != "Fedora" > > + > > +- name: Install cvsps > > + tags: gitr > > + become: true > > + become_flags: 'su - -c' > > + become_method: ansible.builtin.sudo > > + community.general.make: > > + target: install > > + chdir: "{{ cvsps_data }}" > > + when: > > + - ansible_distribution != "Fedora" > > + > > - name: Set up an iSCSI initiator on the target node > > ansible.builtin.include_role: > > name: iscsi > > diff --git a/playbooks/roles/gitr/vars/RedHat.yml b/playbooks/roles/gitr/vars/RedHat.yml > > index 57f2f35..caf9840 100644 > > --- a/playbooks/roles/gitr/vars/RedHat.yml > > +++ b/playbooks/roles/gitr/vars/RedHat.yml > > @@ -1,7 +1,6 @@ > > --- > > gitr_packages: > > - cvs > > - - cvsps > > - expat-devel > > - gcc > > - gettext > > @@ -9,11 +8,15 @@ gitr_packages: > > - git-email > > - glibc-utils > > - libcurl-devel > > + - make > > - openssl-devel > > - perl-Memoize > > - - perl-TAP-Harness-Archive > > - perl-Test-Harness > > - perl-Test-Simple > > - subversion > > - subversion-perl > > + - tar > > - zlib-devel > > + > > +gitr_cpan_modules: > > + - TAP::Harness::Archive > > -- > > 2.44.0 > > > > > > Reviewed-by: Chuck Lever > > With stock kdevops, I'm seeing some gitr failures (eg, t6300) on > Fedora 40 that were not there on Fedora 39. Wondering if this series > might help with that. Unfortunately no - the only effect that these patches should have on Fedora is that the devconfig playbook is no longer accidentally installing extra packages. I'm seeing this failures on 6.10.6-200.fc40.x86_64: Test Summary Report ------------------- ./t6300-for-each-ref.sh (Wstat: 256 (exited 1) Tests: 418 Failed: 3) Failed tests: 35, 107-108 Non-zero exit status: 1 ./t9001-send-email.sh (Wstat: 256 (exited 1) Tests: 199 Failed: 4) Failed tests: 37, 48-50 Non-zero exit status: 1 Files=999, Tests=29254, 1711 wallclock secs (17.16 usr 4.92 sys + 1259.25 cusr 2402.60 csys = 3683.93 CPU) Result: FAIL and the *.stderr files have no info in them at all. Everything passed on 6.10.6-100.fc39.x86_64. > > -- > Chuck Lever >