From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAB0B18D65C for ; Fri, 18 Oct 2024 22:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729289696; cv=none; b=RpPrDnV5Id0rjN0kB9M5ck38vae3pyV5FbZqH45RfxpMS3cuiK8x62hIFrGkUmh5cSHTerL854x/nWmrqbsTc68VCvzj6UAWZGbVCUXcHq91brBbXz1U/Bj/FHmB/3DRgCtmECILOBWyOguEsR4PJfrtNajkHqjdPaG7E1TwGJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729289696; c=relaxed/simple; bh=LwArPTym0OJr7DuG6hjsGOBsuQp8asjjEf+NOghLckM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=LjNu5wUUODv0c107FkNO29Wzm9ME0AKNnyXJFzN5M3FI7lKuPkfjk44MJZ5DTSS3i7PRcSxOcdbXs/A/D46s8CfPRTLLXhnIGf3jrNLtdCeyksbnp9PNcV1EKI1PzNKtQVh8MaMyFuBGdrs26B9fxnw3oLWMfEe8m4GURJWGKhM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cfgcecuA; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cfgcecuA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729289693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v5EAslv8IOnjWuyXwZDUOXPznaPE5UEiyRefKi/Yls8=; b=cfgcecuAlT1oEWJipV599ZLAeJl0b7QeMptu16hWuA41RqQELHaTwmSP25eJL6j4TNX2z5 AlWLIQGsaL/pUwvdkHB+/jxZtTrLcjAG5xo7fQ0UecrIdsQy6KoNSKdSBOX3rLzqQx7grJ P0AAjjTn5D9BLGrdpve937VZKwN1Vd0= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-20-QlKcHFnwPwO813t-DsuNIg-1; Fri, 18 Oct 2024 18:14:52 -0400 X-MC-Unique: QlKcHFnwPwO813t-DsuNIg-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7800919560BE; Fri, 18 Oct 2024 22:14:51 +0000 (UTC) Received: from aion.redhat.com (unknown [10.22.80.82]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D56DF19560AD; Fri, 18 Oct 2024 22:14:50 +0000 (UTC) Received: by aion.redhat.com (Postfix, from userid 1000) id DFDB621BCFA; Fri, 18 Oct 2024 18:14:48 -0400 (EDT) Date: Fri, 18 Oct 2024 18:14:48 -0400 From: Scott Mayhew To: cel@kernel.org Cc: kdevops@lists.linux.dev, Chuck Lever Subject: Re: [PATCH] pynfs: Enable codeready-builder in AWS Message-ID: References: <20241018214454.1882565-1-cel@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20241018214454.1882565-1-cel@kernel.org> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, 18 Oct 2024, cel@kernel.org wrote: > From: Chuck Lever > > Running "make pynfs" against an AWS EC2 instance fails with: > > Error: No matching repo to modify: codeready-builder-for-rhel-9-x86_64-rpms. > > Adjust the logic in > playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml to try > to sketch in what we might need for running the pynfs in the > cloud. > > Signed-off-by: Chuck Lever > --- > .../pynfs/tasks/install-deps/redhat/main.yml | 51 ++++++++++++++----- > 1 file changed, 38 insertions(+), 13 deletions(-) > > diff --git a/playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml b/playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml > index f4aee14c5430..5f377eed436f 100644 > --- a/playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml > +++ b/playbooks/roles/pynfs/tasks/install-deps/redhat/main.yml > @@ -1,24 +1,49 @@ > --- > -- name: Enable the CodeReady repo > - become: yes > - command: /usr/bin/dnf config-manager --enable codeready-builder-for-rhel-{{ ansible_distribution_major_version }}-{{ ansible_architecture }}-rpms > +# name: Display all variables > +# debug: > +# var=vars Probably should remove the debugging stuff before merging. > + > +- name: Select the CodeReady repo to enable > + ansible.builtin.set_fact: > + nfsd_codeready_repo: "codeready-builder-for-rhel-{{ ansible_distribution_major_version }}-rhui-rpms" > when: > - - ansible_distribution == 'RedHat' > + - kdevops_enable_terraform > + - kdevops_terraform_provider == "aws" > + - ansible_distribution == "RedHat" > + > +- name: Select the CodeReady repo to enable > + ansible.builtin.set_fact: > + nfsd_codeready_repo: "codeready-builder-for-rhel-{{ ansible_distribution_major_version }}-{{ ansible_architecture }}-rpms" > + when: > + - not kdevops_enable_terraform > + - ansible_distribution == "RedHat" > + - not devconfig_custom_yum_repofile > + > +- name: Select the CodeReady repo to enable > + ansible.builtin.set_fact: > + nfsd_codeready_repo: "crb" > + when: > + - not kdevops_enable_terraform > + - ansible_distribution == "CentOS" > - not devconfig_custom_yum_repofile > > - name: Enable the CodeReady repo > - become: yes > - command: /usr/bin/dnf config-manager --enable crb > - when: > - - ansible_distribution == 'CentOS' > - - not devconfig_custom_yum_repofile > + become: true > + become_method: ansible.builtin.sudo > + ansible.builtin.command: > + argv: > + - "/usr/bin/dnf" > + - "config-manager" > + - "--enable" > + - "{{ nfsd_codeready_repo }}" I'm not sure if this will work on my setups. I use devconfig_custom_yum_repofile in lieu of registering my systems because I'm usually testing bits that aren't in any official repos yet. So nfsd_codeready_repo will be unset when it gets to this command and it'll just run 'dnf config-manager --enable'. > > - name: Install build dependencies for pynfs > - become: yes > - become_method: sudo > - yum: > - update_cache: yes > + become: true > + become_method: ansible.builtin.sudo > + ansible.builtin.yum: > + update_cache: true > name: "{{ packages }}" > + state: present > retries: 3 > delay: 5 > register: result > -- > 2.46.1 > >