Re: [PATCH v2 0/4] Add uniquifier to storage pool path

[Chuck Lever <cel@kernel.org>]

On 4/23/25 2:22 AM, Luis Chamberlain wrote:
> On Mon, Apr 14, 2025 at 01:05:42PM -0400, cel@kernel.org wrote:
>> From: Chuck Lever <chuck.lever@oracle.com>
>>
>> I'd like to be able to run more than one instance of kdevops per
>> physical host. Currently the kdevops guestfs set-up steers all
>> storage pool activity into ${STORAGE_POOL}/kdevops/guestfs, which
>> means there's a good change that two different logged-in users will
>> create virtual machines whose names, OS base images, and block
>> devices will interfere with each other.
>>
>> So far I haven't been able to get the other storage pool-related
>> settings to add sufficient uniqueness to prevent this conflict.
>>
>> v2 introduces some additional clean-ups, and attempts to address
>> review comments.
> 
> I gave this a spin to see if exisitng deployments won't break but they
> would right away:
> 
> Here is me running on a debian system where we had the old setup:
> 
> make defconfig-seltests-radix-tree KDEVOPS_HOSTS_PREFIX=x2
> make -j128
> make bringup
> 
> User mcgrof is part of the libvirt-qemu group.
> .//scripts/bringup_guestfs.sh: line 276: [: too many arguments
> cp: target '}}/guestfs/x2-maple/root.raw': No such file or directory
> Extra parameter on the command line: ‘libvirt_storage_pool_path’.
> Try ‘virt-sysprep --help’ or consult virt-sysprep(1) for more information.
> Formatting '{{ libvirt_storage_pool_path }}/{{ kdevops_storage_pool_user }}/guestfs/x2-maple/extra0.raw', fmt=raw size=107374182400
> chmod: cannot access '{{': No such file or directory
> chmod: cannot access 'libvirt_storage_pool_path': No such file or directory
> chmod: cannot access '}}/{{': No such file or directory
> chmod: cannot access 'kdevops_storage_pool_user': No such file or directory
> chmod: cannot access '}}/guestfs/x2-maple/extra0.raw': No such file or directory
> Formatting '{{ libvirt_storage_pool_path }}/{{ kdevops_storage_pool_user }}/guestfs/x2-maple/extra1.raw', fmt=raw size=107374182400
> chmod: cannot access '{{': No such file or directory
> chmod: cannot access 'libvirt_storage_pool_path': No such file or directory
> chmod: cannot access '}}/{{': No such file or directory
> chmod: cannot access 'kdevops_storage_pool_user': No such file or directory
> chmod: cannot access '}}/guestfs/x2-maple/extra1.raw': No such file or directory
> Formatting '{{ libvirt_storage_pool_path }}/{{ kdevops_storage_pool_user }}/guestfs/x2-maple/extra2.raw', fmt=raw size=107374182400
> chmod: cannot access '{{': No such file or directory
> chmod: cannot access 'libvirt_storage_pool_path': No such file or directory
> chmod: cannot access '}}/{{': No such file or directory
> chmod: cannot access 'kdevops_storage_pool_user': No such file or directory
> chmod: cannot access '}}/guestfs/x2-maple/extra2.raw': No such file or directory
> Formatting '{{ libvirt_storage_pool_path }}/{{ kdevops_storage_pool_user }}/guestfs/x2-maple/extra3.raw', fmt=raw size=107374182400
> chmod: cannot access '{{': No such file or directory
> chmod: cannot access 'libvirt_storage_pool_path': No such file or directory
> chmod: cannot access '}}/{{': No such file or directory
> chmod: cannot access 'kdevops_storage_pool_user': No such file or directory
> chmod: cannot access '}}/guestfs/x2-maple/extra3.raw': No such file or directory
> Domain 'x2-maple' defined from .//guestfs/x2-maple/x2-maple.xml
> 
> error: Failed to start domain 'x2-maple'
> error: Cannot access storage file '/xfs1/libvirt/mcgrof/guestfs/x2-maple/root.raw': No such file or directory
> 
> Failed to start x2-maple
> make: *** [scripts/guestfs.Makefile:80: bringup_guestfs] Error 1
> 
> So, while I like the idea and approach, this would break tons of
> deployments right now.
> 
>   Luis

As I mentioned here [1], because KDEVOPS_STORAGE_POOL_PATH contains a
template string:

{{ libvirt_storage_pool_path }}/{{ kdevops_storage_pool_user }}

not a file pathname, 4/4 won't work.

I've committed 1/4 through 3/4 to linux-kdevops, and can post an
updated version of 4/4 that might work better for you. But if it
doesn't, then I'm open to adding a Kconfig option as you suggested.

-- 
Chuck Lever

[1]
https://lore.kernel.org/kdevops/44e1183d-78a7-411c-bd1f-2e7d4e6fcb32@oracle.com/