Re: [PATCH] devconfig: add a default for kdevops_enable_terraform

[Jeff Layton <jlayton@kernel.org>]

On Wed, 2025-09-24 at 15:57 -0400, Chuck Lever wrote:
> On 9/24/25 12:55 PM, Jeff Layton wrote:
> > On Wed, 2025-09-24 at 15:48 -0400, Chuck Lever wrote:
> > > On 9/24/25 12:42 PM, Jeff Layton wrote:
> > > > Fixes: 7710a1e2e820 ("devconfig: Remove "dnf update" optimizations for terraform hosts")
> > > > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > > > ---
> > > >  playbooks/roles/devconfig/defaults/main.yml | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/playbooks/roles/devconfig/defaults/main.yml b/playbooks/roles/devconfig/defaults/main.yml
> > > > index c5c06e01b06d..b5d4724d37ef 100644
> > > > --- a/playbooks/roles/devconfig/defaults/main.yml
> > > > +++ b/playbooks/roles/devconfig/defaults/main.yml
> > > > @@ -59,3 +59,4 @@ distro_debian_has_hop1_sources: false
> > > >  unattended_upgrades_installed: false
> > > >  workflow_infer_user_and_group: false
> > > >  kdevops_use_declared_hosts: false
> > > > +kdevops_enable_terraform: false
> > > 
> > > Yeah. "output yaml" doesn't work the way I expect. <sheesh>
> > > 
> > 
> > The way these defaults get set seems very random and fragmented to me.
> > 
> > Can I take your "Yeah" as a R-b? 
> 
> I didn't give a full-throated R-b because I'm wondering if there's
> a better way to approach this general problem.
> 

That's the way I feel too. I don't get the logic of when to set
variables in a limited way like this and when to do it more globally.
For now, this at least gets things running again for me.

> But OK:
> 
> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
> 

Thanks!
-- 
Jeff Layton <jlayton@kernel.org>