public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: Daniel Gomez <da.gomez@kernel.org>
To: Luis Chamberlain <mcgrof@kernel.org>,
	Chuck Lever <cel@kernel.org>, Daniel Gomez <da.gomez@kruces.com>,
	kdevops@lists.linux.dev
Subject: Re: [PATCH v2 7/9] all: run black
Date: Fri, 1 Aug 2025 10:12:14 +0200	[thread overview]
Message-ID: <a7c86abb-7544-472f-99d5-248b2897710d@kernel.org> (raw)
In-Reply-To: <dcc46f8e-7988-4156-a7db-f8bc5ad13692@kernel.org>



On 31/07/2025 14.57, Daniel Gomez wrote:
> On 30/07/2025 08.01, Luis Chamberlain wrote:
>> Run black to fix tons of styling issues with tons of Python scripts.
>> In order to help bots ensure they don't add odd styling we need a
>> convention.
>>
>> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> 
> Acked-by: Daniel Gomez <da.gomez@samsung.com>
> 
> FYI, I'm working on b4 check stuff mentioned in the other thread. I think this
> is really nice but it would be awesome to also extend it to Ansible files using
> the Ansible linter:
> 
> ansible-lint --help
> {...}
> --fix [WRITE_LIST]    Allow ansible-lint to perform auto-fixes, including YAML
> reformatting
> 
> So, these changes with black/ansible-lint, etc make sense if:
> 1. Add b4 integration
> 2. Make CI run the scripts as well (make style, make check, etc)
> 
> But I suspect a minimal testing may be needed.
> 
> Thoughts?

I'll send an RFC with more details.

  reply	other threads:[~2025-08-01  8:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-30  6:01 [PATCH v2 0/9] kdevops: add support for A/B testing Luis Chamberlain
2025-07-30  6:01 ` [PATCH v2 1/9] roles/guestfs: add missing bootlinux_9p: False Luis Chamberlain
2025-07-30 14:17   ` Chuck Lever
2025-07-30  6:01 ` [PATCH v2 2/9] Makefile: suppress Ansible warnings during configuration generation Luis Chamberlain
2025-07-30  6:22   ` Daniel Gomez
2025-07-30  6:01 ` [PATCH v2 3/9] playbooks: few space cleanups Luis Chamberlain
2025-07-30  6:01 ` [PATCH v2 4/9] style: add extensive code formatting checks to make style Luis Chamberlain
2025-07-30  6:01 ` [PATCH v2 5/9] Makefile: move styling to scripts/style.Makefile Luis Chamberlain
2025-07-30  6:01 ` [PATCH v2 6/9] CLAUDE.md: add instrucitons to verify commit Luis Chamberlain
2025-07-30  6:01 ` [PATCH v2 7/9] all: run black Luis Chamberlain
2025-07-31 12:57   ` Daniel Gomez
2025-08-01  8:12     ` Daniel Gomez [this message]
2025-08-01 12:55       ` Chuck Lever
2025-08-01 16:29         ` Daniel Gomez
2025-08-01 16:55           ` Chuck Lever
2025-07-30  6:01 ` [PATCH v2 8/9] devconfig: add automatic APT mirror fallback for Debian testing Luis Chamberlain
2025-07-30  6:41   ` Daniel Gomez
2025-08-01 17:39     ` Luis Chamberlain
2025-07-30  6:01 ` [PATCH v2 9/9] bootlinux: add support for A/B kernel testing Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7c86abb-7544-472f-99d5-248b2897710d@kernel.org \
    --to=da.gomez@kernel.org \
    --cc=cel@kernel.org \
    --cc=da.gomez@kruces.com \
    --cc=kdevops@lists.linux.dev \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox