From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7F2E1F4CAB for ; Wed, 23 Apr 2025 06:22:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745389336; cv=none; b=mDpSlnMqfhJQVSjlmB/URpMoDCfalTAjhME4ulQj7xgah3PRipD4u6FMnKEhBpeNkUWJtF5BCjknOQDDmW2+ev/a2fPCeGbq7Jlr2Xk9nyjYbGp4UB8CDRcxeRQZaGsP8cfrrC6jOSRvDPvbv6U87saxMRYHR1TUdBVKHMFPmaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745389336; c=relaxed/simple; bh=APZxbfXV6GPyPdFchKR89W3mmAACOEKdncvqKXXO5Js=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TmiLD7A9tf26EbiaLAURQSaq9dg6WjWcNqo5L8Bd9OvN2XA98GF2yVlZVgfjlJbyew+ncRl3KuJ4FWNpgqmWL6gmkmrxK2Ga8lfrnrwVDbuxVaA4Sc6B67Gg7wxzm0SVfXbAZqpcItQFcd8nIs85Hetp88yNsi8IQgQG8GeVJ+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L4rkmLB/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L4rkmLB/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2A6DC4CEE2; Wed, 23 Apr 2025 06:22:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745389335; bh=APZxbfXV6GPyPdFchKR89W3mmAACOEKdncvqKXXO5Js=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L4rkmLB/k1bamfhBBwStMUJODMWBDOXmNisTDMF6wDK0NsT/OL8ZwX+DTCPQJCOJz EgHSl26CROcSrDDvYDx/9bXqOJ9BTNexiXBz1B6BxlQeaYPZO4TMZuXpeFGtjdsnva 9JgaN4zrIUnIsEkidw3Qwk4KquZoIDW2iUcD0Rp7uGyVyrLprJzjCNTgstDhBWxQm6 JjTyNo7S/S4d3hDqGZIHvZ0YI77Y8eqUCSd9OJk3dCrcN19O1/fiPaAmuvdNziKB4h zDXnJPuv7l7qLmkFNEbYBIO/x24TL4xItGPvX/tcgiun/kzuCWA65UM9zB+5bygz8G z4YO03Ytkk7AA== Date: Tue, 22 Apr 2025 23:22:13 -0700 From: Luis Chamberlain To: cel@kernel.org Cc: kdevops@lists.linux.dev, Chuck Lever Subject: Re: [PATCH v2 0/4] Add uniquifier to storage pool path Message-ID: References: <20250414170546.1995982-1-cel@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250414170546.1995982-1-cel@kernel.org> On Mon, Apr 14, 2025 at 01:05:42PM -0400, cel@kernel.org wrote: > From: Chuck Lever > > I'd like to be able to run more than one instance of kdevops per > physical host. Currently the kdevops guestfs set-up steers all > storage pool activity into ${STORAGE_POOL}/kdevops/guestfs, which > means there's a good change that two different logged-in users will > create virtual machines whose names, OS base images, and block > devices will interfere with each other. > > So far I haven't been able to get the other storage pool-related > settings to add sufficient uniqueness to prevent this conflict. > > v2 introduces some additional clean-ups, and attempts to address > review comments. I gave this a spin to see if exisitng deployments won't break but they would right away: Here is me running on a debian system where we had the old setup: make defconfig-seltests-radix-tree KDEVOPS_HOSTS_PREFIX=x2 make -j128 make bringup User mcgrof is part of the libvirt-qemu group. .//scripts/bringup_guestfs.sh: line 276: [: too many arguments cp: target '}}/guestfs/x2-maple/root.raw': No such file or directory Extra parameter on the command line: ‘libvirt_storage_pool_path’. Try ‘virt-sysprep --help’ or consult virt-sysprep(1) for more information. Formatting '{{ libvirt_storage_pool_path }}/{{ kdevops_storage_pool_user }}/guestfs/x2-maple/extra0.raw', fmt=raw size=107374182400 chmod: cannot access '{{': No such file or directory chmod: cannot access 'libvirt_storage_pool_path': No such file or directory chmod: cannot access '}}/{{': No such file or directory chmod: cannot access 'kdevops_storage_pool_user': No such file or directory chmod: cannot access '}}/guestfs/x2-maple/extra0.raw': No such file or directory Formatting '{{ libvirt_storage_pool_path }}/{{ kdevops_storage_pool_user }}/guestfs/x2-maple/extra1.raw', fmt=raw size=107374182400 chmod: cannot access '{{': No such file or directory chmod: cannot access 'libvirt_storage_pool_path': No such file or directory chmod: cannot access '}}/{{': No such file or directory chmod: cannot access 'kdevops_storage_pool_user': No such file or directory chmod: cannot access '}}/guestfs/x2-maple/extra1.raw': No such file or directory Formatting '{{ libvirt_storage_pool_path }}/{{ kdevops_storage_pool_user }}/guestfs/x2-maple/extra2.raw', fmt=raw size=107374182400 chmod: cannot access '{{': No such file or directory chmod: cannot access 'libvirt_storage_pool_path': No such file or directory chmod: cannot access '}}/{{': No such file or directory chmod: cannot access 'kdevops_storage_pool_user': No such file or directory chmod: cannot access '}}/guestfs/x2-maple/extra2.raw': No such file or directory Formatting '{{ libvirt_storage_pool_path }}/{{ kdevops_storage_pool_user }}/guestfs/x2-maple/extra3.raw', fmt=raw size=107374182400 chmod: cannot access '{{': No such file or directory chmod: cannot access 'libvirt_storage_pool_path': No such file or directory chmod: cannot access '}}/{{': No such file or directory chmod: cannot access 'kdevops_storage_pool_user': No such file or directory chmod: cannot access '}}/guestfs/x2-maple/extra3.raw': No such file or directory Domain 'x2-maple' defined from .//guestfs/x2-maple/x2-maple.xml error: Failed to start domain 'x2-maple' error: Cannot access storage file '/xfs1/libvirt/mcgrof/guestfs/x2-maple/root.raw': No such file or directory Failed to start x2-maple make: *** [scripts/guestfs.Makefile:80: bringup_guestfs] Error 1 So, while I like the idea and approach, this would break tons of deployments right now. Luis