Re: [PATCH v3 1/1] guestfs: Per-user storage pools

[Luis Chamberlain <mcgrof@kernel.org>]

On Wed, Apr 23, 2025 at 10:20:09AM -0400, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
> 
> I'd like to be able to run more than one instance of kdevops per
> physical host. Currently the kdevops guestfs set-up steers all
> storage pool activity into ${STORAGE_POOL}/kdevops/guestfs, which
> means there's a good change that two different logged-in users will
> create virtual machines whose names (and block devices) conflict.
> 
> So far I haven't been able to get the other storage pool-related
> settings to add sufficient uniqueness to prevent this conflict.
> 
> Instead, replace the "kdevops" string in the storage pool path with
> the name of the user account running kdevops.
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>  kconfigs/Kconfig.libvirt   | 2 +-
>  scripts/bringup_guestfs.sh | 2 +-
>  scripts/destroy_guestfs.sh | 2 +-
>  scripts/guestfs.Makefile   | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/kconfigs/Kconfig.libvirt b/kconfigs/Kconfig.libvirt
> index cba8abf1e24b..74a93f177732 100644
> --- a/kconfigs/Kconfig.libvirt
> +++ b/kconfigs/Kconfig.libvirt
> @@ -167,7 +167,7 @@ config LIBVIRT_STORAGE_POOL_PATH
>  config KDEVOPS_STORAGE_POOL_PATH
>  	string
>  	output yaml
> -	default "{{ libvirt_storage_pool_path }}/kdevops"
> +	default "{{ libvirt_storage_pool_path }}/{{ kdevops_storage_pool_user }}"

So what I meant with my feedbakc was to make this an option. So for
instance you can add a new Kconfig choice and the default
KDEVOPS_STORAGE_POOL_USER_COMPAT and when that's true we 
default KDEVOPS_STORAGE_POOL_USER to "kdevops", otherwise it calls
if KDEVOPS_STORAGE_POOL_USER_AUTO is set then the default is $USER.

Then you can wackamole these two lines too:

scripts/guestfs.Makefile:GUESTFS_ARGS += kdevops_storage_pool_user='$(USER)'
scripts/vagrant.Makefile:VAGRANT_ARGS += kdevops_storage_pool_user='$(USER)'

By making KDEVOPS_STORAGE_POOL_USER_COMPAT default it would work with
existing deployments.

  Luis