From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 037D925C82C for ; Wed, 23 Apr 2025 19:51:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745437918; cv=none; b=GJtXVqZm0lRUGMK/edfvQBVZNsfJ52oXvLuhGalIftAIC5V8h9U8WFQLX7kd9DYdxosbcpAPTgE6FFLc9Ubu7PiXPxWPKlNl2TRSgnN5I6TEk+UCOnbRCtBEgRuNmjT/HhShn2UeBj2ZD+VX1M5/CAfiqvoIXmMkOpJ+dsivzb8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745437918; c=relaxed/simple; bh=weJvXhdzExJ15gh6JY4+5umPza0sRi/td/IniHzo2V0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mN5BhDLQec3f3RmVOXOd2WkhTYKh5KvN7QCRvUKjFVmWiKWlmHxCh6g7byp9Wg7i/7Xu2W02qeYpo2ZVf5J8Tg1EEnsOUvAKR9F7HRp4kQWw53adU43hNlAkA2GpYUITPRTojTl45jx39zjHuRiNg4tjSznpMCJ1Xqcq5IBFPXY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jsoLm8QZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jsoLm8QZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB2A0C4CEE2; Wed, 23 Apr 2025 19:51:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745437917; bh=weJvXhdzExJ15gh6JY4+5umPza0sRi/td/IniHzo2V0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jsoLm8QZ0bCAaEKIXAgv+Jt/Zq0+14hzHXaylx6agvoCLF0OohuWa4jntQZjVQys2 gY3GH7BXtKn5jzUJCh//x45b6RpF3VZ8dHSfrd0Or7vI6O5N4uVTFpLnqeE6bQxiW3 CopQvMIUYCSUY9Wo5z0kHqG4UJs5xruJULAym401O42tY1VDbqt3hj5rz3J/o7I94Z 8yZhDkUbWmfzwwHxIlhuLhBX5iKB+WFa0W07TlO//DqFFY/pmjvxsXICyl9kLXlE2V /R5Cz3oS6VjmjhxIa+MIDcv4xiyTfbaDLzGNnoRSivtL741Qa1GxPRMjAo6TKHvgmY NJ7NJxQ5ZVSWw== Date: Wed, 23 Apr 2025 12:51:56 -0700 From: Luis Chamberlain To: Daniel Gomez Cc: kdevops@lists.linux.dev, Daniel Gomez Subject: Re: [PATCH] bringup_guestfs: fix group permissions for disks Message-ID: References: <20250423-fix-permissions-disks-v1-1-c440f83507f2@samsung.com> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250423-fix-permissions-disks-v1-1-c440f83507f2@samsung.com> On Wed, Apr 23, 2025 at 07:34:48PM +0000, Daniel Gomez wrote: > From: Daniel Gomez > > Ensure libvirt-qemu group permissions are set to qemu image disks when > on libvirt system uri. > > Permissions before: > namei --long /var/lib/libvirt/images/kdevops/guestfs/debian13/extra0.raw > > f: /var/lib/libvirt/images/kdevops/guestfs/debian13/extra0.raw > drwxr-xr-x root root / > drwxr-xr-x root root var > drwxr-xr-x root root lib > drwxr-xr-x root libvirt-qemu libvirt > drwxrwxr-x root libvirt-qemu images > drwxrwxr-x root libvirt-qemu kdevops > drwxrwxr-x root libvirt-qemu guestfs > drwxrwxr-x dagomez dagomez debian13 > -rw-rw-r-- dagomez dagomez extra0.raw > > Permissions after: > > f: /var/lib/libvirt/images/kdevops/guestfs/debian13/extra0.raw > drwxr-xr-x root root / > drwxr-xr-x root root var > drwxr-xr-x root root lib > drwxr-xr-x root libvirt-qemu libvirt > drwxrwsr-x root libvirt-qemu images > drwxrwsr-x root libvirt-qemu kdevops > drwxrwsr-x root libvirt-qemu guestfs > drwxrwsr-x dagomez libvirt-qemu debian13 > -rw-rw-r-- dagomez libvirt-qemu extra0.raw > > libvirt permission error: > > make bringup > {...} > .//scripts/bringup_guestfs.sh > User dagomez is part of the libvirt-qemu group. > [ 0.0] Examining the guest ... > {...} > [ 5.1] SELinux relabelling > [ 5.1] Performing "lvm-uuids" ... > Formatting '/var/lib/libvirt/images/kdevops/guestfs/debian13/extra0.raw', > fmt=raw size=107374182400 > Formatting '/var/lib/libvirt/images/kdevops/guestfs/debian13/extra1.raw', > fmt=raw size=107374182400 > Formatting '/var/lib/libvirt/images/kdevops/guestfs/debian13/extra2.raw', > fmt=raw size=107374182400 > Formatting '/var/lib/libvirt/images/kdevops/guestfs/debian13/extra3.raw', > fmt=raw size=107374182400 > Domain 'debian13' defined from .//guestfs/debian13/debian13.xml > > error: Failed to start domain 'debian13' > error: internal error: QEMU unexpectedly closed the monitor > (vm='debian13'): 2025-04-23T14:17:23.707308Z qemu-system-x86_64: -device > virtio-blk-pci,drive=drv0,id=virtio-drv0,serial=kdevops0,bus= > pcie-port-for-virtio-0,addr=0x0,iothread=kdevops-virtio-iothread-0, > logical_block_size=512,physical_block_size=512: Could not open > '/var/lib/libvirt/images/kdevops/guestfs/debian13/extra0.raw': > Permission denied > > Failed to start debian13 > make: *** [scripts/guestfs.Makefile:80: bringup_guestfs] Error 1 > > Signed-off-by: Daniel Gomez Reviewed-by: Luis Chamberlain Luis