Re: [PATCH] gen_node: add debugger support for guestfs libvirt guests

[Luis Chamberlain <mcgrof@kernel.org>]

Nice!

On Thu, Apr 24, 2025 at 04:58:09PM +0000, Swarna Prabhu wrote:
> +config LIBVIRT_ENABLE_GDB
> +    bool "Enable GDB debugging for the guest"
> +	output yaml

> +- name: Find if port conflict occur
> +  ansible.builtin.shell: "ss -ltn | grep ':{{ (libvirt_gdb_baseport | int) + (idx | int) }} '"
> +  register: gdb_port_reg
> +  failed_when: false
> +  changed_when: false
> +  loop: "{{ guestfs_nodes }}"
> +  loop_control:
> +    index_var: idx
> +  when:
> +    - kdevops_enable_guestfs|bool

This needs to be:

when:
 - libvirt_enable_gdb|bool
 - kdevops_enable_guestfs|bool

> +
> +- name: Set the conflict flag on if conflict occur
> +  set_fact:
> +    gdb_port_conflict: True
> +  when: >
> +    gdb_port_reg.results is defined and
> +    gdb_port_reg.results | selectattr('rc', 'equalto', 0) | list | length > 0

Same here and we need to use a flat entry per line so

  when:                                                                          
    - libvirt_enable_gdb|bool                                                    
    - gdb_port_reg.results is defined                                            
    - gdb_port_reg.results | selectattr('rc', 'equalto', 0) | list | length > 0 

> +- name: Fail bringup if gdb port conflict occur
> +  fail:
> +    msg: "GDB port conflict occur, please check the base port number {{ libvirt_gdb_baseport }} and try with another"
> +  when: gdb_port_conflict|bool

And here.

I made those small changes to your patch and pushed to the test throw
away kdevops tree, kdevops-kpd, which let's us trigger tests on both
containers and bare metal. The results are ephemeral, in that we can
ignore these tests for production. The test has been scheduled:

https://github.com/linux-kdevops/kdevops-kpd/actions/runs/14647807925

If that passes then I'll merge this! Thanks!

  Luis