From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16F5D284681 for ; Thu, 24 Apr 2025 17:28:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745515733; cv=none; b=RuoOmWB7NTEMOQwVEKvyuRxaW3ez9f3U7Ca5aerT1BS+OptHcrtJxKWGZb8fbfVKuRgAR46LYmncaiZx3anmBBUoAlsu6xbA9fQVI8vKG7OgqaRYFkz6KRhM2o9pyx6AIbGzdRwra7EwjJ6QjtyX3dlzZrK3DRQi11bx7KbfzFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745515733; c=relaxed/simple; bh=3SlhOb9TZSsG1LlkT2bPbRWm5diVIS6Eilu0kRfqC4c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n4QV1e8Av686FVqgwT8Klc+zGWu2YlS2qEOOTiDEcZD2E69esjveH1BbZufUaWZgwd7LBjCUOFHMwpxm2k5ENlw9KKeth3L0SFthemFNw5jNW9reAN5w4y05E8af/7Zej225DcOTcxfFACLNq3lWdFU/ofz4HEQAXWC2RvOIiKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G6o0qVL1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G6o0qVL1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7ECA6C4CEE3; Thu, 24 Apr 2025 17:28:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745515732; bh=3SlhOb9TZSsG1LlkT2bPbRWm5diVIS6Eilu0kRfqC4c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G6o0qVL1ap2y5YsebCe9BGYj3GD8eRtNdLqmySN0S7Gk3e7DeIujGUQemuTS8ZRxU TI0s/rOF/Ball++a9Vh64622D7Oiiv1Xjtz/b5ezf8a102gbVV9fFXG0qN+G2nn69v +JvNtc6UUGwSOSwOaSf+G2DEe7GqNUGzOTW9rGkOqMIWWSeCR6uHLcqaziIXxhz50H xyYnRjw/lxD4XOy/Q8H9CyHrma8RLbViCvSKos9Sl4SMpW+DvUPxNiKnIlX1gq26FE S++PVkmcfPAJRiWyTz5NAfSuEMF1WnHI2mSeOMilpsn+x2GTsnjE/kzbNVYgNMdnYv 30UQPV0Sd7QjQ== Date: Thu, 24 Apr 2025 10:28:51 -0700 From: Luis Chamberlain To: Swarna Prabhu Cc: kdevops@lists.linux.dev, da.gomez@samsung.com, Swarna Prabhu Subject: Re: [PATCH] gen_node: add debugger support for guestfs libvirt guests Message-ID: References: <20250424165809.2576146-1-s.prabhu@samsung.com> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250424165809.2576146-1-s.prabhu@samsung.com> Nice! On Thu, Apr 24, 2025 at 04:58:09PM +0000, Swarna Prabhu wrote: > +config LIBVIRT_ENABLE_GDB > + bool "Enable GDB debugging for the guest" > + output yaml > +- name: Find if port conflict occur > + ansible.builtin.shell: "ss -ltn | grep ':{{ (libvirt_gdb_baseport | int) + (idx | int) }} '" > + register: gdb_port_reg > + failed_when: false > + changed_when: false > + loop: "{{ guestfs_nodes }}" > + loop_control: > + index_var: idx > + when: > + - kdevops_enable_guestfs|bool This needs to be: when: - libvirt_enable_gdb|bool - kdevops_enable_guestfs|bool > + > +- name: Set the conflict flag on if conflict occur > + set_fact: > + gdb_port_conflict: True > + when: > > + gdb_port_reg.results is defined and > + gdb_port_reg.results | selectattr('rc', 'equalto', 0) | list | length > 0 Same here and we need to use a flat entry per line so when: - libvirt_enable_gdb|bool - gdb_port_reg.results is defined - gdb_port_reg.results | selectattr('rc', 'equalto', 0) | list | length > 0 > +- name: Fail bringup if gdb port conflict occur > + fail: > + msg: "GDB port conflict occur, please check the base port number {{ libvirt_gdb_baseport }} and try with another" > + when: gdb_port_conflict|bool And here. I made those small changes to your patch and pushed to the test throw away kdevops tree, kdevops-kpd, which let's us trigger tests on both containers and bare metal. The results are ephemeral, in that we can ignore these tests for production. The test has been scheduled: https://github.com/linux-kdevops/kdevops-kpd/actions/runs/14647807925 If that passes then I'll merge this! Thanks! Luis