From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3C84289835 for ; Wed, 7 May 2025 17:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746640362; cv=none; b=sSh2uULNLnG7qp2WLDgYXQItrDR0blTH5Clfma5sVQHxiVAOlGbk0gDnjA9v1wsd+a3yJrD1GHkq7mXZb7OqdAX+fMCM+NIupK2p8t5KGnMMw6TbtgIUiwBboE1ymGgouR+R8CGv8KF47qNb2XVgskM46scMSfr+CvGGP1yl96I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746640362; c=relaxed/simple; bh=Ddnm7byWpICvT26Ikn1XOQO4ZarrYZgdmkVN9KQ6VvA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tQfR5nuM7u63ZnzKLG3YrVT8tJpn2OAok3KjMkk0r88OrY8dX4inXmbQDFc+RxnTYQvTif8+X4Wdpi2ptED246vnGdAiHikFVXlPmgT7cgYPV6X8eXPDJLHt9zlWsr5kRDBtLIZdkw6WXgLTiB+108zK+nJjDZ+bsaz384ZdhU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GfoMYD7f; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GfoMYD7f" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BD76C4CEE2; Wed, 7 May 2025 17:52:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746640361; bh=Ddnm7byWpICvT26Ikn1XOQO4ZarrYZgdmkVN9KQ6VvA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GfoMYD7f15IDpLeQsIsVlotEgm9LWLyLgFqVd/Dq2s6SZBPkLxaRv/pMKxDCuCAxx a9kWABgfz7MjEnfBCMmLdF08HxKNY2b0PG5v49VJYA874cjZ0Kq6p7XWW8Rc9krpTm 7pfh9eu9CAKjq9KZpGYHNvgkEXO0+C3o/YaMC8SJ8h8h6UEA5kt1Dfq3TPJ4ipOzPl Ek6jc3T40oPNvV1EMrcUs6BwuSVgQ5d+fPAb5rLHWjcV4H+lVxYxlGtm0wx6HHWG13 DYVYqqbyVgMuXcvbhjnYIhR7MQQ/qASzJgkzBVlufO8llsnAaDf75/0+5kc/0O1/O2 iA2vBo2B85pPQ== Date: Wed, 7 May 2025 10:52:39 -0700 From: Luis Chamberlain To: Chuck Lever Cc: Chandan Babu R , kdevops@lists.linux.dev Subject: Re: [PATCH] terraform/oci: Add VM.Standard.x86.Generic shape to available options Message-ID: References: <20250507095522.1027554-1-chandanbabu@kernel.org> <0081c933-a6b3-4caa-83f3-f1a1fa53fff7@oracle.com> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0081c933-a6b3-4caa-83f3-f1a1fa53fff7@oracle.com> On Wed, May 07, 2025 at 01:33:07PM -0400, Chuck Lever wrote: > On 5/7/25 1:05 PM, Luis Chamberlain wrote: > > On Wed, May 07, 2025 at 03:25:16PM +0530, Chandan Babu R wrote: > >> The VM.Standard.x86.Generic is another shape available for Oracle Linux kernel > >> developers. This commit adds this shape to the list of available flexible > >> shapes. > >> > >> Signed-off-by: Chandan Babu R > >> --- > >> Chuck, > >> > >> Kconfig's "choice" construct does not allow "free text" to be > >> entered. Hence, I had to add the new entry as a choice. > > > > You can resolve this as follows? > > > > diff --git a/terraform/oci/kconfigs/shapes/Kconfig.flex b/terraform/oci/kconfigs/shapes/Kconfig.flex > > index c2b3f5719c48..e8d0860aac67 100644 > > --- a/terraform/oci/kconfigs/shapes/Kconfig.flex > > +++ b/terraform/oci/kconfigs/shapes/Kconfig.flex > > @@ -73,6 +73,7 @@ endchoice > > config TERRAFORM_OCI_SHAPE > > string > > output yaml > > + default "VM.Standard.x86.Generic" if TERRAFORM_OCI_SHAPE_VM_STANDARD_X86_GENERIC > > default "VM.Standard3.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD3_FLEX > > default "VM.Standard.E4.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E4_FLEX > > default "VM.Standard.E5.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E5_FLEX > > I'm able to select the VM.Standard.x86.Generic shape by going to > > Bring up methods -> Node bring up methods > > Choose Terraform then OCI, then > > Compute -> OCI shape family > > and choose "Generic" > > Is that not working? Oh never mind, I thought Chandan had an issue with using kconfig choice to map to string. If the respective string is already populated my recomendaiton is nonsense :) Luis