* [PATCH] terraform/oci: Add VM.Standard.x86.Generic shape to available options @ 2025-05-07 9:55 Chandan Babu R 2025-05-07 13:56 ` Chuck Lever 2025-05-07 17:05 ` Luis Chamberlain 0 siblings, 2 replies; 8+ messages in thread From: Chandan Babu R @ 2025-05-07 9:55 UTC (permalink / raw) To: kdevops; +Cc: Chandan Babu R, chuck.lever The VM.Standard.x86.Generic is another shape available for Oracle Linux kernel developers. This commit adds this shape to the list of available flexible shapes. Signed-off-by: Chandan Babu R <chandanbabu@kernel.org> --- Chuck, Kconfig's "choice" construct does not allow "free text" to be entered. Hence, I had to add the new entry as a choice. Also, I did not find any official documentation for VM.Standard.x86.Generic. The limits for OCPUs and memory were obtained from the web console which is used during the creation of a VM. terraform/oci/kconfigs/shapes/Kconfig.flex | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/terraform/oci/kconfigs/shapes/Kconfig.flex b/terraform/oci/kconfigs/shapes/Kconfig.flex index 67d50604..c2b3f571 100644 --- a/terraform/oci/kconfigs/shapes/Kconfig.flex +++ b/terraform/oci/kconfigs/shapes/Kconfig.flex @@ -9,6 +9,13 @@ choice https://docs.oracle.com/en-us/iaas/Content/Compute/References/computeshapes.htm#flexible +config TERRAFORM_OCI_SHAPE_VM_STANDARD_X86_GENERIC + bool "VM.Standard.x86.Generic" + depends on TARGET_ARCH_X86_64 + help + Selecting this option provisions each guest with between 1 + and 32 OCPUs (physical cores) and up to 512MB of memory. + config TERRAFORM_OCI_SHAPE_VM_STANDARD3_FLEX bool "VM.Standard3.Flex" depends on TARGET_ARCH_X86_64 -- 2.45.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] terraform/oci: Add VM.Standard.x86.Generic shape to available options 2025-05-07 9:55 [PATCH] terraform/oci: Add VM.Standard.x86.Generic shape to available options Chandan Babu R @ 2025-05-07 13:56 ` Chuck Lever 2025-05-07 17:05 ` Luis Chamberlain 1 sibling, 0 replies; 8+ messages in thread From: Chuck Lever @ 2025-05-07 13:56 UTC (permalink / raw) To: Chandan Babu R, kdevops On 5/7/25 5:55 AM, Chandan Babu R wrote: > The VM.Standard.x86.Generic is another shape available for Oracle Linux kernel > developers. This commit adds this shape to the list of available flexible > shapes. > > Signed-off-by: Chandan Babu R <chandanbabu@kernel.org> > --- > Chuck, > > Kconfig's "choice" construct does not allow "free text" to be > entered. Hence, I had to add the new entry as a choice. > > Also, I did not find any official documentation for > VM.Standard.x86.Generic. The limits for OCPUs and memory were obtained > from the web console which is used during the creation of a VM. I don't understand. Is there a problem with commit 0283fcd8dc6f ("terraform/OCI: Add a generic shape selector") ? > terraform/oci/kconfigs/shapes/Kconfig.flex | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/terraform/oci/kconfigs/shapes/Kconfig.flex b/terraform/oci/kconfigs/shapes/Kconfig.flex > index 67d50604..c2b3f571 100644 > --- a/terraform/oci/kconfigs/shapes/Kconfig.flex > +++ b/terraform/oci/kconfigs/shapes/Kconfig.flex > @@ -9,6 +9,13 @@ choice > > https://docs.oracle.com/en-us/iaas/Content/Compute/References/computeshapes.htm#flexible > > +config TERRAFORM_OCI_SHAPE_VM_STANDARD_X86_GENERIC > + bool "VM.Standard.x86.Generic" > + depends on TARGET_ARCH_X86_64 > + help > + Selecting this option provisions each guest with between 1 > + and 32 OCPUs (physical cores) and up to 512MB of memory. > + > config TERRAFORM_OCI_SHAPE_VM_STANDARD3_FLEX > bool "VM.Standard3.Flex" > depends on TARGET_ARCH_X86_64 -- Chuck Lever ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] terraform/oci: Add VM.Standard.x86.Generic shape to available options 2025-05-07 9:55 [PATCH] terraform/oci: Add VM.Standard.x86.Generic shape to available options Chandan Babu R 2025-05-07 13:56 ` Chuck Lever @ 2025-05-07 17:05 ` Luis Chamberlain 2025-05-07 17:33 ` Chuck Lever 1 sibling, 1 reply; 8+ messages in thread From: Luis Chamberlain @ 2025-05-07 17:05 UTC (permalink / raw) To: Chandan Babu R; +Cc: kdevops, chuck.lever On Wed, May 07, 2025 at 03:25:16PM +0530, Chandan Babu R wrote: > The VM.Standard.x86.Generic is another shape available for Oracle Linux kernel > developers. This commit adds this shape to the list of available flexible > shapes. > > Signed-off-by: Chandan Babu R <chandanbabu@kernel.org> > --- > Chuck, > > Kconfig's "choice" construct does not allow "free text" to be > entered. Hence, I had to add the new entry as a choice. You can resolve this as follows? diff --git a/terraform/oci/kconfigs/shapes/Kconfig.flex b/terraform/oci/kconfigs/shapes/Kconfig.flex index c2b3f5719c48..e8d0860aac67 100644 --- a/terraform/oci/kconfigs/shapes/Kconfig.flex +++ b/terraform/oci/kconfigs/shapes/Kconfig.flex @@ -73,6 +73,7 @@ endchoice config TERRAFORM_OCI_SHAPE string output yaml + default "VM.Standard.x86.Generic" if TERRAFORM_OCI_SHAPE_VM_STANDARD_X86_GENERIC default "VM.Standard3.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD3_FLEX default "VM.Standard.E4.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E4_FLEX default "VM.Standard.E5.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E5_FLEX ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] terraform/oci: Add VM.Standard.x86.Generic shape to available options 2025-05-07 17:05 ` Luis Chamberlain @ 2025-05-07 17:33 ` Chuck Lever 2025-05-07 17:52 ` Luis Chamberlain 0 siblings, 1 reply; 8+ messages in thread From: Chuck Lever @ 2025-05-07 17:33 UTC (permalink / raw) To: Chandan Babu R; +Cc: kdevops, Luis Chamberlain On 5/7/25 1:05 PM, Luis Chamberlain wrote: > On Wed, May 07, 2025 at 03:25:16PM +0530, Chandan Babu R wrote: >> The VM.Standard.x86.Generic is another shape available for Oracle Linux kernel >> developers. This commit adds this shape to the list of available flexible >> shapes. >> >> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org> >> --- >> Chuck, >> >> Kconfig's "choice" construct does not allow "free text" to be >> entered. Hence, I had to add the new entry as a choice. > > You can resolve this as follows? > > diff --git a/terraform/oci/kconfigs/shapes/Kconfig.flex b/terraform/oci/kconfigs/shapes/Kconfig.flex > index c2b3f5719c48..e8d0860aac67 100644 > --- a/terraform/oci/kconfigs/shapes/Kconfig.flex > +++ b/terraform/oci/kconfigs/shapes/Kconfig.flex > @@ -73,6 +73,7 @@ endchoice > config TERRAFORM_OCI_SHAPE > string > output yaml > + default "VM.Standard.x86.Generic" if TERRAFORM_OCI_SHAPE_VM_STANDARD_X86_GENERIC > default "VM.Standard3.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD3_FLEX > default "VM.Standard.E4.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E4_FLEX > default "VM.Standard.E5.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E5_FLEX I'm able to select the VM.Standard.x86.Generic shape by going to Bring up methods -> Node bring up methods Choose Terraform then OCI, then Compute -> OCI shape family and choose "Generic" Is that not working? -- Chuck Lever ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] terraform/oci: Add VM.Standard.x86.Generic shape to available options 2025-05-07 17:33 ` Chuck Lever @ 2025-05-07 17:52 ` Luis Chamberlain 2025-05-08 13:07 ` Chandan Babu R 0 siblings, 1 reply; 8+ messages in thread From: Luis Chamberlain @ 2025-05-07 17:52 UTC (permalink / raw) To: Chuck Lever; +Cc: Chandan Babu R, kdevops On Wed, May 07, 2025 at 01:33:07PM -0400, Chuck Lever wrote: > On 5/7/25 1:05 PM, Luis Chamberlain wrote: > > On Wed, May 07, 2025 at 03:25:16PM +0530, Chandan Babu R wrote: > >> The VM.Standard.x86.Generic is another shape available for Oracle Linux kernel > >> developers. This commit adds this shape to the list of available flexible > >> shapes. > >> > >> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org> > >> --- > >> Chuck, > >> > >> Kconfig's "choice" construct does not allow "free text" to be > >> entered. Hence, I had to add the new entry as a choice. > > > > You can resolve this as follows? > > > > diff --git a/terraform/oci/kconfigs/shapes/Kconfig.flex b/terraform/oci/kconfigs/shapes/Kconfig.flex > > index c2b3f5719c48..e8d0860aac67 100644 > > --- a/terraform/oci/kconfigs/shapes/Kconfig.flex > > +++ b/terraform/oci/kconfigs/shapes/Kconfig.flex > > @@ -73,6 +73,7 @@ endchoice > > config TERRAFORM_OCI_SHAPE > > string > > output yaml > > + default "VM.Standard.x86.Generic" if TERRAFORM_OCI_SHAPE_VM_STANDARD_X86_GENERIC > > default "VM.Standard3.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD3_FLEX > > default "VM.Standard.E4.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E4_FLEX > > default "VM.Standard.E5.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E5_FLEX > > I'm able to select the VM.Standard.x86.Generic shape by going to > > Bring up methods -> Node bring up methods > > Choose Terraform then OCI, then > > Compute -> OCI shape family > > and choose "Generic" > > Is that not working? Oh never mind, I thought Chandan had an issue with using kconfig choice to map to string. If the respective string is already populated my recomendaiton is nonsense :) Luis ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] terraform/oci: Add VM.Standard.x86.Generic shape to available options 2025-05-07 17:52 ` Luis Chamberlain @ 2025-05-08 13:07 ` Chandan Babu R 2025-05-08 13:11 ` Chuck Lever 0 siblings, 1 reply; 8+ messages in thread From: Chandan Babu R @ 2025-05-08 13:07 UTC (permalink / raw) To: Chuck Lever; +Cc: Luis Chamberlain, kdevops On Wed, May 07, 2025 at 10:52:39 AM -0700, Luis Chamberlain wrote: > On Wed, May 07, 2025 at 01:33:07PM -0400, Chuck Lever wrote: >> On 5/7/25 1:05 PM, Luis Chamberlain wrote: >> > On Wed, May 07, 2025 at 03:25:16PM +0530, Chandan Babu R wrote: >> >> The VM.Standard.x86.Generic is another shape available for Oracle Linux kernel >> >> developers. This commit adds this shape to the list of available flexible >> >> shapes. >> >> >> >> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org> >> >> --- >> >> Chuck, >> >> >> >> Kconfig's "choice" construct does not allow "free text" to be >> >> entered. Hence, I had to add the new entry as a choice. >> > >> > You can resolve this as follows? >> > >> > diff --git a/terraform/oci/kconfigs/shapes/Kconfig.flex b/terraform/oci/kconfigs/shapes/Kconfig.flex >> > index c2b3f5719c48..e8d0860aac67 100644 >> > --- a/terraform/oci/kconfigs/shapes/Kconfig.flex >> > +++ b/terraform/oci/kconfigs/shapes/Kconfig.flex >> > @@ -73,6 +73,7 @@ endchoice >> > config TERRAFORM_OCI_SHAPE >> > string >> > output yaml >> > + default "VM.Standard.x86.Generic" if TERRAFORM_OCI_SHAPE_VM_STANDARD_X86_GENERIC >> > default "VM.Standard3.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD3_FLEX >> > default "VM.Standard.E4.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E4_FLEX >> > default "VM.Standard.E5.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E5_FLEX >> >> I'm able to select the VM.Standard.x86.Generic shape by going to >> >> Bring up methods -> Node bring up methods >> >> Choose Terraform then OCI, then >> >> Compute -> OCI shape family >> >> and choose "Generic" >> >> Is that not working? > > Oh never mind, I thought Chandan had an issue with using kconfig choice > to map to string. If the respective string is already populated my > recomendaiton is nonsense :) > Sorry, it was my mistake. I did not check the options under "Generic Shapes". Sorry once again. -- Chandan ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] terraform/oci: Add VM.Standard.x86.Generic shape to available options 2025-05-08 13:07 ` Chandan Babu R @ 2025-05-08 13:11 ` Chuck Lever 2025-05-08 14:27 ` Chandan Babu R 0 siblings, 1 reply; 8+ messages in thread From: Chuck Lever @ 2025-05-08 13:11 UTC (permalink / raw) To: Chandan Babu R; +Cc: Luis Chamberlain, kdevops On 5/8/25 9:07 AM, Chandan Babu R wrote: > On Wed, May 07, 2025 at 10:52:39 AM -0700, Luis Chamberlain wrote: >> On Wed, May 07, 2025 at 01:33:07PM -0400, Chuck Lever wrote: >>> On 5/7/25 1:05 PM, Luis Chamberlain wrote: >>>> On Wed, May 07, 2025 at 03:25:16PM +0530, Chandan Babu R wrote: >>>>> The VM.Standard.x86.Generic is another shape available for Oracle Linux kernel >>>>> developers. This commit adds this shape to the list of available flexible >>>>> shapes. >>>>> >>>>> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org> >>>>> --- >>>>> Chuck, >>>>> >>>>> Kconfig's "choice" construct does not allow "free text" to be >>>>> entered. Hence, I had to add the new entry as a choice. >>>> >>>> You can resolve this as follows? >>>> >>>> diff --git a/terraform/oci/kconfigs/shapes/Kconfig.flex b/terraform/oci/kconfigs/shapes/Kconfig.flex >>>> index c2b3f5719c48..e8d0860aac67 100644 >>>> --- a/terraform/oci/kconfigs/shapes/Kconfig.flex >>>> +++ b/terraform/oci/kconfigs/shapes/Kconfig.flex >>>> @@ -73,6 +73,7 @@ endchoice >>>> config TERRAFORM_OCI_SHAPE >>>> string >>>> output yaml >>>> + default "VM.Standard.x86.Generic" if TERRAFORM_OCI_SHAPE_VM_STANDARD_X86_GENERIC >>>> default "VM.Standard3.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD3_FLEX >>>> default "VM.Standard.E4.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E4_FLEX >>>> default "VM.Standard.E5.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E5_FLEX >>> >>> I'm able to select the VM.Standard.x86.Generic shape by going to >>> >>> Bring up methods -> Node bring up methods >>> >>> Choose Terraform then OCI, then >>> >>> Compute -> OCI shape family >>> >>> and choose "Generic" >>> >>> Is that not working? >> >> Oh never mind, I thought Chandan had an issue with using kconfig choice >> to map to string. If the respective string is already populated my >> recomendaiton is nonsense :) >> > > Sorry, it was my mistake. I did not check the options under "Generic Shapes". > > Sorry once again. > It is perhaps not as obvious as it should be. -- Chuck Lever ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] terraform/oci: Add VM.Standard.x86.Generic shape to available options 2025-05-08 13:11 ` Chuck Lever @ 2025-05-08 14:27 ` Chandan Babu R 0 siblings, 0 replies; 8+ messages in thread From: Chandan Babu R @ 2025-05-08 14:27 UTC (permalink / raw) To: Chuck Lever; +Cc: Luis Chamberlain, kdevops On Thu, May 08, 2025 at 09:11:29 AM -0400, Chuck Lever wrote: > On 5/8/25 9:07 AM, Chandan Babu R wrote: >> On Wed, May 07, 2025 at 10:52:39 AM -0700, Luis Chamberlain wrote: >>> On Wed, May 07, 2025 at 01:33:07PM -0400, Chuck Lever wrote: >>>> On 5/7/25 1:05 PM, Luis Chamberlain wrote: >>>>> On Wed, May 07, 2025 at 03:25:16PM +0530, Chandan Babu R wrote: >>>>>> The VM.Standard.x86.Generic is another shape available for Oracle Linux kernel >>>>>> developers. This commit adds this shape to the list of available flexible >>>>>> shapes. >>>>>> >>>>>> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org> >>>>>> --- >>>>>> Chuck, >>>>>> >>>>>> Kconfig's "choice" construct does not allow "free text" to be >>>>>> entered. Hence, I had to add the new entry as a choice. >>>>> >>>>> You can resolve this as follows? >>>>> >>>>> diff --git a/terraform/oci/kconfigs/shapes/Kconfig.flex b/terraform/oci/kconfigs/shapes/Kconfig.flex >>>>> index c2b3f5719c48..e8d0860aac67 100644 >>>>> --- a/terraform/oci/kconfigs/shapes/Kconfig.flex >>>>> +++ b/terraform/oci/kconfigs/shapes/Kconfig.flex >>>>> @@ -73,6 +73,7 @@ endchoice >>>>> config TERRAFORM_OCI_SHAPE >>>>> string >>>>> output yaml >>>>> + default "VM.Standard.x86.Generic" if TERRAFORM_OCI_SHAPE_VM_STANDARD_X86_GENERIC >>>>> default "VM.Standard3.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD3_FLEX >>>>> default "VM.Standard.E4.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E4_FLEX >>>>> default "VM.Standard.E5.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E5_FLEX >>>> >>>> I'm able to select the VM.Standard.x86.Generic shape by going to >>>> >>>> Bring up methods -> Node bring up methods >>>> >>>> Choose Terraform then OCI, then >>>> >>>> Compute -> OCI shape family >>>> >>>> and choose "Generic" >>>> >>>> Is that not working? >>> >>> Oh never mind, I thought Chandan had an issue with using kconfig choice >>> to map to string. If the respective string is already populated my >>> recomendaiton is nonsense :) >>> >> >> Sorry, it was my mistake. I did not check the options under "Generic Shapes". >> >> Sorry once again. >> > > It is perhaps not as obvious as it should be. The classification of shapes is correct. I somehow missed the "Generic" shape menu entry. -- Chandan ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-05-08 14:30 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-05-07 9:55 [PATCH] terraform/oci: Add VM.Standard.x86.Generic shape to available options Chandan Babu R 2025-05-07 13:56 ` Chuck Lever 2025-05-07 17:05 ` Luis Chamberlain 2025-05-07 17:33 ` Chuck Lever 2025-05-07 17:52 ` Luis Chamberlain 2025-05-08 13:07 ` Chandan Babu R 2025-05-08 13:11 ` Chuck Lever 2025-05-08 14:27 ` Chandan Babu R
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox