Re: [PATCH v2 0/4] guestfs: bringup: add debug mode

[Luis Chamberlain <mcgrof@kernel.org>]

On Mon, May 12, 2025 at 03:36:01PM +0200, Daniel Gomez wrote:
> This has helped me during debug sessions of bringup script. "Resend"
> with minor changes.
> 
> Adding debug option in bash bringup_guestfs.sh allows to check for
> commands executions (virsh, chmod, cp, virt-sysprep, etc) and variables.
> 
> Add 3 levels of debug:
> - Disabled: This is the current behaviour and is the default.
> - set -x (debug mode 0):  Allows to print the executed commands but if
> they fail, the script continues.
> - set -euxo pipefail (debug mode 1): mode 0 + variables are printed +
> script fails if a command does not succeed.
> 
> While debugging, I noticed about small bash errors that we ignore, such
> as unbound variables. So, this also fixes the issues found while debug
> mode 1 was enabled.
> 
> ---

Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>

 Luis