From: Luis Chamberlain <mcgrof@kernel.org>
To: Daniel Gomez <da.gomez@kernel.org>
Cc: Chuck Lever <cel@kernel.org>, Daniel Gomez <da.gomez@kruces.com>,
kdevops@lists.linux.dev
Subject: Re: [PATCH 1/2] gen_hosts: fix inventory path for dedicated mmtests workflow
Date: Wed, 13 Aug 2025 17:48:49 -0700 [thread overview]
Message-ID: <aJ0ycTcOxULWGCSp@bombadil.infradead.org> (raw)
In-Reply-To: <3d471375-130e-41e6-833d-f9c559fa0c13@kernel.org>
On Wed, Aug 13, 2025 at 02:40:29PM +0200, Daniel Gomez wrote:
> On 11/08/2025 17.42, Luis Chamberlain wrote:
> > The dedicated mmtests workflow generation was using kdevops_hosts
> > variable instead of ansible_cfg_inventory, causing the generated
> > hosts file to be placed in the wrong location. This resulted in
> > ansible not finding the correct inventory for mmtests runs.
> >
> > Use ansible_cfg_inventory which correctly points to the inventory
> > path configured in ansible.cfg, ensuring the generated hosts file
> > is placed where ansible expects it.
> >
> > Fixes: 0987c30034c995 ("gen_hosts: add initial support for dedicated mmtests workflow")
>
> The commit header description is wrong. It should be:
>
> Fixes: 0987c30034c9 ("Makefile: use inventory from ansible.cfg")
Funny!
> With that,
>
> Reviewed-by: Daniel Gomez <da.gomez@samsung.com>
Pushed!
Luis
next prev parent reply other threads:[~2025-08-14 0:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 0:42 [PATCH 0/2] mmtests-compare and minor fix Luis Chamberlain
2025-08-12 0:42 ` [PATCH 1/2] gen_hosts: fix inventory path for dedicated mmtests workflow Luis Chamberlain
2025-08-13 12:40 ` Daniel Gomez
2025-08-14 0:48 ` Luis Chamberlain [this message]
2025-08-12 0:42 ` [PATCH 2/2] mmtests: add AB testing and comparison support Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJ0ycTcOxULWGCSp@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=cel@kernel.org \
--cc=da.gomez@kernel.org \
--cc=da.gomez@kruces.com \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox