Re: [PATCH v2] workflows: add fio-tests performance tests

[Luis Chamberlain <mcgrof@kernel.org>]

On Tue, Aug 26, 2025 at 09:18:37PM +0200, Daniel Gomez wrote:
> On 21/08/2025 23.28, Luis Chamberlain wrote:
> > diff --git a/workflows/fio-tests/Makefile b/workflows/fio-tests/Makefile
> > new file mode 100644
> > index 000000000000..cc641606e98c
> > --- /dev/null
> > +++ b/workflows/fio-tests/Makefile
> > @@ -0,0 +1,68 @@
> > +ifeq (y,$(CONFIG_WORKFLOWS_DEDICATED_WORKFLOW))
> > +export KDEVOPS_HOSTS_TEMPLATE := fio-tests.j2
> > +endif
> > +
> > +fio-tests:
> > +	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \
> > +		--connection=ssh \
> > +		--inventory hosts \
> > +		--extra-vars=@$(KDEVOPS_EXTRA_VARS) \
> > +		playbooks/fio-tests.yml \
> > +		$(LIMIT_HOSTS)
> 
> I missed this...
> 
> The --connection and --inventory arguments shouldn't be necessary. They are
> managed by the inventory (hosts) file itself and the ansible.cfg.
> 
> Can you add a cleanup patch on top so it's consistent with the rest of the 
> wrappers?

Pushed.

> FYI, in future cleanups, I'd also like to get rid of the ANSIBLE_VERBOSE and
> control it through ansible.cfg (key: vebosity) [1] and expose it as kconfig
> option.
> 
> Link: https://docs.ansible.com/ansible/latest/reference_appendices/config.html#default-verbosity [1]
> 
> This should apply to all the ansible-playbook wrappers added.

OK, well until then I'll keep it for now.

  Luis