public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Daniel Gomez <da.gomez@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>,
	kdevops@lists.linux.dev, Daniel Gomez <da.gomez@samsung.com>
Subject: Re: [PATCH 00/10] Bisectable Ansible-Lint Fixes - 2nd edition
Date: Sat, 6 Sep 2025 18:18:43 -0700	[thread overview]
Message-ID: <aLzdc82zDr7x_yYN@bombadil.infradead.org> (raw)
In-Reply-To: <20250905-ansible-lint-fixes-v1-0-8c07432896ec@samsung.com>

On Fri, Sep 05, 2025 at 12:51:04PM +0200, Daniel Gomez wrote:
> 1st edition:
> https://lore.kernel.org/kdevops/175621503052.35735.12978680330721392297.b4-ty@samsung.com/
> 
> Here are more Ansible lint fixes provided by a downstream script [1]
> that automatically applies individual lint rules and commits them.

I think we need consensus that we want to merge these sorts of changes
in the future without having to spin wheels for a review. On my part
I thinks its a requiremen to scale with genai. So moving forward at
least on my part I'd be happy if we do that, no need to wait for a
review or ack from me.

But in case its not clear

Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>

> As a side note, the script [2] may be ready to upstream. It combines
> the scripts/fix_ansible_lint.py (manual fixes) from Luis including some
> fixes found. The script also has support for an ansible-lint wrapper
> (autofixer):
> 
> ./scripts/ansible-lint-comprehensive-fixer.py \
>   --fix-with-ansible-lint \
>   --fix-with-custom-rules \
>   --auto
> 
> The branch contains notes of the fixes and features. We may want to
> upstream the script at some point for CI purposes and avoid introducing
> fixable lint issues in the future.

Indeed. Let's just merge it?

  Luis

      parent reply	other threads:[~2025-09-07  1:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-05 10:51 [PATCH 00/10] Bisectable Ansible-Lint Fixes - 2nd edition Daniel Gomez
2025-09-05 10:51 ` [PATCH 01/10] devconfig: prevent ansible-lint no-free-form Daniel Gomez
2025-09-05 10:51 ` [PATCH 02/10] milvus: fix YAML syntax error in benchmark_setup.yml Daniel Gomez
2025-09-05 10:51 ` [PATCH 03/10] playbooks: ansible-lint fix yaml Daniel Gomez
2025-09-05 10:51 ` [PATCH 04/10] playbooks: ansible-lint fix command-instead-of-shell Daniel Gomez
2025-09-05 10:51 ` [PATCH 05/10] playbooks: ansible-lint fix fqcn Daniel Gomez
2025-09-05 10:51 ` [PATCH 06/10] playbooks: ansible-lint fix name Daniel Gomez
2025-09-05 10:51 ` [PATCH 07/10] playbooks: ansible-lint fix key-order Daniel Gomez
2025-09-05 10:51 ` [PATCH 08/10] playbooks: ansible-lint fix jinja Daniel Gomez
2025-09-05 10:51 ` [PATCH 09/10] playbooks: ansible-lint fix jinja[spacing] Daniel Gomez
2025-09-05 10:51 ` [PATCH 10/10] playbooks: ansible-lint fix fqcn[action-core] Daniel Gomez
2025-09-07  1:18 ` Luis Chamberlain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLzdc82zDr7x_yYN@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=da.gomez@kernel.org \
    --cc=da.gomez@samsung.com \
    --cc=kdevops@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox