public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Daniel Gomez <da.gomez@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>,
	kdevops@lists.linux.dev, Daniel Gomez <da.gomez@samsung.com>
Subject: Re: [PATCH] guestfs: port status script to Ansible with libvirt URI fix
Date: Wed, 17 Sep 2025 07:28:55 -0700	[thread overview]
Message-ID: <aMrFp6nDF9BNcHG-@bombadil.infradead.org> (raw)
In-Reply-To: <20250917-status-script-v1-1-4a792f9ca518@samsung.com>

On Wed, Sep 17, 2025 at 10:49:31AM +0200, Daniel Gomez wrote:
> From: Daniel Gomez <da.gomez@samsung.com>
> 
> Convert scripts/status_guestfs.sh shell script to Ansible implementation
> in playbooks/roles/guestfs/tasks/status/main.yml. The new implementation:
> 
> - Uses proper libvirt_uri variable for LIBVIRT_DEFAULT_URI
> - Integrates with DIY callback to show command output
> - Provides idempotent Ansible approach with tagging support
> - Fixes missing libvirt URI context that caused empty virsh output
> 
> Update scripts/guestfs.Makefile to call ansible-playbook with --tags status
> instead of the shell script. Add missing output yaml to LIBVIRT_URI_PATH
> for proper URI variable generation.
> 
> Generated-by: Claude AI
> Signed-off-by: Daniel Gomez <da.gomez@samsung.com>

Thanks! Applied and pushed!

  Luis

      parent reply	other threads:[~2025-09-17 14:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-17  8:49 [PATCH] guestfs: port status script to Ansible with libvirt URI fix Daniel Gomez
2025-09-17 13:45 ` Chuck Lever
2025-09-17 14:28 ` Luis Chamberlain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aMrFp6nDF9BNcHG-@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=da.gomez@kernel.org \
    --cc=da.gomez@samsung.com \
    --cc=kdevops@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox