From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 075B52D47F9 for ; Wed, 17 Sep 2025 14:28:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758119337; cv=none; b=BpWPOg6RWhIJxUwIoDd2t5+c2Ply0+RrySaKQ6QQ4k3MiVxMsnDWNVWgnJMVtndof8RmEmThqbDmO8tWMl0FHsxu3BcYC6VVM+zF8I5CY0qtILeYokcVy2Ie+xyIpQyJ+o54GAT3yNOzHWSoHlnzToC2haHYsGq656hSr3KcFZo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758119337; c=relaxed/simple; bh=dFCOZhfigJrK3ZvE9+CzHK1f0DSoO2VticfjGL89Fx0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uQD7uN9rc1b9mzShnmARuj/Dc2wmV3cT6kkm5aapxcYbEBK4AevuCs071Ig7azKoUPZ4aXebG9TbqVGAnk26Olp4KsM7n8nhxwJzgjxMNcaTyxpSkrL00wLD+dC4tmWc8A6e1mPgOLQpgzEswfsBQ+ILEdb4rd3wWFYsUyjDErA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ctjVciMI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ctjVciMI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66DAFC4CEE7; Wed, 17 Sep 2025 14:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758119336; bh=dFCOZhfigJrK3ZvE9+CzHK1f0DSoO2VticfjGL89Fx0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ctjVciMIFhDvVGP1XQ0MeWSvwVkbcd8PO8HC+Odby2yNg6Sbto5zanLx3ERhubIgx NFadgOxJ6wacDvxJ3btsNojxB1M3Rp7+0sKUxS3I2ih6lOjUBGO4jczLfLxyFp00R/ zvS+CXMjNVYtZ4Okr775+2AoSxV/sANsaJv8LgSqqcDYmol3LLQZEbHPbK7hLi+Zmg D15CyfZBh/JpAry8mMWM3Ob9eKxN6r9brVmjF6JwzQBk6nHGbl7zein1fvC5wGSanN C3tXJAMyo/N+z4RIo9TQsR3dJQy2id8NVYGVsNuox7QhSec43BX8GoEIOXqtkhSe4E d8FrSAMaV/TXA== Date: Wed, 17 Sep 2025 07:28:55 -0700 From: Luis Chamberlain To: Daniel Gomez Cc: Chuck Lever , kdevops@lists.linux.dev, Daniel Gomez Subject: Re: [PATCH] guestfs: port status script to Ansible with libvirt URI fix Message-ID: References: <20250917-status-script-v1-1-4a792f9ca518@samsung.com> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250917-status-script-v1-1-4a792f9ca518@samsung.com> On Wed, Sep 17, 2025 at 10:49:31AM +0200, Daniel Gomez wrote: > From: Daniel Gomez > > Convert scripts/status_guestfs.sh shell script to Ansible implementation > in playbooks/roles/guestfs/tasks/status/main.yml. The new implementation: > > - Uses proper libvirt_uri variable for LIBVIRT_DEFAULT_URI > - Integrates with DIY callback to show command output > - Provides idempotent Ansible approach with tagging support > - Fixes missing libvirt URI context that caused empty virsh output > > Update scripts/guestfs.Makefile to call ansible-playbook with --tags status > instead of the shell script. Add missing output yaml to LIBVIRT_URI_PATH > for proper URI variable generation. > > Generated-by: Claude AI > Signed-off-by: Daniel Gomez Thanks! Applied and pushed! Luis