public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: Chuck Lever <cel@kernel.org>
To: Daniel Gomez <da.gomez@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
	Chuck Lever <chuck.lever@oracle.com>,
	kdevops@lists.linux.dev, Daniel Gomez <da.gomez@samsung.com>
Subject: Re: [PATCH v4 1/2] ansible: use native verbosity config instead of custom AV variable
Date: Wed, 3 Dec 2025 15:26:04 -0500	[thread overview]
Message-ID: <aTCc3Otx5Srvw-da@klimt.1015granger.net> (raw)
In-Reply-To: <20251202-lucid-v4-1-a077cca27736@samsung.com>

On Tue, Dec 02, 2025 at 12:11:16AM +0100, Daniel Gomez wrote:
> From: Daniel Gomez <da.gomez@samsung.com>
> 
> Replace the custom AV makefile variable and validate_av.py script with
> Ansible's native verbosity configuration. The verbosity level is now
> configured via the verbosity key in ansible.cfg, which can be set
> through the new ANSIBLE_CFG_VERBOSITY Kconfig option.
> 
> This change removes the $(ANSIBLE_VERBOSE) variable from all 52
> Makefiles that were passing it to ansible-playbook calls. Since
> ansible.cfg now contains the verbosity setting, the command-line
> argument is no longer needed.
> 
> The runtime override is now done using the standard ANSIBLE_VERBOSITY
> environment variable instead of the custom AV=N syntax.
> 
> Generated-by: Claude AI
> Signed-off-by: Daniel Gomez <da.gomez@samsung.com>

> diff --git a/workflows/mmtests/Makefile b/workflows/mmtests/Makefile
> index c6248b95..712ce70d 100644
> --- a/workflows/mmtests/Makefile
> +++ b/workflows/mmtests/Makefile
> @@ -2,55 +2,55 @@ MMTESTS_ARGS	:=
>  
>  
>  mmtests:
> -	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \
> +	$(Q)ansible-playbook \
>  		playbooks/mmtests.yml \
>  		--extra-vars=@./extra_vars.yaml  \
>  		--tags deps,setup
>  		$(MMTESTS_ARGS)
>  

Looks like this target is missing a backslash at the end of
"--tags deps,setup", though that has been missing since
commit 0b829e6a1fb8 ("mmtests: add support for Mel Gorman's
mmtests").

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

-- 
Chuck Lever

  reply	other threads:[~2025-12-03 20:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-01 23:11 [PATCH v4 0/2] Lucid: A custom Ansible stdout callback for kdevops Daniel Gomez
2025-12-01 23:11 ` [PATCH v4 1/2] ansible: use native verbosity config instead of custom AV variable Daniel Gomez
2025-12-03 20:26   ` Chuck Lever [this message]
2025-12-01 23:11 ` [PATCH v4 2/2] ansible: add lucid callback plugin for clean output Daniel Gomez
2025-12-03 21:11   ` Chuck Lever
2025-12-01 23:14 ` [PATCH v4 0/2] Lucid: A custom Ansible stdout callback for kdevops Daniel Gomez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTCc3Otx5Srvw-da@klimt.1015granger.net \
    --to=cel@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=da.gomez@kernel.org \
    --cc=da.gomez@samsung.com \
    --cc=kdevops@lists.linux.dev \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox