From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70A77350D6B for ; Tue, 2 Sep 2025 19:59:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756843148; cv=none; b=uCiAf0Cc/MZoSDoEZdoepGnOU6V5atCXb0kk/NYXdN0TQ1C1KbPXP5t0kg+/oMqPOlUXXI2dZasDQDXNI/0O5bDQXRKaOiXXYw96JPrVDnYZ0wInOAOdmt03D/cjqFnWOYGZoudTE8Rl4arm14qhOYTB+UE4ExuJSX+x6089h6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756843148; c=relaxed/simple; bh=zjR/bc3CIu+BlHhY6iXyF4kOGiWfHTC1/7Wui0nrB+c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=inlhU8agryyQOjRt7oryiPa6Kt9K7pCrZBwIRfpmA/y8Lq+ZopQVfYzkxpId6tmK/Cc1GzK1uYxUBHIq209WPIOFJ4oS60Rf8jMumNYkIKhpEdaIljtZTHgDISfuhgQ3zHFh7Q+eAQ6cpHyD66bm1w6FdkUL/492aQtkxljIRho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gbE5iGqg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gbE5iGqg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42B8CC4CEF7; Tue, 2 Sep 2025 19:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756843148; bh=zjR/bc3CIu+BlHhY6iXyF4kOGiWfHTC1/7Wui0nrB+c=; h=Date:Reply-To:Subject:To:Cc:References:From:In-Reply-To:From; b=gbE5iGqgur0L9ZGph0uzNIx9NsX0beZ4/Jl1RD9hjXb9eEFeg6DE/ImI1Hz5fPQlY +fRQx0InkJcWsYT0riWPwNm1GBo6ICwKfYZPmdODm53sj7dNGFx2byYn6Wi6iYPY9J y7QfpdfVLU7ftajBO3UwISLEAfBl28lGRm+fpDQIzjwAyz3yMaz44t+aVp2e052JTI 36+POBOWAcw/gwsJHuys63mRDWcNyOTJiTXmldE8KdUVm+KfMIZaYp6yQbGpw25v7y 2IJGbJR3LrfRVCbnAj6dtroMBD1GavygcXqJWPbQExq7SqBgFRc709I5j7t6UKpyhc 0vP5R+A0AR2bw== Message-ID: Date: Tue, 2 Sep 2025 21:59:05 +0200 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Daniel Gomez Subject: Re: [PATCH v2 25/37] update_etc_hosts: ipaddr To: Chuck Lever , kdevops@lists.linux.dev Cc: Chuck Lever , Luis Chamberlain References: <20250902135426.815079-1-cel@kernel.org> <20250902135426.815079-26-cel@kernel.org> Content-Language: en-US From: Daniel Gomez Organization: kernel.org In-Reply-To: <20250902135426.815079-26-cel@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 02/09/2025 15.54, Chuck Lever wrote: > From: Chuck Lever > > ansible.netcommon.ipaddr is deprecated. See: > > https://docs.ansible.com/ansible/latest/collections/ansible/netcommon/ipaddr_filter.html > > Ensure the update_etc_hosts playbook uses the ansible.utils.ipaddr > plugin instead. > > Reviewed-by: Luis Chamberlain > Signed-off-by: Chuck Lever Reviewed-by: Daniel Gomez > --- > playbooks/roles/update_etc_hosts/tasks/main.yml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/playbooks/roles/update_etc_hosts/tasks/main.yml b/playbooks/roles/update_etc_hosts/tasks/main.yml > index dc40ededd539..17c85dc539b5 100644 > --- a/playbooks/roles/update_etc_hosts/tasks/main.yml > +++ b/playbooks/roles/update_etc_hosts/tasks/main.yml > @@ -51,8 +51,8 @@ > become_method: sudo > ansible.builtin.lineinfile: > dest: /etc/hosts > - regexp: ".*{{ item }}$" > - line: "{{ hostvars[item].ansible_all_ipv4_addresses | ipaddr(private_network) | first }} {{ item }}" > + regexp: '.*{{ item }}$' > + line: "{{ hostvars[item].ansible_all_ipv4_addresses | ansible.utils.ipaddr(private_network) | first }} {{ item }}" > state: present > with_items: "{{ ueh_hosts }}" > when: