Re: [RFC PATCH 2/5] Move the guestfs install-deps to the guestfs playbook

[Chuck Lever <cel@kernel.org>]

On 5/22/25 1:07 PM, Luis Chamberlain wrote:
> On Thu, May 22, 2025 at 09:31:34AM -0400, cel@kernel.org wrote:
>> From: Chuck Lever <chuck.lever@oracle.com>
>>
>> In addition to copying the install-deps scripts, switch to using
>> import_tasks, which has more dependable behavior and avoids the
>> need to add a "tags:" keyword on each step.
>>
>> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
>> diff --git a/playbooks/roles/guestfs/tasks/install-deps/debian/main.yml b/playbooks/roles/guestfs/tasks/install-deps/debian/main.yml
>> +  become: true
>> +  become_method: ansible.builtin.sudo
>> +  ansible.builtin.package:
>> +    update_cache: true
>> +    name:
>> +      - libguestfs-tools
>> +      - isc-dhcp-client
>> +    state: present
>> diff --git a/playbooks/roles/guestfs/tasks/install-deps/main.yml b/playbooks/roles/guestfs/tasks/install-deps/main.yml
>> +++ b/playbooks/roles/guestfs/tasks/install-deps/redhat/main.yml
>> +  become: true
>> +  become_method: ansible.builtin.sudo
>> +  ansible.builtin.package:
>> +    update_cache: true
>> +    name:
>> +      - libguestfs-tools
>> +      - dhcpcd
>> +    state: present
>> +  when:
>> +    - ansible_distribution != "Fedora"
>> diff --git a/playbooks/roles/guestfs/tasks/install-deps/suse/main.yml b/playbooks/roles/guestfs/tasks/install-deps/suse/main.yml
>> new file mode 100644
>> index 000000000000..c1bf24354612
>> --- /dev/null
>> +++ b/playbooks/roles/guestfs/tasks/install-deps/suse/main.yml
>> +  become: true
>> +  become_method: ansible.builtin.sudo
>> +  ansible.builtin.package:
>> +    name:
>> +      - libguestfs-tools
>> +      - dhcpcd
>> +    state: present
> 
> If you use the pkg role then we'd just need to add a definition
> overide for dhcpd for debian as isc-dhcp-client and we'd have one
> shared install step here.

Almost true. Check redhat/main.yml -- there is a little extra logic
there.

Also, I've done that kind of de-duplication in the past, and half
the time I end up undo-ing it because more logic is needed at a
later point.

Thinking ahead (always dangerous).


> Otherwise:
> 
> Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
> 
>   Luis


-- 
Chuck Lever