From: Daniel Gomez <da.gomez@kernel.org>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org, Hugh Dickins <hughd@google.com>,
Luis Chamberlain <mcgrof@kernel.org>,
kdevops@lists.linux.dev, Chuck Lever <chuck.lever@oracle.com>,
gost.dev@samsung.com, Daniel Gomez <da.gomez@samsung.com>
Subject: Re: [PATCH] generic/551: prevent OOM when running on tmpfs with low memory
Date: Wed, 18 Jun 2025 20:59:33 +0200 [thread overview]
Message-ID: <bb6b7187-1671-4a90-bfc3-6e4100e615b0@kernel.org> (raw)
In-Reply-To: <20250618184744.a7tzgv4dofrqheq6@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
>> diff --git a/tests/generic/551 b/tests/generic/551
>> index 4a7f0a638235e272ef55ffeb3b3e548707568379..6a7376d7a8e3580bee0a5c98eacdaf93c60c8d5c 100755
>> --- a/tests/generic/551
>> +++ b/tests/generic/551
>> @@ -38,6 +38,7 @@ do_test()
>> local truncsize
>> local total_size=0
>> local avail_mem=`_available_memory_bytes`
>> + [ "$FSTYP" = "tmpfs" ] && avail_mem=$((avail_mem - free_size_k * 1024))
>
> This makes sense to me. But better to have a comment for this. If you don't
> have more suggestions, I'll add below comment when I merge this patch.
>
> # To avoid OOM on tmpfs, subtract the amount of available memory allocated
> # for the tmpfs
Looks good to me.
>
> Reviewed-by: Zorro Lang <zlang@redhat.com>
Thanks
prev parent reply other threads:[~2025-06-18 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 13:00 [PATCH] generic/551: prevent OOM when running on tmpfs with low memory Daniel Gomez
2025-06-18 18:47 ` Zorro Lang
2025-06-18 18:59 ` Daniel Gomez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb6b7187-1671-4a90-bfc3-6e4100e615b0@kernel.org \
--to=da.gomez@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=da.gomez@samsung.com \
--cc=fstests@vger.kernel.org \
--cc=gost.dev@samsung.com \
--cc=hughd@google.com \
--cc=kdevops@lists.linux.dev \
--cc=mcgrof@kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox