From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D47D32AF1B for ; Tue, 2 Sep 2025 20:06:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756843609; cv=none; b=efw61UHKIV7ljGUsenq4yPVOnmMTlWH9wvUimAvVBI0DUGi8B64vfvEqFEVtDeF1lzwLqArL81S4rkYF66bpsJR385NhKaJCgPYDThGsNFTZsYGzmO/d8tAfEnj6FctYtrtQSom7qdd9X9Pjg1aWUZZW21K7Tz7OiDAQeftn2qg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756843609; c=relaxed/simple; bh=ZJPRXtK4QWuY0jYHCAFI1BODV6XSqWSD1hBJT8uOkQk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rdNQwr3ylLL0bpzrLXwPUnnNCXZ0oAAwYU/fLZIWickgP+7l09YFUTRdyKUsnYZPBoKtM0fubWodPH0FmRo/auAlyo1Iy7CN0wG+KH3ccINfOZUrWa9NvsND3rbuUFZjHOySRtxIec+UCZLlBx1UqXNjoSppbg0MrcoPxQ4v9/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rqt1ulsm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rqt1ulsm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73A94C4CEED; Tue, 2 Sep 2025 20:06:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756843609; bh=ZJPRXtK4QWuY0jYHCAFI1BODV6XSqWSD1hBJT8uOkQk=; h=Date:Reply-To:Subject:To:Cc:References:From:In-Reply-To:From; b=rqt1ulsm/z0rMtnZmOyMt9YbWdGaZDQyxEgh0zsjkEMRzfjePGq7xP51MB0N/sSTN jmy0zutR5LVMAoyG3A82cc3xniMaiM3JNzYSasyovl3HMBzeooRTh+fhjIIjHrG+rg 9qiFX7UmSmfQ9H5TTf/W9y1R/JUrTr6nvpODK6jBz6UxzjSSpMRNrs8/jcREf3D5jc wQYYa7mpU5/GsNW93jxmgS/Ns8u9hAKyIkvsVk8n62Od7ekS6+oBikeRZg8uGtTQd4 h8/ov7o0e8kcQNYQOc7rzmCsOQYazmQLf3Vn4t4NIpR6lUFDoIvPLjNGnzc9hDSuXf 01nKtl6Azwu0g== Message-ID: Date: Tue, 2 Sep 2025 22:06:46 +0200 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Daniel Gomez Subject: Re: [PATCH v2 26/37] Add an Ansible requirements.yml file To: Chuck Lever , kdevops@lists.linux.dev Cc: Chuck Lever , Luis Chamberlain References: <20250902135426.815079-1-cel@kernel.org> <20250902135426.815079-27-cel@kernel.org> Content-Language: en-US From: Daniel Gomez Organization: kernel.org In-Reply-To: <20250902135426.815079-27-cel@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 02/09/2025 15.54, Chuck Lever wrote: > From: Chuck Lever > > Commit b90d89d27659 ("Switch to the cloud.terraform.terraform > module") introduced the use of the cloud.terraform module, and > commit 7ccb64834eeb ("guestfs: Replace scripts/destroy_guestfs.sh > with an Ansible playbook") introduced the use of the > community.libvirt module. It would be friendly if kdevops could > pull in the Ansible modules it needs transparently. > > The requirements.yml file is a manifest of Ansible collections that > the project needs to run. Installation of these collections is made > automatic by adding: > > ansible-galaxy install -r requirements.yml > > to the "make ansible_cfg" step. This mechanism can keep cached > versions of collections up to date, and can also constrain a > cached collection to a specific version, if that's needed. I don't see the link between the galaxy step and the ansible_cfg target in the changes below. But in case we have it, I think this should be distro specific. Last time I checked, all these galaxy dependencies are provided in Debian by the ansible package. So it's not needed there. > > The initial file contains requirements I could find easily, and > should be updated over time as new collection dependencies are > introduced. > > See also: > > https://docs.ansible.com/ansible/latest/user_guide/collections_using.html > > Reviewed-by: Luis Chamberlain > Signed-off-by: Chuck Lever > --- > requirements.yml | 8 ++++++++ > scripts/ansible.Makefile | 5 +++++ > 2 files changed, 13 insertions(+) > create mode 100644 requirements.yml > > diff --git a/requirements.yml b/requirements.yml > new file mode 100644 > index 000000000000..a22691d3f86b > --- /dev/null > +++ b/requirements.yml > @@ -0,0 +1,8 @@ > +--- > +collections: > + - name: ansible.posix > + - name: ansible.utils > + - name: cloud.terraform > + - name: community.docker > + - name: community.general > + - name: community.libvirt > diff --git a/scripts/ansible.Makefile b/scripts/ansible.Makefile > index b0d2a8c12ee7..4efcf3e93b0e 100644 > --- a/scripts/ansible.Makefile > +++ b/scripts/ansible.Makefile > @@ -2,3 +2,8 @@ > > AV ?= 0 > export ANSIBLE_VERBOSE := $(shell scripts/validate_av.py --av "$(AV)") > + > +ansible-requirements: > + @$(Q)ansible-galaxy install -r requirements.yml Can you remove the "@"? That is controlled by the $(Q) var. > +PHONY += ansible-requirements > +DEFAULT_DEPS += ansible-requirements