From: Daniel Gomez <da.gomez@kernel.org>
To: kdevops@lists.linux.dev, da.gomez@kernel.org
Cc: Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH v2 0/4] Remove the bootlinux-local role
Date: Tue, 20 May 2025 22:47:00 +0200 [thread overview]
Message-ID: <d8724eed-28a4-4683-9856-227255fe28bf@kernel.org> (raw)
In-Reply-To: <d13abd38-f271-42b6-822f-956f943fb2f9@kernel.org>
On 20/05/2025 20.28, Daniel Gomez wrote:
>
>
> On 19/05/2025 18.21, cel@kernel.org wrote:
>> From: Chuck Lever <chuck.lever@oracle.com>
>>
>> The bootlinux-local role simply installs the bootlinux dependencies
>> on the Ansible controller when bootlinux_9p is set. There doesn't
>> seem to be a good reason that cannot be done via an extra step in
>> bootlinux.
>>
>> This version needs some testing, which I can get to later today.
>
>
> I've also tested this series here:
>
> https://github.com/linux-kdevops/kdevops/actions/runs/15135610179/
> job/42546562244
I've also tested this series manually on my setup and looks good.
Tested-by: Daniel Gomez <da.gomez@samsung.com>
>
>
>>
>> Changes since v1:
>> - Address Daniel's review comments and clarify patch descriptions
>>
>> Chuck Lever (4):
>> bootlinux: Remove the 'linux' tag
>> bootlinux: Modernize install-deps/main.yml
>> bootlinux: Switch to import_tasks for install-deps
>> bootlinux: Fold bootlinux-local into the bootlinux role
>>
>> playbooks/bootlinux-local.yml | 5 -
>> .../roles/bootlinux-local/defaults/main.yml | 3 -
>> .../roles/bootlinux-local/tasks/install-deps | 1 -
>> .../roles/bootlinux-local/tasks/main.yml | 19 ----
>> .../tasks/install-deps/debian/main.yml | 2 -
>> .../bootlinux/tasks/install-deps/main.yml | 21 +++--
>> playbooks/roles/bootlinux/tasks/main.yml | 92 ++++++++++---------
>> .../bootlinux/tasks/update-grub/debian.yml | 2 +-
>> .../bootlinux/tasks/update-grub/install.yml | 12 +--
>> .../bootlinux/tasks/update-grub/redhat.yml | 2 +-
>> .../bootlinux/tasks/update-grub/suse.yml | 2 +-
>> workflows/linux/Makefile | 3 -
>> 12 files changed, 72 insertions(+), 92 deletions(-)
>> delete mode 100644 playbooks/bootlinux-local.yml
>> delete mode 100644 playbooks/roles/bootlinux-local/defaults/main.yml
>> delete mode 120000 playbooks/roles/bootlinux-local/tasks/install-deps
>> delete mode 100644 playbooks/roles/bootlinux-local/tasks/main.yml
>>
>
next prev parent reply other threads:[~2025-05-20 20:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 16:21 [PATCH v2 0/4] Remove the bootlinux-local role cel
2025-05-19 16:21 ` [PATCH v2 1/4] bootlinux: Remove the 'linux' tag cel
2025-05-20 20:43 ` Daniel Gomez
2025-05-19 16:21 ` [PATCH v2 2/4] bootlinux: Modernize install-deps/main.yml cel
2025-05-20 18:27 ` Daniel Gomez
2025-05-19 16:21 ` [PATCH v2 3/4] bootlinux: Switch to import_tasks for install-deps cel
2025-05-20 20:33 ` Daniel Gomez
2025-05-19 16:21 ` [PATCH v2 4/4] bootlinux: Fold bootlinux-local into the bootlinux role cel
2025-05-20 20:41 ` Daniel Gomez
2025-05-20 18:28 ` [PATCH v2 0/4] Remove the bootlinux-local role Daniel Gomez
2025-05-20 20:47 ` Daniel Gomez [this message]
2025-05-20 20:52 ` Chuck Lever
2025-05-21 7:42 ` Daniel Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8724eed-28a4-4683-9856-227255fe28bf@kernel.org \
--to=da.gomez@kernel.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox