From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECFE01AAA1E for ; Tue, 20 May 2025 20:47:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747774023; cv=none; b=YL5dVdXnwbhJorA/GF0gndGMr+PnYzugiDH/gro6YZ0ygMbksAbRolqMHK+MPUSXZd1bkMIRAhmGTfeK+R1U8uIClus1UKBS/EJdLVGS5c0hp6X6h+kL+H6oTN0DdzX0meMrx1ElxanZPo0enrc1feVT5gdtGqw9GVTyAPBkXLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747774023; c=relaxed/simple; bh=OqQwPazjbpX1jGMH0VoE3U7tTajEnj3Xp2PSnH9dN8w=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=EGW8W31juvYDZr3NXitlW9t5nlZ8v3LL4O0z5ba90i6Iltcs5pfQ5CD7VMUvHllbG1T4ukBEQTwCQgA6DbyWTnUkBmrCSMtaGdzO4ey3DZbuAknRR6qjT3XDa3vfobLcY2XS8kYk1DyZr3OcMg0oiTbJD8R8RT+0ArAVhU7NKfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G/IEZH6v; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G/IEZH6v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B779EC4CEE9; Tue, 20 May 2025 20:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747774022; bh=OqQwPazjbpX1jGMH0VoE3U7tTajEnj3Xp2PSnH9dN8w=; h=Date:Reply-To:Subject:From:To:Cc:References:In-Reply-To:From; b=G/IEZH6vqVYow9+uIrvpkdMcBbBglnAzY9rlo3JYjOA9F5R4a9MiupCXObf3DlyPE z9MsKKxIUVX8y4UDPFjY4ww+ZPiE9UDzTG4QuQzhjiVH9XU7uI6jbfOx1dsg/uGPDv APNbQ7KUTyb0uZypO8fQyArkBjVV5OsiIL8yIyptjHyyeBKUQFrG1hUIZUzHr4GbL7 1oQ9fcU19cACbj26VyofWquIuZ0QDlnMnWi8+Hlhn7hu+LYY3Js/+3ISSalPEG7ja4 XON5wHfWXTAc71GRM3naK1dBsamujllSHfJ9z9c7scItPpF3TrWK82MjyEbXtV8muc XMZ9NyaZjAW0A== Message-ID: Date: Tue, 20 May 2025 22:47:00 +0200 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: cel@kernel.org Subject: Re: [PATCH v2 0/4] Remove the bootlinux-local role From: Daniel Gomez To: kdevops@lists.linux.dev, da.gomez@kernel.org Cc: Chuck Lever References: <20250519162131.381359-1-cel@kernel.org> Content-Language: en-US Organization: kernel.org In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 20/05/2025 20.28, Daniel Gomez wrote: > > > On 19/05/2025 18.21, cel@kernel.org wrote: >> From: Chuck Lever >> >> The bootlinux-local role simply installs the bootlinux dependencies >> on the Ansible controller when bootlinux_9p is set. There doesn't >> seem to be a good reason that cannot be done via an extra step in >> bootlinux. >> >> This version needs some testing, which I can get to later today. > > > I've also tested this series here: > > https://github.com/linux-kdevops/kdevops/actions/runs/15135610179/ > job/42546562244 I've also tested this series manually on my setup and looks good. Tested-by: Daniel Gomez > > >> >> Changes since v1: >> - Address Daniel's review comments and clarify patch descriptions >> >> Chuck Lever (4): >>    bootlinux: Remove the 'linux' tag >>    bootlinux: Modernize install-deps/main.yml >>    bootlinux: Switch to import_tasks for install-deps >>    bootlinux: Fold bootlinux-local into the bootlinux role >> >>   playbooks/bootlinux-local.yml                 |  5 - >>   .../roles/bootlinux-local/defaults/main.yml   |  3 - >>   .../roles/bootlinux-local/tasks/install-deps  |  1 - >>   .../roles/bootlinux-local/tasks/main.yml      | 19 ---- >>   .../tasks/install-deps/debian/main.yml        |  2 - >>   .../bootlinux/tasks/install-deps/main.yml     | 21 +++-- >>   playbooks/roles/bootlinux/tasks/main.yml      | 92 ++++++++++--------- >>   .../bootlinux/tasks/update-grub/debian.yml    |  2 +- >>   .../bootlinux/tasks/update-grub/install.yml   | 12 +-- >>   .../bootlinux/tasks/update-grub/redhat.yml    |  2 +- >>   .../bootlinux/tasks/update-grub/suse.yml      |  2 +- >>   workflows/linux/Makefile                      |  3 - >>   12 files changed, 72 insertions(+), 92 deletions(-) >>   delete mode 100644 playbooks/bootlinux-local.yml >>   delete mode 100644 playbooks/roles/bootlinux-local/defaults/main.yml >>   delete mode 120000 playbooks/roles/bootlinux-local/tasks/install-deps >>   delete mode 100644 playbooks/roles/bootlinux-local/tasks/main.yml >> >