Re: [PATCH 0/2] Align guest dependencies with their corresponding workflows

[Daniel Gomez <da.gomez@kernel.org>]

On 25/07/2025 09.39, Luis Chamberlain wrote:
> On Fri, Jul 25, 2025 at 09:33:52AM +0200, Daniel Gomez wrote:
>>
>>
>> On 24/07/2025 21.48, Luis Chamberlain wrote:
>>> On Thu, Jul 24, 2025 at 08:34:14PM +0200, Daniel Gomez wrote:
>>>> Several guest services (krb5, kdc, smbd, iscsi, nfsd) are missing from
>>>> various host workflow template files, creating kconfig configuration
>>>> inconsistencies. This occurs when workflows either lack implementation
>>>> support for these services or have no functional dependency on them.
>>>> This patch series ensures kconfig options accurately reflect the
>>>> services actually available in each workflow template.
>>>>
>>>> Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
>>>
>>> Looks good, just stylistic, I think its easier to just have
>>>
>>> Generated-by:
>>> Signed-off-by:
>>>
>>> Instead of:
>>>
>>> Generated-by:
>>>
>>> Signed-off-by:
>>>
>>> No point in the extra new line.
>>
>> For that, I think it's better to update CLAUDE.md to be consistent. This is what
>> it generated:
>>
>>     docs: update commit message format for Claude AI
> 
> My testing showed that was not enough. Also the white space noise is a

I pushed it already. Sorry about that as the patch has the blank space.

> pain. How about:
> From 3dca57c647d12c7fe437cb2d439cb3b0440f53f8 Mon Sep 17 00:00:00 2001
> From: Luis Chamberlain <mcgrof@kernel.org>
> Date: Thu, 24 Jul 2025 20:41:15 -0700
> Subject: [PATCH] Makefile: add make style for style checking
> 
> Add a 'make style' which helps humans and bots follow some sensible
> coding conventions.
> 
> - Add scripts/detect_whitespace_issues.py check for white space eye sores
> - Add scripts/check_commit_format.py to validate Generated-by and the
>   Signed-off-by spacing
> - Add scripts/fix_whitespace_issues.py to help with stupid spacing
>   eyesores
> - Update CLAUDE.md to ensure it runs 'make style'

This is pretty much like kdevops version of the "scripts/checkpatch.pl" in the
kernel, right? Well, a first simple version of it and integrated in Claude Code
to be executed after commits.

So, I was looking into having something like checkpatch some time ago. Now, with
this generative AI there's no reason to wait. So I think it's a good idea to
go with that. But it's missing b4 integration. "b4 prep --check" for the kernel
runs checkpatch like this [1]:

./scripts/checkpatch.pl --terse --no-summary --mailback --showfile.

Link: https://b4.docs.kernel.org/en/latest/contributor/prep.html#checking-your-work [1]

We just extend the .b4-config to customize it for kdevops:

[b4]
prep-perpatch-check-cmd = make style

I know this is Claude Code vs manual patches. I think both paths need to run
the same scripts.

I'd like the check step to also do more things like running Ansible lint as
discussed here [2]:

Link: https://lore.kernel.org/kdevops/gbpb6kxm5bh4xix2otgo5by5ubuv6jyezhtrfzdtltbzxv2niw@vcnlebdwqclr/ [2]

In this branch [3] I was experimenting with pre-commit and spellcheck on GH CI:

6668fedb95fc github/workflows/fstests.yml: add pre-commit codespell support
ccb55f87121b pre-commit: codespell: update v2.2.5 -> v2.4.1
cc27e2df77ae pre-commit: fix lint indentation warnings

Link: https://github.com/dkruces/kdevops/commits/dagomez/next/ [3]

I've lost the Ansible lint experiments but they were similar to codespell.
Adding support for these would be great in the check path. But running that only
for the changes was the "trickiest" part.