From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87EFA450E8
	for <kdevops@lists.linux.dev>; Tue, 17 Oct 2023 15:45:49 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qSbMJwJC"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A583FC433CA;
	Tue, 17 Oct 2023 15:45:48 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1697557549;
	bh=5AENy/EyImB3FN1n7qJXJtG9dUqIqi9Ko5TwEaa0AZ4=;
	h=Subject:From:To:Cc:Date:In-Reply-To:References:From;
	b=qSbMJwJCJIB9brqbseXp/Cbu4MBcZ0gC6FSzE78Y2oN41lUh160l5i5u1IgvoeTeB
	 eTKTh9xorOoeqPi/W3SY8nX/AiBdiciIc6q79MApBgQDHDFEGEGPi3p0DDIY6B97hx
	 Toq+0mdUUl78uUpO/b2XWiJWVUgMirdWZOPrioOK/siHwUjXYboXjB08IoLfPQ+omZ
	 7TMn0EcqOzSBgo5MaL1qvrAhrWmFylEICgLVTXWnTJc8CEf93kII+Z2xyVeJiDx84H
	 8f+uDyUGYjU1CdKw67bet1gF0B6Qa0vewgGYFcVWKGwQa0zTLrgHQFpHvZ/MvSzFHs
	 lup0CKvCLukQQ==
Message-ID: <e160eddbbb953557be1ff2845196b4afecda04bb.camel@kernel.org>
Subject: Re: [PATCH] fstests: ensure the fstests_prep_localhost tasks get
 executed
From: Jeff Layton <jlayton@kernel.org>
To: Scott Mayhew <smayhew@redhat.com>, mcgrof@kernel.org
Cc: kdevops@lists.linux.dev
Date: Tue, 17 Oct 2023 11:45:47 -0400
In-Reply-To: <20231017143344.430183-1-smayhew@redhat.com>
References: <20231017143344.430183-1-smayhew@redhat.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
X-Mailing-List: kdevops@lists.linux.dev
List-Id: <kdevops.lists.linux.dev>
List-Subscribe: <mailto:kdevops+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:kdevops+unsubscribe@lists.linux.dev>
MIME-Version: 1.0

On Tue, 2023-10-17 at 10:33 -0400, Scott Mayhew wrote:
> Currently they get skipped because localhost isn't included in
> ansible-playbook --limit arg.  This results in subsequent errors when
> parsing fstests results if the junitxml and/or junitparser modules
> aren't already installed.
>=20
> Fixes: e00143f6 ("fstests: add support for testing NFS")
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
> ---
>  workflows/fstests/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/workflows/fstests/Makefile b/workflows/fstests/Makefile
> index 370be411..e6346084 100644
> --- a/workflows/fstests/Makefile
> +++ b/workflows/fstests/Makefile
> @@ -137,7 +137,7 @@ DYNAMIC_RUNTIME_VARS +=3D , "fstests_start_after_test=
": "$(START_AFTER)"
>  endif
> =20
>  fstests:
> -	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l baseline,dev \
> +	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l localhost,baseline,dev \
>  		-f 30 -i hosts playbooks/fstests.yml --skip-tags run_tests,copy_result=
s $(LIMIT_HOSTS)
> =20
>  fstests-kdevops-setup: $(KDEVOPS_EXTRA_VARS)

LGTM. Merged into master.

Cheers,
--=20
Jeff Layton <jlayton@kernel.org>