* [PATCH] fstests: ensure the fstests_prep_localhost tasks get executed
@ 2023-10-17 14:33 Scott Mayhew
2023-10-17 15:45 ` Jeff Layton
0 siblings, 1 reply; 2+ messages in thread
From: Scott Mayhew @ 2023-10-17 14:33 UTC (permalink / raw)
To: mcgrof; +Cc: jlayton, kdevops
Currently they get skipped because localhost isn't included in
ansible-playbook --limit arg. This results in subsequent errors when
parsing fstests results if the junitxml and/or junitparser modules
aren't already installed.
Fixes: e00143f6 ("fstests: add support for testing NFS")
Signed-off-by: Scott Mayhew <smayhew@redhat.com>
---
workflows/fstests/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/workflows/fstests/Makefile b/workflows/fstests/Makefile
index 370be411..e6346084 100644
--- a/workflows/fstests/Makefile
+++ b/workflows/fstests/Makefile
@@ -137,7 +137,7 @@ DYNAMIC_RUNTIME_VARS += , "fstests_start_after_test": "$(START_AFTER)"
endif
fstests:
- $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l baseline,dev \
+ $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l localhost,baseline,dev \
-f 30 -i hosts playbooks/fstests.yml --skip-tags run_tests,copy_results $(LIMIT_HOSTS)
fstests-kdevops-setup: $(KDEVOPS_EXTRA_VARS)
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fstests: ensure the fstests_prep_localhost tasks get executed
2023-10-17 14:33 [PATCH] fstests: ensure the fstests_prep_localhost tasks get executed Scott Mayhew
@ 2023-10-17 15:45 ` Jeff Layton
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2023-10-17 15:45 UTC (permalink / raw)
To: Scott Mayhew, mcgrof; +Cc: kdevops
On Tue, 2023-10-17 at 10:33 -0400, Scott Mayhew wrote:
> Currently they get skipped because localhost isn't included in
> ansible-playbook --limit arg. This results in subsequent errors when
> parsing fstests results if the junitxml and/or junitparser modules
> aren't already installed.
>
> Fixes: e00143f6 ("fstests: add support for testing NFS")
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
> ---
> workflows/fstests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/workflows/fstests/Makefile b/workflows/fstests/Makefile
> index 370be411..e6346084 100644
> --- a/workflows/fstests/Makefile
> +++ b/workflows/fstests/Makefile
> @@ -137,7 +137,7 @@ DYNAMIC_RUNTIME_VARS += , "fstests_start_after_test": "$(START_AFTER)"
> endif
>
> fstests:
> - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l baseline,dev \
> + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l localhost,baseline,dev \
> -f 30 -i hosts playbooks/fstests.yml --skip-tags run_tests,copy_results $(LIMIT_HOSTS)
>
> fstests-kdevops-setup: $(KDEVOPS_EXTRA_VARS)
LGTM. Merged into master.
Cheers,
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-17 15:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-17 14:33 [PATCH] fstests: ensure the fstests_prep_localhost tasks get executed Scott Mayhew
2023-10-17 15:45 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox